fix(ios): reload sandbox when jsBundleSource prop changes#18
Open
fix(ios): reload sandbox when jsBundleSource prop changes#18
Conversation
RCTHost is initialized with a bundleURLProvider closure that calls the delegate's bundleURL on every reload. Trigger host reload instead of recreating the entire factory to pick up the new bundle URL. Co-authored-by: Cursor <cursoragent@cursor.com>
CAMOBAP
force-pushed
the
fix/reload-sandbox-on-bundle-source-change
branch
from
a92974a to
31d49c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where changing the jsBundleSource prop does not reload the sandbox with the new bundle. Alternative approach to #17 — instead of destroying and recreating the entire RCTReactNativeFactory, this triggers a reload on the existing RCTHost.
Why this approach is better than #17
RCTHost is initialized with a bundleURLProvider closure that calls the delegate's bundleURL method on every reload. Since updateProps already updates the delegate's _jsBundleSource, we just need to tell the host to reload — it will pick up the new URL automatically.
Recreating the factory (as proposed in #17) is overkill because it tears down:
...then rebuilds everything from scratch. This causes a visible blank flash and is unnecessarily expensive.