Repository navigation
fix(apple-runner): keep the keyboard return tap iOS-only - #4608
Conversation
#4589 moved the return-control lookup into findKeyboardReturnControl and left tapKeyboardReturnControl calling XCUIElement.tap() on every platform. tap() is unavailable on tvOS, so the tvOS runner build in the release job failed. Restore the iOS guard the original function had. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
No issues found across 1 file
You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Size Report
Startup median (7 runs, lower is better):
|
|
Reviewed at de00fd3: the change restores the |
Apex Sentinel · ✅ ApproveNo open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
The v0.21.38 release build failed (run 43918681966, Build job):
RunnerTests+Keyboard.swift:518: error: tap() is unavailable in tvOS.#4589 moved the return-control lookup into
findKeyboardReturnControland lefttapKeyboardReturnControlcallingXCUIElement.tap()on every platform. The original function wrapped that tap in#if os(iOS); this restores the guard. Main CI does not build the tvOS runner, so only the release job caught it.Validation: local
build-for-testingfor tvOS and visionOS simulators both reportTEST BUILD SUCCEEDEDwith this change.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.