Skip to content

fix(apple-runner): keep the keyboard return tap iOS-only - #4608

Merged
thymikee merged 1 commit into
mainfrom
fix/runner-tvos-return-tap
Nov 16, 2026
Merged

thymikee merged 1 commit into
mainfrom
fix/runner-tvos-return-tap

Conversation

@thymikee

@thymikee thymikee commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

The v0.21.38 release build failed (run 43918681966, Build job): RunnerTests+Keyboard.swift:518: error: tap() is unavailable in tvOS.

#4589 moved the return-control lookup into findKeyboardReturnControl and left tapKeyboardReturnControl calling XCUIElement.tap() on every platform. The original function wrapped that tap in #if os(iOS); this restores the guard. Main CI does not build the tvOS runner, so only the release job caught it.

Validation: local build-for-testing for tvOS and visionOS simulators both report TEST BUILD SUCCEEDED with this change.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

#4589 moved the return-control lookup into findKeyboardReturnControl and left
tapKeyboardReturnControl calling XCUIElement.tap() on every platform. tap() is
unavailable on tvOS, so the tvOS runner build in the release job failed. Restore
the iOS guard the original function had.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.33 MB 6.33 MB +42 B
Package (unpacked) 6.33 MB 6.33 MB +42 B
Package (download) 1.92 MB 1.92 MB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 21.8 ms 28.3 ms +6.5 ms
CLI --help 61.3 ms 74.3 ms +13.0 ms

@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at de00fd3: the change restores the #if os(iOS) guard that tapKeyboardReturnControl had before #4589, so iOS behaviour is unchanged and tvOS, visionOS and macOS return false without querying or tapping, as before. No other unguarded iOS-only XCTest call was introduced. All four runner platform builds (iOS, macOS, tvOS, visionOS) pass through the same build-xcuitest-apple.sh path the release job uses. There are no conflicts. This unblocks the v0.21.38 release build.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 16, 2026
@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

No open findings.

Reviewed with this repository's own Sentinel configuration (cb335952017e).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee
thymikee merged commit 83a8e53 into main Nov 16, 2026
20 checks passed
@thymikee
thymikee deleted the fix/runner-tvos-return-tap branch November 16, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant