Repository navigation
Conversation
The helper's screenshot response now carries the default display's rotation and the display count, so a helper capture no longer spawns adb shell dumpsys display beside it. The screencap fallback and a helper without the headers keep the dumpsys probe; a device with more than one display still reports no rotation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…antics Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveNo open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
thymikee
marked this pull request as ready for review
November 16, 2026 17:21
Contributor
There was a problem hiding this comment.
No issues found across 10 files
You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each Android helper screenshot spawned
adb shell dumpsys displayto learn the rotation. The helper's screenshot response now carriesdisplayRotation(default display, read before and after the capture, sent only when both agree) anddisplayCount. A helper capture spawns no adb process.dumpsysstays for thescreencapfallback, orientation settle, and a helper without the headers.10 files touched.
Validation
Head
04a2045827, base244d1ff683. Emulator API 35,screenshoton a live helper session. 2 passes × 6 interleaved rounds × 5 shots (n=60 per arm), load 23–49 on 12 cores:Main already ran the probe in parallel with the capture, so wall time stays within host noise. The firm gain is one fewer adb call per screenshot, which counts more on remote devices.
At all four rotations, the helper rotation matched
dumpsys mCurrentOrientationand the helper PNG was pixel-identical toscreencap. This was verified on API 35 only. A second overlay display made the helper report no rotation.Focused unit tests, helper JVM suite, and
pnpm typecheckpass. CI is green.🤖 Generated with Claude Code