Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 40 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed) No open findings. 1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+Keyboard.swift:207 |
iOS return-key label can only ever be one of nine English probe labels |
2 findings below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (cb335952017e).
Review of 3a4d56c3 · 16.11.2026 16:56 UTC
Apex Sentinel · ✅ Approve
2 finding(s): 2 minor.
🟡 Minor (2)
| Where | Finding |
|---|---|
apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+Keyboard.swift:207 |
iOS return-key read can only name the nine probe labels |
apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/UnitTests/RunnerTests+ModelsTests.swift:272 |
Merge-base exemption now skips witness assertion for volumeUp/volumeDown |
Reviewed with this repository's own Sentinel configuration (b3c1a3c8abd9).
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 3a4d56c. The verdict and the full list are in the summary comment.
|
The keyboard help text describes The help string at https://github.com/callstack/agent-device/blob/3a4d56c/packages/command-surface/src/system/index.ts#L322 says Not blocking, take or leave: the iOS status read classifies the element's localized label instead of the matched probe label or identifier, so a Polish "szukaj" key answers The open inline threads still apply. The review threads on visionOS eligibility (#4602 (comment)), comma truncation of the action label (#4602 (comment)) and the ModelsTests early return (#4602 (comment)) hold, as do the threads on the The live device runs are reported in the PR body. The checks show 16 of 17 passing, and the one pending is a review bot that does not exercise this code. There are no conflicts. Before merge, please fix the |
6c78740 to
5981d97
Compare
`keyboard status` now answers what the visible keyboard's return key offers, on both platforms. Android parses the focused editor's `imeOptions` action out of the `dumpsys input_method` output the visibility read already fetched, so no extra adb call is made; `IME_FLAG_NO_ENTER_ACTION` outranks the action bits, and an app's `actionLabel` is reported beside its action kind. iOS gains a runner status command that reads the same return control `keyboard enter` presses, so the two commands cannot disagree about the same key. Both readings project into one vocabulary (`KEYBOARD_RETURN_KEYS` in the contracts package): `none` is only Android's to establish, `unknown` says a key is there this read cannot name, and a hidden keyboard reports neither field. Snapshot output and its device calls are unchanged. - Apple: `keyboardStatus` runner command (read-only, app-windows surface), `RunnerKeyboardStatus` - Android: `parseAndroidReturnKey` in `device-input-state.ts` - Daemon: projects `returnKey`/`returnKeyLabel`; a visibility-only owner publishes `unknown` - Output: `Return key:` and `Return key label:` lines, plus the JSON fields
5981d97 to
fd62e5f
Compare
|
Review round addressed at Contracts and platform mapping
iOS status read no longer needs English Android Help, docs and tests Also: the Swift trailing-comma guard CI flagged is fixed — that syntax needs Swift 6.1+ — verified across |
Summary
keyboard statusnow answers what the visible keyboard's return key offers, on both platforms.Before / after, same command:
Android parses the focused editor's
imeOptionsout of thedumpsys input_methodoutput the visibility read already fetched, so no extra adb call;IME_FLAG_NO_ENTER_ACTIONoutranks the action bits, with the app'sactionLabelbeside it. iOS gains a read-onlykeyboardStatusrunner command that reads the keyboard's own key elements, so a localized return key keeps its wording;keyboard enter's probe order is unchanged. Both project into one vocabulary (KEYBOARD_RETURN_KEYS): only Android establishesnone;unknownmeans a key this read cannot name; a hidden keyboard reports neither field. Limrun iOS now servesstatustoo.Touched files: 41.
Validation
Tested at
fd62e5fd79.pnpm typecheck,format,lint,generate:capabilitiesgreen; affectedunit-coreprojects: 521 files / 5270 tests. Swift runner unit tests, built withAGENT_DEVICE_XCUITEST_INCLUDE_UNIT_TESTS=1: 16 cases, 0 failures. No localcheck:affectedreceipt for this head (the branch moved while it waited on the host validation lock), so gates are CI's.Device evidence (helper
0.21.38-dev,androidSnapshot.backend: android-helper):search/search; Polish keyboard →unknown, labelszukaj.search; tester email →done.