Skip to content

fix(open): do not take a lone status line for the first screen - #4601

Merged
thymikee merged 1 commit into
mainfrom
fix/first-screen-lone-status-text
Nov 16, 2026
Merged

thymikee merged 1 commit into
mainfrom
fix/first-screen-lone-status-text

Conversation

@thymikee

@thymikee thymikee commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

On a cold Expo bundle, the first capture after open on a local iOS simulator returned Expo's progress banner as the app's first screen. The tree was the app root plus one StaticText "Bundling 91%…". Two reads 200 ms apart agreed on it, so the #4513 rule (any labeled non-root element) accepted it.

The first screen now needs a labeled element that is not text, such as a button, or two different texts. A busy indicator still doesn't count. React Native mirrors a text into two nodes with the same label, so texts are counted by label, not by node.

A first screen made of a single line of text and nothing else now waits the full 10 s and returns loading. #4599 adds the opt-out for that case.

3 files: the rule, two tests (lone status line, two texts), and the docs.

Validation

At 1122461:

  • pnpm typecheck and pnpm lint pass.
  • Vitest passes for daemon and capture-kit: 5,614 tests.
  • Live, iPhone 17 Pro simulator on iOS 27.0, Agent Device Tester Debug dev build. Metro (expo start --dev-client --clear) was restarted before each cold run.
    • Before: open --relaunch --foreground returned 2 nodes, Bundling 91%…, in 7.5 s. A second cold run returned Bundling 94%….
    • After: 2 cold runs returned the 52-node home screen in 11.2 s and 11.1 s, with no postGestureOutcome. The warm relaunch is unchanged: 52 nodes in 6.8 s.
  • CI owns the remaining gates.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

A cold Expo bundle shows only "Bundling 91%…" over the root, and two reads
200 ms apart agree on it, so open returned the banner as the first screen.
The first screen now needs a labeled element that is not text, or two
different texts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.32 MB 6.32 MB +102 B
Package (unpacked) 6.32 MB 6.32 MB +102 B
Package (download) 1.92 MB 1.92 MB +30 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 38.6 ms 23.6 ms -15.0 ms
CLI --help 68.6 ms 48.9 ms -19.7 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread website/docs/docs/commands.md Resolved
@thymikee

Copy link
Copy Markdown
Member Author

The code at 1122461 looks ready to me, and I found no problems that need a change. The live cold-Expo before and after runs in the PR description reach the changed route (cold Metro, open --relaunch --foreground, first capture). There are no conflicts. The Android Smoke Tests job failed on "persistent helper snapshot should expose fixture dialog"; that looks unrelated, because markPostOpenStabilization returns early for non-Apple platforms, so the changed rule never runs on Android, and the job has been re-run. Smoke Tests (ios) and Coverage are still running. Smoke Tests (ios) opens an app on a simulator and passes through this wait, so a failure there would be related to this change. Not blocking, and you can take or leave these: in website/docs/docs/commands.md:102 the new clause "or a single line of text" sits before "such as a game canvas", so the example reads wrongly, and "a labeled element that is not text" drops "label or value" while the code still accepts a value-only element; only role text counts as a status line in deferred-interaction-outcome.ts:275, so a banner exposed as an Other container with the same reading would be accepted again, and counting distinct readings instead of roles would cover that; a real single-text first screen now waits the full 10 seconds and reports postGestureOutcome loading until #4599 lands the opt-out, which I accept as the documented trade-off. The next step before merge is for CI to finish green.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 16, 2026
@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
website/docs/docs/commands.md:102 Docs sentence makes 'game canvas' the example of a single line of text

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (244d1ff68344).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on 1122461. The verdict and the full list are in the summary comment.

Comment thread website/docs/docs/commands.md Resolved
@thymikee
thymikee merged commit 34e4841 into main Nov 16, 2026
22 of 23 checks passed
@thymikee
thymikee deleted the fix/first-screen-lone-status-text branch November 16, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant