Repository navigation
fix(open): do not take a lone status line for the first screen - #4601
Conversation
A cold Expo bundle shows only "Bundling 91%…" over the root, and two reads 200 ms apart agree on it, so open returned the banner as the first screen. The first screen now needs a labeled element that is not text, or two different texts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 3 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
The code at 1122461 looks ready to me, and I found no problems that need a change. The live cold-Expo before and after runs in the PR description reach the changed route (cold Metro, open --relaunch --foreground, first capture). There are no conflicts. The Android Smoke Tests job failed on "persistent helper snapshot should expose fixture dialog"; that looks unrelated, because |
Apex Sentinel · ✅ Approve1 finding(s): 1 minor. 🟡 Minor (1)
1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 1122461. The verdict and the full list are in the summary comment.
Summary
On a cold Expo bundle, the first capture after
openon a local iOS simulator returned Expo's progress banner as the app's first screen. The tree was the app root plus oneStaticText"Bundling 91%…". Two reads 200 ms apart agreed on it, so the #4513 rule (any labeled non-root element) accepted it.The first screen now needs a labeled element that is not text, such as a button, or two different texts. A busy indicator still doesn't count. React Native mirrors a text into two nodes with the same label, so texts are counted by label, not by node.
A first screen made of a single line of text and nothing else now waits the full 10 s and returns
loading. #4599 adds the opt-out for that case.3 files: the rule, two tests (lone status line, two texts), and the docs.
Validation
At 1122461:
pnpm typecheckandpnpm lintpass.expo start --dev-client --clear) was restarted before each cold run.open --relaunch --foregroundreturned 2 nodes,Bundling 91%…, in 7.5 s. A second cold run returnedBundling 94%….postGestureOutcome. The warm relaunch is unchanged: 52 nodes in 6.8 s.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.