Repository navigation
fix(ios): refuse a press whose target is not hittable - #4596
Conversation
A press on a control the platform reports not hittable now refuses before dispatch with target_not_hittable instead of tapping the row beside it. Only a touch control nested in a larger touch control pays for the lean runner read. Refs #4568
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 20 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed) No open findings. 1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/command-runtime/src/commands/interaction/runtime/pre-dispatch-admission.ts:231 |
Unhittability gate ignores the Maestro non-hittable fallback on the runtime click path |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (cfe08502f0f6).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 10e38f8. The verdict and the full list are in the summary comment.
- Add the hittability-probe request to runner-requests.json with its producer drive. - Thread the admission read signal into the native probe read. - Skip the probe for the Maestro replay non-hittable fallback. - Cover the cancellation reason, the Maestro skip and the overlap fixture. - Correct the admission comment and the Maestro wording in the docs.
|
Follow-up pushed: CI failure: Review threads (9, all replied and resolved):
Validation at |
|
This PR is ready: I found no problems in the code at 8b1b21a. The checks are green (21 checks, 0 failing), and the earlier runner-request failure is fixed by the new fixture entry and its producer drive. There are no conflicts. Not blocking, and you can take or leave these: On evidence: the device results (closed Delete refused, revealed Delete pressed at 8b1b21a, ungated presses checked at 10e38f8) are your report, and I had no log or recording to inspect. One open question: does The review threads: the threads on cancellation test, signal threading, commands.md wording and the Maestro flag (thread) are fixed at this head, and the lower-priority threads on the fixture button position and module comment are fixed too. These no longer apply, so please resolve them. The idle press probe thread is benign because the read already covers nested controls. The fresh snapshot hint thread is benign because the hint already says to take a new snapshot. The message vs typed reason thread is benign because callers branch on the typed reason. Please resolve those three as well. Nothing blocks merge. |
Summary
On iOS,
press/clickon a closed swipe action (RNReanimatedSwipeable) reported success but tapped the row beside it: snapshothittableis geometric only. A press now refuses before dispatch withtarget_not_hittable,dispatched: no.isNestedTouchControlselects touch controls inside a larger touch control (the swipe-action shape). Other presses pay nothing.querySelectorwithhittabilityProbe: counts every match, readsisHittableand frame of a single one).notHittablerefuses.unknown(no selector, ambiguous, frame not the target's, read failure) proceeds as before.probeTargetHittabilitybackend sibling of the offscreen probe, called inadmitResolvedTargetbefore the motion check. iOS only; snapshot output and latency are unchanged. NocoveredByis claimed.20 files. Refs #4568 (iOS part).
Before:
press @e15on closedDelete Avocado→Tapped @e15 (338, 467), row toggled ("2 items still to buy").After:
Row unchanged. After the row is swiped open, the same press deletes it.
Validation
Tested head
10e38f8da8, basecfe08502f0.pnpm check:affected --run --head HEAD: 25 checks passed (receiptrun-ezpc0k). NativeRunnerTestsprobe and selector tests ran withINCLUDE_UNIT_TESTS=1: 2/2 passed. CI owns coverage and device lanes.Device (iOS 26.2 sim, Pantry RN app): closed Delete refused, open Delete pressed; the 22x22 Recipes "Save" button is not nested, so it is ungated and unchanged.
Press latency, ms (base → head):
Not covered: native UITableView swipe actions (no fixture), Android.