Repository navigation
fix(ios): establish the screen origin of a full-screen private AX root - #4573
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 7 files
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
I found no code defects in 8cf07fa, but the change is not ready to merge until two live runs exist. The CI failure is in the Coverage job, which runs the TypeScript suites; this diff touches only Swift/ObjC runner sources, the runner README, ADR 0004 and a changeset, so it looks unrelated. There are no conflicts. The change turns a refusal into dispatch on the private-AX fallback route for every app the probe calls full-screen, and the two states that decide whether that is safe have not been run live. Please run head 8cf07fa with the XCTest channel penalty (same recipe as the iPhone repro) for two cases. First, the #4399 iPad fixture with the placed window should give window-origin-unknown with dispatched: no, no viewport reported, and a Windowed probe result in the runner log. An iPad app in full screen should also get viewport = screen and its taps should land. Second, the iPhone repro rotated to landscape should give either a refusal or a tap whose native counter advances and whose dispatched point equals the control center. ADR 0004 says AXRuntime reports in one native space, so in landscape the private-AX root and the system-app frame may both be the native portrait box. The equality would then pass and the root would become .reported with orientation unknown, and Not blocking, and you can take or leave these: the last sentence of the paragraph at apple/runner/README.md:138 still says "without a new probe" right after the paragraph that adds one, so it could say the probe adds no XCTest tree read and no change to the channel budget. The unit test at RunnerTests+AXSnapshotFallbackTests.swift:8 only exercises The open README thread (#4573 (comment)) still applies. The exact-equality thread (#4573 (comment)) does not apply: exact equality fails closed back to the old refusal and never widens acceptance, and it matches the #4514 rule, while the 0.5pt tolerance already covers the fill-the-screen proof in RunnerXCTestEventBridge.m:373, so you can resolve it. Before merge, please post the iPad placed-window and iPhone landscape runs for 8cf07fa, then fix the README sentence. |
|
iPhone landscape at
The private-AX root is in interface space and AXRuntime's screen frame is native portrait, so in landscape the equality fails and the capture stays Also pushed:
The iPad placed-window and iPad full-screen runs are still to come. This machine has no iPad simulator yet; I'll post them here. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
iPad runs at
The placed window was made by dragging the window's resize handle. Its private-AX root is window-local, and the probe returned no full-screen frame, so the capture stays
Together with the iPhone runs above: iPhone portrait and iPad full screen tap at the control center, while iPhone landscape (both directions) and the iPad placed window keep the typed refusal. |
2bd2643 to
d228f57
Compare
|
I found no code problems at 586d58a, and the required live evidence is now in place. Since the earlier review at 8cf07fa, the evidence gap is closed by your posted iPhone and iPad runs at 2bd2643, which match this head except for the log-only The three review threads need no further code change. Please resolve #4573 (comment) ( Not blocking: the posted runs do not cover iPad landscape or portraitUpsideDown full-screen. Upside-down becomes |
|
Thanks. All three threads were already resolved. On the two non-blocking notes:
|
* origin/main: fix(alert): derive the request envelope from an alert wait window (#4581) fix(android): require a nonzero chunk before a recorder counts as ready (#4559) chore(deps): clear astro and node-forge security alerts (#4577) fix(ios): establish the screen origin of a full-screen private AX root (#4573) docs(agents): trace behavior claims during review (#4576) fix(mcp): trim the press plan text back under the always-loaded byte budget (#4572) refactor(alert): one helper owns the alert runner budget (#4563) feat(interaction): multi-ref press plan lowered through the ordinary press lane (#4296) fix(ios): use the caller's budget for alert get and type the watchdog outcome (#4540) feat(recovery): bound remote health and runner-busy recovery by the command's deadline (#4541) fix(ios): find the navigation bar back button outside the bar's subtree (#4542) feat(open): report device kind, model and osVersion on open and session identity (#4543) fix(apple): use typed screenshot timeouts and observed shutdown recovery (#4544) feat(device-status): report per device whether a new session can take it (#4547) fix(runner): type the refusals for a control the target cannot supply (#4548) refactor(transport): share outgoing transfer phase ownership (#4551) fix(remote): bound artifact preparation and upload phases (#4552)
Summary
Since 0.21.37 (#4439), iOS simulator
press @refon a full-screen app fails withwindow-origin-unknownwhile the XCTest snapshot channel is penalized, e.g. right after aWKWebViewloads a large page. The private AX fallback then declares its rootderived, although on an iPhone that root is the screen at the origin (0,0,440,956). The refusal held for over 150 s.privateAXSnapshotViewportnow asks AXRuntime whether the target is the primary app filling the screen (the probeRunnerResolveSoleScreenuses; it walks no tree). A root exactly equal to that screen frame at the origin isreported. A placed iPad window (#4399), an offset root, or a swapped landscape root staysderived. Runner-side counterpart of #4514.7 files: runner Swift/ObjC, a runner unit test, runner README, ADR 0004, changeset.
Validation
Head
586d58a76on main189570486. Live runs: base26a8a1b30against head8cf07fa/2bd2643, which have the same runner code apart from a log line, iPhone 17 Pro Max simulator, iOS 26.5, gronxb/e2e-repro: reload the web view,snapshot -i,press @e2, four rounds.window-origin-unknown, no viewportTaps: 1Taps: 4(3/3 runs)The head runner logged
PRIVATE_AX_SNAPSHOT_USEDandCHANNEL_PENALIZED. e2e'slocator.tapsuite passes 2/2 on head.testPrivateAXRootViewportReportsOnlyAFullScreenRootAtTheOriginpasses on the simulator. The iOS, macOS, and tvOS runner builds succeed.check:xctest-selectionpassed.check:affected --run --head 586d58a76: passed, exactCommit. All 16 CI checks pass at586d58a.