Repository navigation
refactor(alert): one helper owns the alert runner budget - #4563
Conversation
Follow-up to #4540 review notes: alertRunnerBudgetMs owns the default, floor and ceiling; alertWaitTimeoutMs becomes alertTimeoutMs since it also feeds alert get; drop the hand-built watchdog test that only pinned existing behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
No issues found across 3 files
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Apex Sentinel · ✅ ApproveNo open findings. 1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
|
This PR is ready: I found no correctness problems at 11e3ab1, and all 20 checks pass with no open review threads. There are no conflicts. Nothing else needs to happen before merge. The runner-visible budgets are unchanged for every finite input, and the unit table test pins them at the runner client boundary. Not blocking, and you can take or leave these: |
Applies the non-blocking review notes on #4540 (#4540 (comment)). No behaviour change.
alertRunnerBudgetMsinpackages/platform-apple/src/alert.tsnow owns the default (10 s), the read floor (1.5 s) and the 25 s ceiling. Before, they were split betweenreadAppleAlertandrunAppleAlert. Every budget the runner receives is the same as before.alertWaitTimeoutMsinsnapshot-alert.tsis renamed toalertTimeoutMs, and its doc now says it also sets thealert getbudget.alert.test.tsis removed. It only re-checked existing behaviour that other tests already cover.Not taken: the optional live
alert wait 30000run on a simulator. The wait path is unchanged here.Validation: vitest on
alert.test.tsand the daemon execution handlers (101 tests) passes; typecheck, oxlint and oxfmt are clean. CI owns the rest.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.