Repository navigation
build(maestro): prepare the private v2 factory and packed contracts #4555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
775987e
47d37d0
e6f6d4a
1f7b223
f907aa4
61d027b
41d11fe
0081f61
feb7c25
4110157
b057f87
38e1542
c3b5411
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| 'agent-device': minor | ||
| --- | ||
|
|
||
| Require explicit SDK host dependencies in 0.22. Part of #3759 section 3. | ||
|
|
||
| Pass `{ env, cwd }` to `runAndroidShell(device, words, host, options?)`, `runAndroidExecOut(device, words, host, options?)`, `resolveAndroidArchivePackageName(archivePath, host, signal?)`, `prepareMetroRuntime(options, host)`, and `new LimrunRuntime(options, host)`. For example, capture `const host = { env: { ...process.env }, cwd: process.cwd() }` in your entry point, then call `await prepareMetroRuntime(options, host)`. | ||
|
|
||
| `resolveRemoteConfigProfile({ configPath, cwd, env })` requires `env`, and `createLocalArtifactAdapter({ cwd })` requires `cwd`. Archive inspection resolves relative paths from the supplied host and no longer shares a cached SDK tool across hosts. The internal contracts, host-kit, remote, and platform-android packages are bundled into `agent-device`; this changeset covers their affected public APIs. | ||
|
|
||
| Executable captures and `startAgentDevice`'s optional-host capture remain available. See [Build an integration](/docs/build-an-integration#migrate-sdk-hosts-to-022) for migration examples. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| 'agent-device': minor | ||
| '@agent-device/testmu': minor | ||
| '@agent-device/revyl': minor | ||
| --- | ||
|
|
||
| Remove the version 1 provider plugin contract. A store package is now discovered only through its exports: `./agent-device`, or the package root when that subpath is absent. The host no longer reads an `agentDevicePlugin` manifest to choose an entry or to declare a provider, connection capabilities, or credential variables, and `agent-device plugins add` no longer refuses a package for a provider another manifest claims — the registry settles a duplicate provider id when the daemon next composes its plugins, as the first claim wins. | ||
|
|
||
| Migrate a plugin by exporting its factory from `./agent-device` and returning the manifest's values from the factory: `provider`, `credentials: { variables: [...] }`, an optional `connection`, and `setup(host)` that returns `{ runtime, platformModule }` or `{ webDriver }`, with `apiVersion: 2`. See [Provider plugins](/docs/plugins) for the full migration. A plugin object with an `apiVersion` other than 2 is listed as `failed` with `incompatible_plugin`, and a default export that is not a plugin factory with `invalid_plugin`; the daemon starts without either. |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||||||
| { | ||||||||||
| "name": "agent-device", | ||||||||||
| "version": "0.21.38-dev", | ||||||||||
| "version": "0.22.0-dev", | ||||||||||
| "description": "Open source device layer for AI coding agents: a CLI, MCP server, and typed Node.js API to control mobile, web, TV, and desktop apps on devices and simulators, locally or in the cloud.", | ||||||||||
| "mcpName": "io.github.callstack/agent-device", | ||||||||||
| "license": "MIT", | ||||||||||
|
|
@@ -165,7 +165,7 @@ | |||||||||
| "depgraph:test": "node --experimental-strip-types scripts/node-test-tmpdir.ts --experimental-strip-types --test scripts/depgraph/model.test.ts scripts/depgraph/entries.test.ts scripts/depgraph/import-graph.test.ts scripts/depgraph/affected.test.ts scripts/depgraph/structure-summary.test.ts tools/depgraph-view/*.test.mjs", | ||||||||||
| "check:production-exports": "fallow dead-code --config fallow-production-exports.json --production --unused-exports --fail-on-issues", | ||||||||||
| "check:bundle-owner-files": "node --experimental-strip-types scripts/check-bundle-owner-files.ts", | ||||||||||
| "check:package": "node --experimental-strip-types scripts/check-package.ts", | ||||||||||
| "check:package": "node --experimental-strip-types scripts/check-package.ts && node --experimental-strip-types scripts/node-test-tmpdir.ts --test packages/maestro/test/package-artifact.test.mjs", | ||||||||||
|
Check failure on line 168 in package.json
|
||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Appending Prompt for AI agents
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted; this duplicates the routing issue tracked in #4555 (comment). The local root-9f PREP retains artifact tests first and scripts/check-package.ts last, so forwarded --pack-destination reaches its owner. Current repair candidate is e018cbe6993cd7d522962f68e3ce0ad0a5ca91d1. The published c3b5411 head is unchanged; Node22.13 packaging and predecessor ENV-protocol disposition still block publication. Keeping this open until the fix is published.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Prompt for AI agents
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted for the supported Node22.13-22.17 development range. This duplicates #4555 (comment). The local PREP script explicitly forwards --experimental-strip-types after node-test-tmpdir.ts, preserves the artifact test, and leaves the core package probe last for forwarded release arguments. This is retained at e018cbe6993cd7d522962f68e3ce0ad0a5ca91d1. Node26 passes do not clear the separate Node22.13 nested-packaging blocker; leaving this open until admitted publication. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🆕 🟡 Minor · New package-artifact test's .ts host-kit import lacks forwarded --experimental-strip-types
Suggested change
Detailspersona: Useful? Reply Reply
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted after rechecking the supported development floor. My earlier dismissal based only on Node 22.12 being outside the repository's Node >=22.13 development contract was incomplete: Node 22.13–22.17 still requires the child flag. Type stripping became enabled by default in Node 22.18; the 22.13 documentation specifies The local correction at PREP 15036137c69b9601d933bb50fba24e089aa53e35 explicitly forwards that flag after There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🆕 🟠 Major · check:package's new && suffix swallows release:prepare's --pack-destination flag
Suggested change Keep Detailspersona: Useful? Reply Reply
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accepted. The appended release arguments reach the final command in the script, so the current order deprives A local correction at PREP 15036137c69b9601d933bb50fba24e089aa53e35 runs the artifact tests first and keeps the core package probe last. This preserves the existing package gate and its forwarded arguments without adding a wrapper or removing tests. All consumer/TOP test-file suffixes are retained in the restacked local family, ending at 3c7f1cc9fa9ce359df63da6ba5d1a34a3e55287d. A standalone argument-routing probe using pinned pnpm 11.17.0 and the actual PREP/TOP script strings confirms old routing fails the ownership condition and corrected routing passes. Both raw pnpm commands exit 0 because the fixture only records argv; this is not an actual release, retained-tarball test or canonical-gate pass. Actual package-destination verification, independent source review and new-head validation remain owed. Keeping this thread open until the correction is admitted and published. No release/publish/CI rerun was triggered. |
||||||||||
| "check:command-docs": "vitest run --project unit-core test/repo-guards/command-doc-coverage.test.ts", | ||||||||||
| "check:adr-citations": "vitest run --project unit-core test/repo-guards/adr-citations.test.ts", | ||||||||||
| "check:capabilities-matrix": "vitest run --project unit-core test/repo-guards/capability-matrix.test.ts", | ||||||||||
|
|
||||||||||
Uh oh!
There was an error while loading. Please reload this page.