Repository navigation
feat(open): report device kind, model and osVersion on open and session identity - #4543
Conversation
…on identity A CI integration that rents a device records what OS a capture ran on from the command result alone, so `open --json` and `session list --json` now carry the same device description `devices` already reports. `open` adds `model` and `osVersion` beside the `kind` it already echoed, and `session list` adds all three to each session's device. The daemon carries the value its discovery read (simctl, adb, or devicectl) or the value the provider's create-session answer granted, never the one the request asked for. A target that reports nothing omits the field rather than naming an OS it did not read, so a caller can tell a read version from silence. The WebDriver provider now reads the granted OS from the hub's returned capabilities (W3C `platformVersion` or its `appium:` variant) instead of reporting none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 15 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…her platformVersion key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. 1 new finding away from what changed since 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
|
The docs promise a JSON shape that Not blocking, and fine to take or leave: the daemon now has two copies of the model/osVersion spread ( The code looks right at d312ff5 apart from that docs fix. I did not run Of the earlier review threads, both are fixed at this head and can be resolved: the client-api.md optional device fields wording now matches the optional type, and the platformVersion capability read now scans both keys. |
"Each session's device carries kind, model and osVersion" read as a nested object, but the CLI's session entry has `device` as the device name and the three fields beside it. A caller that followed the sentence read `sessions[0].device.osVersion` and got null. Name the flat shape and where the SDK reports the same fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fixed in 6cc4f65. commands.md:1217 now says each session entry carries Revalidated the pushed head, which covers the On the non-blocking notes:
I did not run the CLI against a device either, so the flat shape above is read from the serializers and the docs prose checks, not from a live |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
The sentence read as every entry carrying kind, model and osVersion. A target that reports no OS omits osVersion, so a reader would have taken the expected omission for a broken CLI. Say each field is reported when the host reported it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Also took the last open thread: the session-list sentence now names the fields as reported only when the host reported them, so an omitted |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Took the provider-scenario note in 86e63d7. The cloud WebDriver scenario now also asserts that The |
|
I reviewed 86e63d7 and found no remaining problems in the code. The three issues from the earlier review (#4543 (comment)) are fixed: the session-list docs now describe the flat kind, model and osVersion shape, the client docs no longer claim All 22 CI checks pass, and the last change only touches a docs file and an integration test assertion, so no runtime route changed. I did not run the provider-integration scenario or any test locally. The PR body says real simctl and adb values reaching the new fields are not verified on a live device. That is acceptable here, because the values are the same inventory ones The three open inline threads from the earlier review are fixed at this head, so you can resolve them: #4543 (comment), #4543 (comment) and #4543 (comment). Nothing else needs to happen before merge. |
Summary
Closes #4525
A CI integration that rents a device records what OS a capture ran on from the command result alone.
open --jsonnow reportsmodelandosVersionbeside thekindit already echoed, and eachsession list --jsonentry adds all three — the same descriptiondevicesalready reports. 15 files.The daemon carries what its discovery read (
simctl,adb,devicectl) or what the provider's create-session answer granted, never what the request asked for. A target that reports nothing omits the field, so a caller can tell a read OS from silence; nothing infers one.Scope expansion: the session projection gained
kind(the issue's example output shows it, and the session view lacked it), and the WebDriver provider now reads the granted OS from the hub's returned capabilities (platformVersionor itsappium:variant) instead of reporting none. Revyl and Limrun are unchanged: their APIs report no granted OS toDeviceInfo.The added fields are optional response fields outside the digested wire surface, so no protocol bump and no ledger change; the wire-compat lane passes unchanged.
Validation
Tested SHA
6cc4f6539f(based78be6c887), which covers thereadCapabilitychange made after the first receipt. Head07abb8489fadds a docs-only rewording of the session-list fields, checked bycheck:doc-proseand command-doc coverage.vitest run --project unit-core— 2019 files, 18826 passed, 10 skipped (at6fc227f)vitest run --project provider-integration— 289 passed; the BrowserStack-shaped scenario asserts granted OS17.2against a request for18vitest run --project unit-core test/wire-compat packages/client packages/command-output packages/daemon/src/sessions packages/provider-webdriver src/commands/schema— 2168 passed,ledger.jsonunchangedvitest run --project output-economy --project interaction-contract— 131 passedpnpm typecheck,pnpm lint,pnpm format,pnpm check:doc-prose,check:command-docs, client-api doc snippets — clean6cc4f6539f: all lanes passed, including Smoke Tests (ios and macos), Coverage, Integration Tests and Repo GuardsCI obligations: full CI on the pushed head. Unresolved risk: no live-device run verified real
simctl/adbvalues reach the new fields; the values are the same inventory onesdevicesalready ships.🤖 Generated with Claude Code