Skip to content

test(maestro): prepare export and suite coverage for plugin extraction - #4528

Merged
thymikee merged 3 commits into
0.22from
t3/maestro-export-tests-prep
Nov 13, 2026
Merged

thymikee merged 3 commits into
0.22from
t3/maestro-export-tests-prep

Conversation

@thymikee

@thymikee thymikee commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Prepare existing export and suite-forwarding coverage for #4505 / #3377. Four test files, 694 gross lines; no production, dependency, or baseline edits.

Retain engine assertions beside their owner and four CLI export cases. Isolate suite forwarding from the network reporter. Restore the suite's temporary cwd so checkout project configuration cannot affect it. This layer works before optional plugin installation.

Validation

Head: 649a9a45ef938390f1b8fae7467ce5452758a0ae; integration base: e29ed5d0ac2ba957188cb9607b9249fb55463f6c; previous reviewed head: 068555737f59177502937c8454e84255628172b5.

Independent review found one cwd-isolation issue. The supplied json=true example did not fail locally. A rejecting checkout configuration did fail the existing assertion before the cwd fix and passed afterward; both temporary configurations were removed. After rebasing onto C5's integrated changes, all 35 retained tests and full-repository format pass. Frozen install/build passed.

Range-diff preserves the two preparation commits and adds the one-line cwd fix. Independent source recheck approved this head. Hosted checks passed. Serialized affected validation passed at this head: 42 checks, 25 owner-declared skips, exactCommit=true, checkoutChanged=false (run-wg7wrQ); 19,751 unit, 419 related and 288 provider tests passed. Earlier head's green checks are not new-head evidence. No device-facing or publishing change.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.25 MB 6.25 MB -18 B
Package (unpacked) 6.25 MB 6.25 MB -18 B
Package (download) 1.90 MB 1.90 MB -4 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 35.9 ms 57.8 ms +21.9 ms
CLI --help 56.6 ms 128.6 ms +72.0 ms

@thymikee
thymikee force-pushed the t3/maestro-export-tests-prep branch from 0685557 to 649a9a4 Compare November 13, 2026 22:12
@thymikee
thymikee marked this pull request as ready for review November 13, 2026 22:29
@thymikee
thymikee merged commit e401de8 into 0.22 Nov 13, 2026
17 of 18 checks passed
@thymikee
thymikee deleted the t3/maestro-export-tests-prep branch November 13, 2026 22:29
thymikee added a commit that referenced this pull request Nov 14, 2026
#4528)

* test(maestro): colocate engine export tests before extraction

* test(cli): isolate Maestro suite forwarding from network reporting

* test(cli): restore isolated cwd for Maestro suite forwarding
thymikee added a commit that referenced this pull request Nov 15, 2026
#4528)

* test(maestro): colocate engine export tests before extraction

* test(cli): isolate Maestro suite forwarding from network reporting

* test(cli): restore isolated cwd for Maestro suite forwarding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant