Repository navigation
test(maestro): prepare export and suite coverage for plugin extraction - #4528
Merged
Merged
Conversation
Contributor
Size Report
Startup median (7 runs, lower is better):
|
thymikee
force-pushed
the
t3/maestro-export-tests-prep
branch
from
November 13, 2026 22:12
0685557 to
649a9a4
Compare
thymikee
marked this pull request as ready for review
November 13, 2026 22:29
thymikee
added a commit
that referenced
this pull request
Nov 14, 2026
#4528) * test(maestro): colocate engine export tests before extraction * test(cli): isolate Maestro suite forwarding from network reporting * test(cli): restore isolated cwd for Maestro suite forwarding
thymikee
added a commit
that referenced
this pull request
Nov 15, 2026
#4528) * test(maestro): colocate engine export tests before extraction * test(cli): isolate Maestro suite forwarding from network reporting * test(cli): restore isolated cwd for Maestro suite forwarding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare existing export and suite-forwarding coverage for #4505 / #3377. Four test files, 694 gross lines; no production, dependency, or baseline edits.
Retain engine assertions beside their owner and four CLI export cases. Isolate suite forwarding from the network reporter. Restore the suite's temporary cwd so checkout project configuration cannot affect it. This layer works before optional plugin installation.
Validation
Head:
649a9a45ef938390f1b8fae7467ce5452758a0ae; integration base:e29ed5d0ac2ba957188cb9607b9249fb55463f6c; previous reviewed head:068555737f59177502937c8454e84255628172b5.Independent review found one cwd-isolation issue. The supplied json=true example did not fail locally. A rejecting checkout configuration did fail the existing assertion before the cwd fix and passed afterward; both temporary configurations were removed. After rebasing onto C5's integrated changes, all 35 retained tests and full-repository format pass. Frozen install/build passed.
Range-diff preserves the two preparation commits and adds the one-line cwd fix. Independent source recheck approved this head. Hosted checks passed. Serialized affected validation passed at this head: 42 checks, 25 owner-declared skips, exactCommit=true, checkoutChanged=false (run-wg7wrQ); 19,751 unit, 419 related and 288 provider tests passed. Earlier head's green checks are not new-head evidence. No device-facing or publishing change.