Repository navigation
Conversation
|
Reviewed 79ff421. Remote script publication can lose a recording when the caller's target file already exists, and the proxy help and docs still say remote publication is refused. When The proxy command help still says remote requests refuse script publication (command-overrides.ts:163), and remote-proxy.md:106-112 says the same and points to a local daemon. This PR removes that refusal for Not blocking, take or leave: remote versus local publication is inferred from the client's Could remote support be a No checks have reported on this draft head. The description says |
|
Note 🤖 gpt-6.1-sol responding on behalf of bradenbiz Good point that consuming publication before a caller-file collision breaks normal recovery; 081d14b makes The docs fix and simplification also use the shared capability parser, daemon-side allocation, explicit remote delivery, and registration-owned retention while preserving local HTTP behavior. The controlled Linux CI comparison ran the tenant-upload test on both unchanged base The exact-head local gate passed its code checks but stopped at Android SDK configuration during packaging, reproduced with the same command on clean base; will you please approve the PR’s CI workflow runs so the full upstream CI can run? |
|
This PR is ready at 2be928f. It fixes the problems in the earlier review of 79ff421, and I found no remaining problems in the diff. Not blocking, and you can take or leave these: /health hand-writes No conflicts. I judged this from the diff and did not run tests or a live remote proxy run. Upstream CI has not reported on 2be928f yet. You report The PR is still a draft. Please mark it ready for review when you consider it done, so the upstream checks can run. |
There was a problem hiding this comment.
All reported issues were addressed across 43 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
|
Pushed e60f95f to fix the Coverage failures, using maintainer edits:
|
|
@bradenbiz I pushed 2c6bbe0 to reshape this PR. Your use case keeps working through default behavior, with no new command or flag:
Local sessions behave exactly as before. ADR 0016 and the docs are updated. Please check that this covers your flow. |
There was a problem hiding this comment.
All reported issues were addressed across 45 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Requires human review: Auto-approval blocked because this review re-detected 3 unresolved issues already reported by Cubic.
View guided diff | Re-trigger cubic
|
Hardened remote script delivery in 70e9f8b..14ca828:
New tests cover the unsolicited, changed-destination and joining-client cases, reversed completion (action vs action and action vs close), a routed daemon write failure, and a client refresh-download failure that runs exactly one device action and keeps its dispatch disclosure. |
There was a problem hiding this comment.
All reported issues were addressed across 20 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
View guided diff | Re-trigger cubic
|
Updated in 4f0e163:
ADR 0016, the remote-proxy and replay docs, and the wire ledger are updated. |
There was a problem hiding this comment.
All reported issues were addressed across 14 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
View guided diff | Re-trigger cubic
|
Pushed
ADR 0016 and the PR body are updated. |
There was a problem hiding this comment.
All reported issues were addressed across 13 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Pushed
|
There was a problem hiding this comment.
All reported issues were addressed across 23 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
View guided diff | Re-trigger cubic
|
Pushed
|
There was a problem hiding this comment.
All reported issues were addressed across 20 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
6d6a428 to
a06b7ab
Compare
|
Redesign round: a remote open --save-script now uses a client-minted publication ID recorded before the open is sent, in place of claims, binding and tombstones. The destination-folder policy is removed (local semantics), daemon script versions are written 0600 in a 0700 directory, and the remote script code loads lazily, so the eager closure does not grow. Both download leaks are fixed. A follow-up keeps an armed recording when only its first download fails, reclaims interrupted staging, and drops script artifacts under other fields. Production change is about 1,050 lines, down from about 1,500. |
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
This PR is ready at 6e9e016. The redesigned recording delivery looks correct, and the fixes since the earlier review (2be928f, #4511 (comment)) hold: force comes only from the client's own record, a bare --save-script cannot overwrite, close takes the final version from the close-time write, and a lost open answer or failed first save keeps the record. CI is green at this commit (16 checks, none failing) and there are no conflicts. Nothing else must happen before merge. Not blocking, and you can take or leave these: (1) a client-side download or save failure for a script version, in https://github.com/callstack/agent-device/blob/6e9e016/packages/remote/src/session-script-destination.ts#L205, throws out of materializeRemoteArtifacts, so an action that succeeded on the device reaches the caller as a failure, while the same failure on the daemon side keeps success and adds scriptDeliveryFailure. A script delivery failure should never change the outcome of the action that recorded it, so converting the client-side error into the same scriptDeliveryFailure plus warning in SessionScriptDelivery.publish (and updating the remote-proxy.md sentence) would match the daemon side. (2) sendRemoteScriptOpen at https://github.com/callstack/agent-device/blob/6e9e016/packages/remote/src/session-script-destination.ts#L83 decides whether a recording is armed by matching two client reasons, but the record is inert and the weekly sweep collects it, so removing it only when the daemon answered without naming the id would let you drop that reason list. The open inline threads from the earlier round are arbitrated: all of them are fixed at this commit or no longer apply, so you can resolve them. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A record that a publish refreshed after the age check is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a script version A client-side download or save failure for a script version now returns the same scriptDeliveryFailure and warning as a daemon-side one, so it never changes the outcome of the action that recorded it. A failed open keeps its inert record, and only a daemon answer that does not name the publication ID removes it, so the save-failure reason list goes away. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6e9e016 to
80eacfa
Compare
|
Rebased onto main 89485f9 as 80eacfa. The conflicts were in the remote health probe and its retry, where main moved the health cache and recovery; the capabilities assignment now sits after the new recovery path. The non-blocking notes are applied: a download or save failure on this machine keeps the action's success and returns the same scriptDeliveryFailure and warning as a daemon-side failure, and a failed open keeps its inert record, so only a daemon answer that does not name the publication ID removes it. Docs and ADR 0016 follow. |
…tries A close whose record cannot be retired keeps its outcome; the inert record is swept later. A retry after the remote daemon instance changed checks the script-artifacts capability again before it resends a remote recording. The save-failure hint no longer promises an unchanged file, and a close names that no later version follows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Follow-up at c54d00a: a close whose record cannot be retired keeps its success (the inert record is swept later), a retry after the remote daemon instance changes checks the script-artifacts capability again before resending a remote recording, and the save-failure hint no longer promises an unchanged file. |
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
…rite Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A digest response view narrows a command's own result but now keeps scriptPublicationId and scriptDeliveryFailure, so a snapshot or screenshot at responseLevel digest still reports a failed script delivery. The client record lists each staging directory before a download writes to it, so retiring or sweeping the record removes the staging a crashed download left behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Follow-up at 95bfc9a: a digest response view (snapshot, screenshot, and the other leveled commands) now keeps scriptPublicationId and scriptDeliveryFailure, and the client record lists each staging directory before a download writes to it, so retirement or the stale sweep removes staging a crashed download left behind. |
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
A staging directory that cannot be removed now stays listed, so retirement or the stale sweep still finds it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ate it Retiring or sweeping a record removes its listed staging directories before the record, and a private-file download requires the staging directory its caller allocated instead of recreating a retired one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
A batch delivers no script versions from its steps, so a close inside it would lose the final script. The batch is refused before any step runs with remote_script_batch_close_unsupported. ADR 0016 and the remote docs record the refusal and link the follow-ups for SDK, CLI and MCP disclosure and batch delivery (callstack#4564) and for writable ancestor directories (callstack#4565). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Following the maintainer decision: a batch whose steps would close an armed remote recording is now refused before any step runs (remote_script_batch_close_unsupported); run close on its own after the batch. SDK, CLI and MCP disclosure of scriptDeliveryFailure and batch delivery are tracked in #4564, and the writable-ancestor exposure shared with local sessions in #4565. Also in 0444b83: staging stays listed until it is removed, and a private download never recreates a retired staging directory. |
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
The refusal reads the steps as the batch runs them, so a close spelled with other case or spacing is refused too, and malformed steps get the batch's own INVALID_ARGS refusal instead of a type error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…taging Retiring or sweeping a record first writes it without the interrupted version it names, so a failed record removal never leaves it naming an inode whose anchor is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A stale record whose staging cannot be removed now stays for a later sweep, and the new open goes ahead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the update. At 12736b6 the conflict from the earlier review (#4511 (comment)) is fixed, and one docs problem remains.
Not blocking, and you can take or leave these: the only production caller in Of the open inline threads, none still apply at this head, so you can resolve all five: the 'publishes nothing' test now isolates the retirement failure (#4511 (comment)), The Coverage check fails on the MCP tool input-schema size budget. This PR changes no flag or input schema, and the same job also fails on main at 82819f8, so it looks unrelated to this change. Before merge, |
…at the first step The remote proxy and replay guides now say what each surface shows for an undelivered script version today: the daemon RPC response carries scriptDeliveryFailure and a warning, while the CLI, SDK and MCP results do not carry the failure yet and close shows no warning (callstack#4564). The batch refusal checks the normalized steps in the batch runner's first step instead of normalizing them a second time, and a session-router test covers its wiring. The client and the daemon build scriptDeliveryFailure from one ScriptDeliveryFailure contract type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Addressed the review of 12736b6 in 9e61d60: the remote proxy and replay guides now say what each surface shows for an undelivered script version (the daemon RPC response carries scriptDeliveryFailure and a warning; the CLI, SDK and MCP results do not carry the failure yet, and close shows no warning, tracked in #4564). The batch refusal now checks the normalized steps in the batch runner's first step, a session-router test covers its wiring, and the client and daemon share one ScriptDeliveryFailure type. |
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
…oxy page Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This PR is ready at 837f1a4. The docs gap from the earlier review is fixed: remote-proxy.md now states the script-artifacts /health requirement, and it matches the client and proxy resolution code. I found no new problems in the changes since 12736b6. Not blocking, and you can take or leave these: the failure in session-script-destination.ts is typed with The three review threads no longer apply at this head, so you can resolve them: the /health docs requirement is added (thread), the close check now compares the normalized steps including the ' CLOSE ' case (thread), and malformed steps now fail in The Coverage check is red on the MCP tool input-schema size budget. The same job has failed on main since 82819f8, and this PR adds no flag or input schema property, so it looks unrelated. Before merge, Coverage needs to be green again or accepted as the known main failure. |
Summary
A remote
open --save-script=<path>now works like a local one, with no new command or flag:--force.scriptDeliveryFailureand a warning. Thescript-artifactshealth capability gates older daemons.remote_script_batch_close_unsupported).Known limitations: #4564 (SDK, CLI and MCP disclosure; batch delivery) and #4565 (writable ancestor directories, shared with local sessions). Local sessions are unchanged. ADR 0016, help and docs updated.
Validation
Head
837f1a477c: typecheck, lint, Fallow, production exports, layering, doc prose, ADR citations,check:daemon-wire-compatand the eager-closure budget (no growth) passed, with daemon, daemon-client and remote unit tests and the remote provider scenarios. Each new test fails when its code is broken. No device run; CI owns the full gate.🤖 Generated with Claude Code