Repository navigation
feat(revyl): install local builds and start sessions without an app - #4496
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 17 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Thanks for this. At 6231cea I found two problems to fix before merge: the .app packer is a third copy of existing code, and the live evidence does not cover the new install-from-source and reinstall paths.
The live evidence in the PR body covers only plain Not blocking, take or leave: Four open inline threads still stand: accept a completed install without a result, revyl.md omits reinstall and install-from-source, "zipped or tarred" accepts only .zip, .tar.gz and .tgz, and connect next steps miss install. The Windows PATH thread does not apply, because no CI job here runs on Windows and packing a simulator .app is a macOS-host path, so please resolve it. Only an external review check has reported for this head. The repo CI lanes, including the Apple-runner lanes named in the PR body, have not reported yet, so I cannot attribute any CI result. I read the code and tests only. I did not run the new tests or reproduce the local gate results in the PR body. No conflicts are known. Before merge, extract the shared packer and paste the live Revyl output above. |
`connect revyl` no longer requires --provider-app. Without it, Revyl starts the device with no app, and `install` puts a local build on it: the build is uploaded to the session's storage and the worker installs it through install_async, polled with install_status until it ends. A simulator .app directory is packed as a gzip tar; a .zip, .tar.gz or .tgz (iOS) and an .apk (Android) are uploaded as they are. install-from-source uses the host's materializer and the same upload. The upload and install share one 420 s budget, inside the install command's 480 s envelope, so a slow install ends with the plugin's own error rather than a client timeout that resets the daemon holding the rented device.
…it, refuse reinstall The .app packer was a third copy of the one in remote and daemon artifact tracking. host-kit now owns it as packGzipTar, with the -- guard and an optional timeout, and all three call it. The Revyl install polls install_status with pollUntilSettled against a Deadline, accepts a completed install without a result, and streams the build to storage with its length declared instead of reading it into memory. reinstall refuses with UNSUPPORTED_OPERATION: Revyl has no uninstall, and an install over an app keeps its data. An app-less connect reports a deferred device and a missing app, so its next steps run install before open.
6231cea to
8716f86
Compare
|
This PR is ready at 8716f86. The earlier findings (#4496 (comment)) are now fixed: the shared packer, the reinstall refusal, connect next steps, and the install-from-source docs are in place, and the live Revyl output for install-from-source, reinstall and connect matches. All 19 checks pass at this commit, there are no conflicts, and nothing else must happen before merge. Not blocking, take or leave: the install budget in packages/provider-revyl/src/deployment.ts is armed twice (a Deadline and AbortSignal.timeout), both ending in the same timeout error, so deriving one from the other would drop the extra undefined return; and the reinstall refusal in packages/provider-revyl/src/platform-runtime.ts runs inside deployApp after the ref frame is expired, so a refused reinstall expires refs although nothing was deployed, which would need the deploy fact to declare reinstall unavailable so the daemon can refuse earlier. Of the earlier inline threads, four are fixed at this head and can be resolved: install completed without a result (#4496 (comment)), Revyl docs on install and reinstall (#4496 (comment)), archive extension list (#4496 (comment)), and connect showing install before open (#4496 (comment)). One does not apply and can be resolved: no CI job runs on Windows and packing a simulator .app is a macOS-host path (#4496 (comment)). Live iOS evidence at this head is the connect output only. The iOS .app install was shown live only at the earlier head with the old packer (same tar arguments plus --), and iOS install-from-source has no live run; the Android run covers the earlier ask. |
Summary
connect revylno longer requires--provider-app. Without it, the device starts with no app, andinstallputs a local build on it, so an agent can install what it just built without hosting the build first.--provider-appbehaves as before.installandinstall-from-sourcestream the build to the session's storage, then install it withinstall_async, pollinginstall_statusthrough host-kit'spollUntilSettledagainst oneDeadline. The whole install gets a 420 s budget inside the command's 480 s envelope, so a slow install fails with the plugin's error instead of a daemon reset.reinstallrefuses withUNSUPPORTED_OPERATION(unsupported-provider-mode). Revyl has no uninstall, and an install over an app keeps its data, so it cannot give the clean appreinstallpromises.revyl.mdand the capabilities table say so.An app-less
connectreports a deferred device and a missing app, the state the connect workflow answers withinstallbeforeopen.Packing a
.appdirectory has one owner now:packGzipTar(dir, { env, signal, timeoutMs?, fileName? })in a new@agent-device/host-kit/gzip-tarsubpath, returning{ archivePath, cleanup }. It passes--before the name and refuses an already-aborted signal. Remote's upload, daemon artifact tracking and Revyl all call it. Remote and the daemon load it with a function-scopedimport(), so their eager closures don't grow. Two daemon archive tests now wait fortarto start before they fire the deadline, since that import moves the start one tick later.Validation
At
8716f86f8:check:affected --run --headpassed every step throughvitest-related.unit: 20,154 passed and 2 failed. Both failures are-WerrorSwift tests, which need the iphonesimulator SDK this Mac lacks.-, cleanup after a failed or aborted pack), a completed install without a result, the streamed upload's declared length, thereinstallrefusal before any upload, and the app-less connect's next steps.Live Revyl output
From this head's build, with the plugin packed from
packages/provider-revyl. Each session was started without--provider-app, anddisconnectended each one. Local paths are shortened.connect revyl --platform ios:Then, on an Android session started by
connect revyl --platform android:The
snapshot -ioutput is trimmed to its labelled rows. The earlier head's live runs also installed a local.apk(Android) and a local.appdirectory (iOS) with plaininstall.CI obligations: the Apple-runner lanes.