Skip to content

fix(snapshot): stop iOS 27 system toolbars from covering their own controls - #4494

Merged
thymikee merged 2 commits into
mainfrom
fix/ios-toolbar-covered-check
Nov 12, 2026
Merged

thymikee merged 2 commits into
mainfrom
fix/ios-toolbar-covered-check

Conversation

@thymikee

@thymikee thymikee commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

On iOS 27 the covered check refused taps that XCTest reports hittable. The fix has three parts:

  • A toolbar inside a sibling navigation bar no longer marks a presentation boundary. It also no longer covers that bar's controls (Contacts).
  • The iOS interactive projection keeps the application root instead of collapsing it into a same-label back button or list (Settings).
  • Genuine covers keep covering. New negatives: a toolbar past the navigation bar, a menu inside it, and a bottom toolbar beneath an undimmed sheet.

5 files, including a fixture built from captured trees. Scope expansion: noise-redundancy.ts. Fixes #4491.

Validation

iPhone 18 Pro simulator, iOS 27.0:

base eec35e9622 head 766f9d07ae
Contacts press Done Covered by the toolbar "Toolbar" at (0, 62 402x812) tapped, contact saved
Settings General press About Covered by the toolbar "Toolbar" at (0, 0 402x874) tapped, About opens
find text About same refusal tapped
snapshot -i [covered] every row 0

At head, a confirmation menu still covers the row beneath it.

The new tests fail on base. Reverting any single production change fails its own test.

pnpm check:affected --run --head 766f9d07ae: passed, exactCommit=true, 43 checks. CI owns device and provider lanes. An independent review was applied.

🤖 Generated with Claude Code

…ntrols

A toolbar drawn inside a sibling navigation bar no longer marks a
presentation boundary for the toolbar-host reach, and it no longer
covers the controls of the navigation bar that holds it. The iOS
interactive projection keeps the application root instead of collapsing
it into a same-label back button or list, so full-screen toolbar
containers stay exempt. Regression fixtures come from Contacts > New
Contact and Settings > General on an iOS 27 simulator.

Fixes #4491

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Apex Sentinel could not review commit f230b0b6. No review ran, so there are no findings; this is not a verdict on the change.

Apex Sentinel hit an internal error and could not finish this review. This is a problem on Sentinel's side, not with the change; if it keeps happening, tell whoever runs Sentinel for this repository. Push a new commit or comment @apex-sentinel-staging review to try again.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.23 MB 6.23 MB +328 B
Package (unpacked) 6.23 MB 6.23 MB +328 B
Package (download) 1.89 MB 1.89 MB +41 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 37.2 ms 42.1 ms +4.9 ms
CLI --help 79.9 ms 88.1 ms +8.2 ms

@thymikee

Copy link
Copy Markdown
Member Author

@apex-sentinel-staging review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/capture-kit/src/snapshot-occlusion.ts">

<violation number="1" location="packages/capture-kit/src/snapshot-occlusion.ts:484">
P2: This exempts every toolbar-kind node contained by a target’s navigation bar, even when it is a real overlay. Restrict both exemptions to recognized passthrough hosts; otherwise covered controls can remain tappable.</violation>
</file>

<file name="packages/capture-kit/src/snapshot-occlusion-ios27-system-toolbars.test.ts">

<violation number="1" location="packages/capture-kit/src/snapshot-occlusion-ios27-system-toolbars.test.ts:51">
P3: `nodeWithLabel(nodes, 'Toolbar')` matches the first of two identically labelled toolbars, so this test mutates the passthrough toolbar only by fixture order. Select the node by its `role` (`CNPassthroughToolbar`) so the intended target is explicit.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

…past-bar case

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thymikee

Copy link
Copy Markdown
Member Author

This change looks ready at f230b0b. The code is correct as written, and the required live evidence is in the PR body.

Not blocking, and you can take or leave these: (1) add a negative case to the Contacts fixture test where a table cell sits under the passthrough toolbar and must stay covered, since a toolbar inside a navigation bar should be exempt only for targets that same bar contains; (2) run the Settings test input through the same prune and normalize steps as production before the occlusion pass; (3) enforce "the iOS presentation never suppresses the viewport root" once in the rule context instead of in two rules, after checking that no rule needs to suppress Application nodes; (4) note in the PR body that the toolbar-host rule differs from the one in #4491, citing the bottom-toolbar negative test; (5) note that the projection change reaches every iOS interactive presentation consumer (snapshot -i, press @ref, find, Maestro port observation), so later refs can shift by one when the root label matches a descendant.

Of the other review threads, #4494 (comment) does not apply: real overlays are not toolbar-kind, toolbars extending past the bar still cover, and the limit is documented in the code. #4494 (comment) is fixed at f230b0b, which now selects the toolbar by role. Please resolve both.

I did not run the tests locally, and I could not reproduce the live device run. Production code is unchanged between the run and this commit. The only failing check is an external review check that reported an internal error and ran nothing; a re-run is enough. The other 19 checks pass, and there are no conflicts.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 12, 2026
@thymikee
thymikee merged commit 9676eed into main Nov 12, 2026
19 of 20 checks passed
@thymikee
thymikee deleted the fix/ios-toolbar-covered-check branch November 12, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS 27: covered check refuses taps on system-app toolbars (Contacts sheet, Settings)

1 participant