Repository navigation
fix(snapshot): stop iOS 27 system toolbars from covering their own controls - #4494
Conversation
…ntrols A toolbar drawn inside a sibling navigation bar no longer marks a presentation boundary for the toolbar-host reach, and it no longer covers the controls of the navigation bar that holds it. The iOS interactive projection keeps the application root instead of collapsing it into a same-label back button or list, so full-screen toolbar containers stay exempt. Regression fixtures come from Contacts > New Contact and Settings > General on an iOS 27 simulator. Fixes #4491 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Apex Sentinel could not review commit Apex Sentinel hit an internal error and could not finish this review. This is a problem on Sentinel's side, not with the change; if it keeps happening, tell whoever runs Sentinel for this repository. Push a new commit or comment |
Size Report
Startup median (7 runs, lower is better):
|
|
@apex-sentinel-staging review |
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/capture-kit/src/snapshot-occlusion.ts">
<violation number="1" location="packages/capture-kit/src/snapshot-occlusion.ts:484">
P2: This exempts every toolbar-kind node contained by a target’s navigation bar, even when it is a real overlay. Restrict both exemptions to recognized passthrough hosts; otherwise covered controls can remain tappable.</violation>
</file>
<file name="packages/capture-kit/src/snapshot-occlusion-ios27-system-toolbars.test.ts">
<violation number="1" location="packages/capture-kit/src/snapshot-occlusion-ios27-system-toolbars.test.ts:51">
P3: `nodeWithLabel(nodes, 'Toolbar')` matches the first of two identically labelled toolbars, so this test mutates the passthrough toolbar only by fixture order. Select the node by its `role` (`CNPassthroughToolbar`) so the intended target is explicit.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…past-bar case Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This change looks ready at f230b0b. The code is correct as written, and the required live evidence is in the PR body. Not blocking, and you can take or leave these: (1) add a negative case to the Contacts fixture test where a table cell sits under the passthrough toolbar and must stay covered, since a toolbar inside a navigation bar should be exempt only for targets that same bar contains; (2) run the Settings test input through the same prune and normalize steps as production before the occlusion pass; (3) enforce "the iOS presentation never suppresses the viewport root" once in the rule context instead of in two rules, after checking that no rule needs to suppress Application nodes; (4) note in the PR body that the toolbar-host rule differs from the one in #4491, citing the bottom-toolbar negative test; (5) note that the projection change reaches every iOS interactive presentation consumer (snapshot -i, press @ref, find, Maestro port observation), so later refs can shift by one when the root label matches a descendant. Of the other review threads, #4494 (comment) does not apply: real overlays are not toolbar-kind, toolbars extending past the bar still cover, and the limit is documented in the code. #4494 (comment) is fixed at f230b0b, which now selects the toolbar by role. Please resolve both. I did not run the tests locally, and I could not reproduce the live device run. Production code is unchanged between the run and this commit. The only failing check is an external review check that reported an internal error and ran nothing; a re-run is enough. The other 19 checks pass, and there are no conflicts. |
Summary
On iOS 27 the covered check refused taps that XCTest reports hittable. The fix has three parts:
5 files, including a fixture built from captured trees. Scope expansion:
noise-redundancy.ts. Fixes #4491.Validation
iPhone 18 Pro simulator, iOS 27.0:
eec35e9622766f9d07aepressDoneCovered by the toolbar "Toolbar" at (0, 62 402x812)pressAboutCovered by the toolbar "Toolbar" at (0, 0 402x874)find text Aboutsnapshot -i[covered]At head, a confirmation menu still covers the row beneath it.
The new tests fail on base. Reverting any single production change fails its own test.
pnpm check:affected --run --head 766f9d07ae: passed,exactCommit=true, 43 checks. CI owns device and provider lanes. An independent review was applied.🤖 Generated with Claude Code