Repository navigation
fix(android): keep alert dialog title and message in snapshot -i - #4493
Conversation
The interactive Android projection dropped every passive text node, so an AlertDialog showed only its buttons and nothing said what OK confirms. Keep meaningful text inside an AlertController parentPanel (platform or AppCompat); other passive text stays dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
Apex SentinelVerdict: No findings. 1 finding below Reviewed with this repository's own Sentinel configuration ( Feedback goes in the review comment threads, as a reply under the inline comment of a finding: Reply Useful? Reply Comment |
|
This PR is ready: at d0fa5d1 I found no problems in the Android alert title and message inclusion change. All 22 checks pass at that commit, and the author's local unit timeouts were in release-script and fuzz-harness tests that this diff does not touch. Not blocking, and fine to take or leave: |
Summary
On Android,
snapshot -idropped every passive text node, so an AlertDialog showed only its buttons. This PR keeps meaningful text inside an AlertController*:id/parentPanel(platform, AppCompat, Material). All other passive text stays dropped. 6 files plus one captured fixture. Compose dialogs are out of scope (see issue).--settleandwait stablenow also compare dialog text, so a changing progress dialog keeps them waiting.Fixes #4481
Validation
Live, Android 15 emulator, Settings > Device name,
android-helper0.21.37-dev:At head, App info
-istill drops the "Calendar" and "App info" headers.Fixture test fails on base:
expected [ 'Back', 'Home', 'Recents', …(5) ] to include 'Device name'.pnpm check:affected --run --head d0fa5d17e1(exactCommit): format, lint, typecheck, layering, fallow, build, vitest-related passed.unitfailed: 3 timeouts at 5000 ms in release-script and fuzz-harness tests outside this diff. Host load average was about 160, and they also time out alone. Cause unproven locally. CI passed all 22 checks atd0fa5d1, includingunit, provider integration, and docs.Independent review: no blocking findings. Not applied: one shared
parentPanelliteral (the existing pattern isandroid:-only and also drives alert detection) and a named-flags object (an existing pattern, out of scope).🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.