Skip to content

fix(test-kit): reject companion exit gates and tolerate deleted sources - #4473

Merged
thymikee merged 2 commits into
mainfrom
fix/daemon-fixture-companion-gates
Nov 12, 2026
Merged

thymikee merged 2 commits into
mainfrom
fix/daemon-fixture-companion-gates

Conversation

@thymikee

@thymikee thymikee commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow up on the two late review findings in merged #4432. Three files; daemon-fixture test infrastructure only.

  • Companion launches reject exitGate, including gates carried by pre-bound values. Only the returned top-level launch exposes an exit handle to gate.
  • The repository guard reads NUL-delimited Git paths and skips missing working-tree files before reading them. Untracked fixture consumers remain checked.

Validation

Head: 8e5db839694a17f7d11d6b558fb4b2610f3940b7, based on main 59c52465.

  • Fresh frozen install/build; exact-head affected gate passed, receipt run-OHiTdY, clean unchanged checkout: eight runnable checks passed, seven CI-owned skips, no failed/unrun checks.
  • Full unit: 19,480 Vitest passed/three skipped; Node: 76 passed/six skipped. Hosted CI passes; Apex Sentinel review remains pending.
  • The companion type regression fails on the old type and passes with the fix. Runtime coverage preserves the top-level gate and joins both children. Before rebase, 39 focused tests passed; range-diff preserves both patches unchanged.
  • Unstaged deletion: old guard fails ENOENT, corrected guard passes. An invalid untracked consumer still fails the intended contract. Probes restored before validation.
  • Earlier pre-rebase gate failed a release-publish timeout; that receipt remains failed. Bounded phase comparisons passed without explaining it; diagnosis stays open in Diagnose release-publish fixture timeouts in full unit validation #4471. No timeouts or assertions weakened.
  • Cold self-review; Cubic reports no issues across the three changed files. No device-facing behavior change.

Authored with Codex.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.23 MB 6.23 MB 0 B
Package (unpacked) 6.23 MB 6.23 MB 0 B
Package (download) 1.89 MB 1.89 MB -8 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 23.8 ms 27.2 ms +3.5 ms
CLI --help 51.6 ms 52.1 ms +0.5 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel

Verdict: approve

No findings.

1 finding below minor not shown (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (b65a7f1f8d50).

Feedback goes in the review comment threads, as a reply under the inline comment of a finding:

Reply @apex-sentinel-staging note ... to add context, or @apex-sentinel-staging pivot ... if it is wrong — I will re-check the cited code.

Useful? Reply @apex-sentinel-staging like, or @apex-sentinel-staging dislike <why> if it is not.

Comment @apex-sentinel-staging review on this conversation to run a full review.

@thymikee

Copy link
Copy Markdown
Member Author

I reviewed 8e5db83 and found no problems. The type change now rejects a companion exit gate, and the fixture handles deleted sources as the PR describes. All 20 checks pass at this commit, including the unit and typecheck route that covers these test-kit files, and no conflicts were reported. I checked the old and new companion types by reading them and did not run tsc or reproduce the deleted-file ENOENT locally, so the checks and the PR's reproduction are the evidence for those two points. Nothing else needs to change before merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 12, 2026
@thymikee
thymikee merged commit 2470323 into main Nov 12, 2026
20 checks passed
@thymikee
thymikee deleted the fix/daemon-fixture-companion-gates branch November 12, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant