Repository navigation
fix(test-kit): reject companion exit gates and tolerate deleted sources - #4473
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex SentinelVerdict: No findings. 1 finding below Reviewed with this repository's own Sentinel configuration ( Feedback goes in the review comment threads, as a reply under the inline comment of a finding: Reply Useful? Reply Comment |
|
I reviewed 8e5db83 and found no problems. The type change now rejects a companion exit gate, and the fixture handles deleted sources as the PR describes. All 20 checks pass at this commit, including the unit and typecheck route that covers these test-kit files, and no conflicts were reported. I checked the old and new companion types by reading them and did not run tsc or reproduce the deleted-file ENOENT locally, so the checks and the PR's reproduction are the evidence for those two points. Nothing else needs to change before merge. |
Summary
Follow up on the two late review findings in merged #4432. Three files; daemon-fixture test infrastructure only.
exitGate, including gates carried by pre-bound values. Only the returned top-level launch exposes an exit handle to gate.Validation
Head:
8e5db839694a17f7d11d6b558fb4b2610f3940b7, based on main59c52465.run-OHiTdY, clean unchanged checkout: eight runnable checks passed, seven CI-owned skips, no failed/unrun checks.Authored with Codex.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.