Repository navigation
fix(android): recognize exited screenrecord processes - #4450
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
The code review at c228017 found a missing live validation. CI reports 16 passing checks and no nonpassing checks; I could not independently inspect the local receipt. There are no known conflicts. The mocked ADB regression does not establish that an exited, unreaped recording process stops and exports successfully through the daemon. Could you provide accessible evidence at this commit for an Android recording with its PID and start time, real /proc state Z and empty cmdline before ordinary record stop, a successful stopped response and collected playable video, no signal to the zombie, and completed native cleanup? Please include the commands, device and API level, and source and build pins. Recording stop The process disappearance thread still applies, as does one lower-priority thread. Before merge, please address or explicitly disposition the process disappearance thread and provide the live stop and collection evidence. The lower-priority thread is a nonblocking coverage note. |
|
In response to the live validation request: The missing composed native case is now covered at The built CLI performs an ordinary recording start, capturing the actual live child PID/start time in its production manifest. A pinned native parent retains that real Candidate stop returns Actual device/process identifiers are replaced by consistent generic markers in public evidence; source assertions and original private receipts preserve their equality. Both review threads are addressed in this revision. The earlier source-only transport comparisons retain their actual |
|
This PR is ready at 481db79. The findings from the earlier review (#4450 (comment)) are now fixed, and no new problems remain. Not blocking, and you can take or leave it: The two earlier review threads are fixed at this head, so please resolve them: the presence recheck after inconclusive reads (#4450 (comment)) and the PID 45 scanner test (#4450 (comment)). CI is green with 16 checks and none failing. I did not run the tests or the mutants locally. I read the live evidence from your public pages only, so the Z and empty-cmdline observation and the zero-signal counts rest on your attestation and the README. No conflicts are known. Nothing else blocks merge, but a maintainer may spot-check a composed-cli-481 RESULT.json first. |
Summary
Android
record stopcan reject a finished clip whilescreenrecordremains unreaped. This four-file fix recognizes valid zombies as exited, confirms disappearance after failed or unparseable identity reads, and keeps interrupted probes uncertain. Read current start time after command line before signalling a live writer.The daemon scenario covers running and zombie recorders. Transport coverage retains exact-path/PID-reuse guards and proves the disappearing writer candidate is actually inspected. One documentation sentence is added.
Fixes #4449.
Validation
Tested
481db79against2deb909:c228017; the writer-scan mutant fails and restored coverage passes.Commands, source/build pins, receipts and original footage. Footage shows the completed Android artifact; typed real CLI/ADB results establish subsequent host stop/collection. All failed setup attempts are retained and classified. All 16 checks at
481db79are terminal: 14 successes and two conditional skips.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.