Repository navigation
fix(ios): confirm foldable rotation from the lit panel in either simulator set (#4343) #4440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thymikee
merged 16 commits into
callstack:main
from
sittingmongoose:fix/foldable-scoped-rotation
Nov 13, 2026
+1,001
−298
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9fe6ad3
fix(ios): rotate a foldable in a scoped simulator set
sittingmongoose b35461b
fix(ios): confirm the final scoped dispatch and keep picker angles pr…
sittingmongoose 48a90b6
refactor(ios): split scoped rotation state out of the dispatch loop
sittingmongoose 4245f65
fix(ios): use the measured outer-panel picker offset on iPhone Duo
sittingmongoose 47874e0
refactor(ios): one panel-content parser and one offset step for scope…
sittingmongoose a92989b
fix(ios): a scoped rotation learns nothing from a panel that did not …
sittingmongoose 674f670
fix(ios): a scoped rotation needs one established lit panel
sittingmongoose 64b4ea6
fix(ios): a panel of unknown power blocks the established lit panel
sittingmongoose 84861b5
refactor(ios): confirm every foldable rotation from its lit panel
sittingmongoose 5f3f6f2
docs(agents): keep foldable guidance within its context budget
sittingmongoose 0b3e642
docs(ios): reconcile foldable rotation contract and fixtures
sittingmongoose ae7a602
fix(ios): keep foldable classification on the simulator set source
sittingmongoose 07ce510
fix(ios): guard Duo picker mapping and report panel read failures
sittingmongoose 28f1ac4
docs(ios): name the unreadable panel table reason in the orientation …
sittingmongoose c47ed58
fix(ios): retry transient foldable panel reads without a model guard
sittingmongoose 92e5558
docs(ios): limit the orientation tool's fold-helper route to multi-pa…
sittingmongoose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| 'agent-device': patch | ||
| --- | ||
|
|
||
| Fix foldable iPhone simulator rotation in scoped sets and confirm the lit panel in both default and scoped sets. Rotation in both sets uses the fold helper, with no CoreDevice orientation polling. An already visible target dispatches nothing. Incomplete, unknown-power and multi-lit panel tables neither confirm nor dispatch. A target the panel never shows fails with `orientation-unverified`. | ||
|
|
||
| Use the fixed iPhone Duo picker offsets measured in both sets (outer 0 degrees, inner +90 degrees), replacing runtime calibration. Inner landscape-left sends `portrait-upside-down`, mapped to the HID wire value `pud`; it remains unsupported as a user target. Delayed reads wait without resending the same picker value to the same panel. | ||
|
|
||
| Unresolved guest reads inside the settle loop neither confirm nor dispatch and are retried. An unresolved final read fails with `orientation-panel-table-unavailable`. Multi-panel classification admits rotation without a model-name guard; a new multi-panel model needs its own picker mapping. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.