Skip to content

fix(aws): evaluate the final readiness observation - #4429

Merged
thymikee merged 2 commits into
mainfrom
fix/aws-final-readiness-observation
Nov 11, 2026
Merged

thymikee merged 2 commits into
mainfrom
fix/aws-final-readiness-observation

Conversation

@thymikee

@thymikee thymikee commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Evaluate every completed AWS readiness observation before synthesizing a polling timeout. A final RUNNING result is accepted; terminal results retain their failure category, cancellation takes priority, and failed billed sessions are stopped once. Two files change; no scope expansion. Fixes #4421; part of #4368.

Validation

Head: 6f6ddff30fa4a07751e4397d29bfbf8b27117ddd; base: 3924da9474eded3d40c4abbaccc79fecae894366.

  • Eight runnable exact-head affected checks passed; exactCommit=true, checkoutChanged=false. Full unit fallback: 19,025 passed/three skipped. Related: 323 passed. Seven lanes retain their GitHub/manual owners. Receipt summary and obligations.
  • Public prepare-session suite: 11 passed. Same final tests with base production: three failed/eight passed; corrected production: 11 passed. Disposable experiment removed; reviewed source preserved.
  • Frozen install/build, full formatting and diff checks passed. Independent Luna review found no findings.
  • Fresh CI/review remain pending. No paid AWS allocation or live-device evidence is claimed; this host polling change uses deterministic client/clock evidence. No budgets, fallback, test selection, release or tags changed.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.21 MB 6.21 MB +11 B
Package (unpacked) 6.21 MB 6.21 MB +11 B
Package (download) 1.88 MB 1.88 MB +10 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.3 ms 26.6 ms +0.3 ms
CLI --help 51.7 ms 49.5 ms -2.2 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel

Verdict: approve

No findings.

Reviewed with this repository's own Sentinel configuration (3924da9474ed).

Feedback goes in the review comment threads, as a reply under the inline comment of a finding:

Reply @apex-sentinel-staging note ... to add context, or @apex-sentinel-staging pivot ... if it is wrong — I will re-check the cited code.

Useful? Reply @apex-sentinel-staging like, or @apex-sentinel-staging dislike <why> if it is not.

Comment @apex-sentinel-staging review on this conversation to run a full review.

@thymikee

Copy link
Copy Markdown
Member Author

I found no problems in 6f6ddff. The loop now evaluates the final readiness observation, and the new test fails against the old loop because its fakeClient hook runs on every get, including the initial poll. All 17 checks pass, including the unit lane that runs aws-device-farm.ts and its test, and there are no conflicts. I did not run the tests myself, I did not reproduce the exact-head runs you listed, and no live AWS Device Farm run was done. The issue does not require one for this deterministic change. Nothing else needs to happen before merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 11, 2026
@thymikee
thymikee merged commit 519565c into main Nov 11, 2026
17 checks passed
@thymikee
thymikee deleted the fix/aws-final-readiness-observation branch November 11, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate the final AWS readiness observation before timing out

1 participant