Repository navigation
fix(aws): evaluate the final readiness observation - #4429
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex SentinelVerdict: No findings. Reviewed with this repository's own Sentinel configuration ( Feedback goes in the review comment threads, as a reply under the inline comment of a finding: Reply Useful? Reply Comment |
|
I found no problems in 6f6ddff. The loop now evaluates the final readiness observation, and the new test fails against the old loop because its fakeClient hook runs on every get, including the initial poll. All 17 checks pass, including the unit lane that runs aws-device-farm.ts and its test, and there are no conflicts. I did not run the tests myself, I did not reproduce the exact-head runs you listed, and no live AWS Device Farm run was done. The issue does not require one for this deterministic change. Nothing else needs to happen before merge. |
Summary
Evaluate every completed AWS readiness observation before synthesizing a polling timeout. A final RUNNING result is accepted; terminal results retain their failure category, cancellation takes priority, and failed billed sessions are stopped once. Two files change; no scope expansion. Fixes #4421; part of #4368.
Validation
Head:
6f6ddff30fa4a07751e4397d29bfbf8b27117ddd; base:3924da9474eded3d40c4abbaccc79fecae894366.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.