Repository navigation
ci: run iOS and macOS smoke on parallel Blacksmith runners #4418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -322,19 +322,20 @@ test('device smoke lanes skip drafts and start when a draft is marked ready', () | |
| type Workflow = { | ||
| name: string; | ||
| on: { pull_request?: { types?: string[] } }; | ||
| jobs: Record<string, { name?: string; if?: string }>; | ||
| jobs: Record<string, { name?: string; if?: string; needs?: string }>; | ||
| }; | ||
| const smokeLanes = fs | ||
| .readdirSync(directory) | ||
| .map((file) => parse(fs.readFileSync(path.join(directory, file), 'utf8')) as Workflow) | ||
| .flatMap((workflow) => | ||
| Object.values(workflow.jobs) | ||
| .filter((job) => job.name === 'Smoke Tests' && workflow.on.pull_request) | ||
| .filter((job) => job.name?.startsWith('Smoke Tests') && workflow.on.pull_request) | ||
| .map((job) => ({ workflow, job })), | ||
| ); | ||
| assert.deepEqual(smokeLanes.map(({ workflow }) => workflow.name).sort(), [ | ||
| 'Android', | ||
| 'Apple', | ||
| 'Apple', | ||
| 'Linux', | ||
| ]); | ||
| for (const { workflow, job } of smokeLanes) { | ||
|
|
@@ -343,6 +344,11 @@ test('device smoke lanes skip drafts and start when a draft is marked ready', () | |
| ['opened', 'synchronize', 'reopened', 'ready_for_review', 'converted_to_draft'], | ||
| workflow.name, | ||
| ); | ||
| assert.equal(job.if, '${{ !github.event.pull_request.draft }}', workflow.name); | ||
| if (workflow.name === 'Apple' && job.name === 'Smoke Tests') { | ||
| assert.equal(job.needs, 'smoke-apple-platform'); | ||
| assert.equal(job.if, '${{ always() && !github.event.pull_request.draft }}'); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This test checks the aggregate's Prompt for AI agents |
||
| } else { | ||
| assert.equal(job.if, '${{ !github.event.pull_request.draft }}', workflow.name); | ||
| } | ||
| } | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Minor · 90-minute job ceiling leaves no room for the 80-minute phase step plus cleanup and upload
The 90-minute job ceiling leaves only ~10 minutes around an 80-minute phase timeout, so
Clean the iOS host,Require the selected Apple phases to succeed, andUpload Apple artifacts(if: always()) never execute when the phase hits its ceiling — the PR gets a bare cancellation with no diagnostics. The predecessor used 170 minutes for the same reason: the job budget must exceed the phase ceiling plus setup, cleanup, and upload.Details
Also raised here
Also raised at this location by persona
senior-developer: Apple job ceiling of 90 min no longer leaves room for setup, cleanup and uploads — An iOS phase that hangs to its own 80-minute step ceiling (line 90) after a cold toolchain install and build exceeding ~10 minutes now hits the job-level 90-minute ceiling instead: GitHub cancels the whole job, soClean the iOS host, the phase-outcome guard andUpload Apple artifactsnever run and the diagnostics that step exists to produce are lost, with the check reported as cancelled rather than a diagnosable failure. The predecessor set 170 minutes with the comment "Keep each platform's former 80-minute ceiling, plus shared setup and cleanup", and this diff keeps the unchanged 80-minute per-phase ceilings while cutting the job budget to 90, so the headroom that comment reserved for setup, cleanup and upload is gone. Splitting the platforms removed the need for 2×80 plus shared setup, but 90 is less than 80 plus the setup/build/cleanup/upload time the same runner still performs.persona:
javascript,senior-developerUseful? Reply
@apex-sentinel-staging like, or@apex-sentinel-staging dislike <why>if it is not.Reply
@apex-sentinel-staging note ...to add context, or@apex-sentinel-staging pivot ...if it is wrong — I will re-check the cited code.