Skip to content

ci: speed validation and fix daemon exit detection - #4417

Merged
thymikee merged 2 commits into
mainfrom
ci/blacksmith-linux-latency
Nov 11, 2026
Merged

thymikee merged 2 commits into
mainfrom
ci/blacksmith-linux-latency

Conversation

@thymikee

@thymikee thymikee commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Use 8-vCPU runners for Coverage and run numeric ranges independently. Also fix the daemon-exit observation race exposed by Integration Tests: a PID released during the process snapshot now proves exit on a final liveness check. Unreadable observations for live processes still fail closed. No retry or timeout changes.

Three files. Scope expanded into daemon-contracts and its regression tests to resolve the CI blocker. No linked issue.

Two successful runner/layout trials on identical sources before the retirement fix:

Completion Existing Proposed Median gain
Coverage 364 / 385s 200 / 208s 46%
Guards 277 / 279s 187 / 221s 27%

Coverage, guard controls, split guards. Requested Coverage vCPU-seconds increase about 9%; 16 vCPU costs more without improving the optimized critical path.

Validation

Tested 80dc3c3dde9ca96deec2337ec3435430dc912aba:

  • pnpm check:affected --run --head 80dc3c3dde9ca96deec2337ec3435430dc912aba: 42 passed, 25 skipped; receipt run-n7ETdM, exactCommit=true, checkoutChanged=false.
  • Same focused command against old/new implementations: 19 passed, 2 failed → 21 passed. Real-daemon cleanup integration: 3 passed. Independent review: no findings.
  • Original failure reproduced on base and old head.

CI and all reported platform checks passed at this head. Cubic found no issues; Apex approved. Its minor PID-reuse finding was rejected with contract evidence and resolved.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.21 MB 6.21 MB +11 B
Package (unpacked) 6.21 MB 6.21 MB +11 B
Package (download) 1.88 MB 1.88 MB +5 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 24.0 ms 31.8 ms +7.8 ms
CLI --help 49.8 ms 62.8 ms +13.0 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Apex Sentinel

Verdict: approve

Since the last review: 1 new · 0 still open · 0 no longer raised

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
packages/daemon-contracts/src/daemon-process.ts:80 🆕 waitForDaemonExit's new liveness re-check does not re-read identity, so it can prove exit on a reused pid

Reviewed with this repository's own Sentinel configuration (3924da9474ed).

Feedback goes in the review comment threads, as a reply under the inline comment of a finding:

Reply @apex-sentinel-staging note ... to add context, or @apex-sentinel-staging pivot ... if it is wrong — I will re-check the cited code.

Useful? Reply @apex-sentinel-staging like, or @apex-sentinel-staging dislike <why> if it is not.

Comment @apex-sentinel-staging review on this conversation to run a full review.

Earlier reviews

Review of 3f3f46d3 · 11.11.2026 10:52 UTC

Apex Sentinel

Verdict: approve

No findings.

Reviewed with this repository's own Sentinel configuration (3924da9474ed).

@thymikee
thymikee marked this pull request as draft November 11, 2026 11:02
@thymikee thymikee changed the title ci: speed coverage and run numeric ranges independently ci: speed validation and fix daemon exit detection Nov 11, 2026
@thymikee
thymikee marked this pull request as ready for review November 11, 2026 11:27

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on 80dc3c3. The verdict and the full list are in the summary comment.

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready: I found no problems in the code at 80dc3c3, and all 21 checks pass at that commit, including Coverage, Numeric Ranges and Repo Guards & Compatibility. The Integration Tests failure the PR cites was reproduced on base per the PR body, and the changed predicate sits on that route (stopDaemonProcess through waitForDaemonExit). I did not run the vitest suite locally; I checked the regression test by tracing its mock against the old predicate. I did not open the benchmark runs linked in the PR body. No device run is needed, because the change touches only daemon-contracts and CI. No conflicts are known, and nothing else blocks merge.

Not blocking: the new numeric-ranges job uses a shallow checkout where the old repo-guards job used fetch-depth: 0, so a short comment that it needs no history would help (https://github.com/callstack/agent-device/blob/80dc3c3/.github/workflows/ci.yml#L276), and the doc comment above waitForDaemonExit could name the final liveness probe that follows the snapshot (https://github.com/callstack/agent-device/blob/80dc3c3/packages/daemon-contracts/src/daemon-process.ts#L83). You can take or leave both.

The open thread on the final-probe pid reuse (#4417 (comment)) does not apply: the author replied, and the contract at daemon-process.ts:60-62 already covers pid reassignment. Please resolve it.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 11, 2026
@thymikee
thymikee merged commit 37322e9 into main Nov 11, 2026
21 checks passed
@thymikee
thymikee deleted the ci/blacksmith-linux-latency branch November 11, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant