Repository navigation
ci: speed validation and fix daemon exit detection - #4417
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex SentinelVerdict: Since the last review: 1 new · 0 still open · 0 no longer raised 1 finding(s): 1 minor. 🟡 Minor (1)
Reviewed with this repository's own Sentinel configuration ( Feedback goes in the review comment threads, as a reply under the inline comment of a finding: Reply Useful? Reply Comment Earlier reviewsReview of
|
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 80dc3c3. The verdict and the full list are in the summary comment.
|
This PR is ready: I found no problems in the code at 80dc3c3, and all 21 checks pass at that commit, including Coverage, Numeric Ranges and Repo Guards & Compatibility. The Integration Tests failure the PR cites was reproduced on base per the PR body, and the changed predicate sits on that route ( Not blocking: the new The open thread on the final-probe pid reuse (#4417 (comment)) does not apply: the author replied, and the contract at |
Summary
Use 8-vCPU runners for Coverage and run numeric ranges independently. Also fix the daemon-exit observation race exposed by Integration Tests: a PID released during the process snapshot now proves exit on a final liveness check. Unreadable observations for live processes still fail closed. No retry or timeout changes.
Three files. Scope expanded into daemon-contracts and its regression tests to resolve the CI blocker. No linked issue.
Two successful runner/layout trials on identical sources before the retirement fix:
Coverage, guard controls, split guards. Requested Coverage vCPU-seconds increase about 9%; 16 vCPU costs more without improving the optimized critical path.
Validation
Tested
80dc3c3dde9ca96deec2337ec3435430dc912aba:pnpm check:affected --run --head 80dc3c3dde9ca96deec2337ec3435430dc912aba: 42 passed, 25 skipped; receiptrun-n7ETdM,exactCommit=true,checkoutChanged=false.CI and all reported platform checks passed at this head. Cubic found no issues; Apex approved. Its minor PID-reuse finding was rejected with contract evidence and resolved.