Repository navigation
fix(capture): exempt floating chrome above bottom tabs - #4405
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex SentinelVerdict: Since the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed) No findings. Reviewed with this repository's own Sentinel configuration ( Feedback goes in the review comment threads, as a reply under the inline comment of a finding: Reply Useful? Reply Comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/capture-kit/src/snapshot-occlusion.ts:536 |
Bottom-bar exemption keys on any button-like siblings, so covering chrome is excused |
2 findings below minor not shown (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (45e1372fa6d8).
Review of 0f4f2ad1 · 11.11.2026 07:49 UTC
Apex Sentinel
Verdict: approve
3 finding(s): 3 minor.
🟡 Minor (3)
| Where | Finding |
|---|---|
packages/capture-kit/src/snapshot-occlusion.ts:539 |
isViewportAboveBottomBar reads a magic -1 parent key instead of no siblings |
packages/capture-kit/src/snapshot-occlusion.ts:540 |
Bottom-bar exemption keys on any two equal-width Buttons, exempting covering chrome |
packages/capture-kit/src/snapshot-occlusion.ts:529 |
Bottom-bar exemption comment and docs never record the new covered-state rule |
1 finding below minor not shown (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (45e1372fa6d8).
There was a problem hiding this comment.
Apex Sentinel: 3 new findings on 0f4f2ad. The verdict and the full list are in the summary comment.
|
The fix at 96a6775 changes occlusion classification on the live capture and press route, but it is proven only by a hand-built tree, and the iOS 27.2 live check was not run. All 17 checks pass at this commit. No conflicts. Before merge, the fix needs live iOS evidence from the Bottom Tabs screen. snapshot-occlusion.ts:530 runs on the production route: Not blocking, take or leave: the 'a real toolbar over content' test (:945) also fails the bottom-10% filter, so deleting the I judged the regression tests by tracing the base and head code paths and did not run them. I do not know whether iOS 27.0 or 27.1 simulators reproduce the 27.2 shape. Three earlier threads are fixed at this head and can be resolved: the single bottom Button case (#4405 (comment)), the |
Live iOS evidenceDevice: iPhone 18 Pro simulator, iOS 27.0. Base: Outputs below are trimmed to projected node identity, geometry and coverage. The toolbar and three tab buttons share parent 0; their edges differ by 0.333333343 points. Base Home (3 covered) [
{
"index": 0,
"type": "Application",
"role": "UIApplication",
"label": "e2e Benchmark",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 874
}
},
{
"index": 1,
"parentIndex": 0,
"type": "StaticText",
"role": "RCTParagraphComponentView",
"label": "Home",
"rect": {
"x": 177.3333282470703,
"y": 71,
"width": 47.333343505859375,
"height": 20.333335876464844
},
"interactionBlocked": "covered",
"coveredBy": {
"kind": "toolbar",
"label": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 791
}
}
},
{
"index": 2,
"parentIndex": 0,
"type": "StaticText",
"role": "RCTParagraphComponentView",
"label": "Home",
"identifier": "home-tab-content",
"rect": {
"x": 173.3333282470703,
"y": 422.00000762939453,
"width": 55,
"height": 24
},
"interactionBlocked": "covered",
"coveredBy": {
"kind": "toolbar",
"label": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 791
}
}
},
{
"index": 3,
"parentIndex": 0,
"type": "StaticText",
"role": "RCTParagraphComponentView",
"label": "Go to the Actions tab and press the button there.",
"rect": {
"x": 52.66666793823242,
"y": 454.00000762939453,
"width": 296.66668701171875,
"height": 15.666656494140625
},
"interactionBlocked": "covered",
"coveredBy": {
"kind": "toolbar",
"label": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 791
}
}
},
{
"index": 4,
"parentIndex": 0,
"type": "Toolbar",
"role": "_UIFloatingBarContainerView",
"label": "Toolbar",
"identifier": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 791
}
},
{
"index": 5,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Home, tab, 1 of 3",
"identifier": "tab-home",
"rect": {
"x": 0,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 6,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Feed, tab, 2 of 3",
"identifier": "tab-feed",
"rect": {
"x": 134,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 7,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Actions, tab, 3 of 3",
"identifier": "tab-actions",
"rect": {
"x": 268,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 8,
"parentIndex": 0,
"type": "Toolbar",
"role": "_UIFloatingBarContainerView",
"label": "Toolbar",
"identifier": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 874
}
}
]Head Home (0 covered) [
{
"index": 0,
"type": "Application",
"role": "UIApplication",
"label": "e2e Benchmark",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 874
}
},
{
"index": 1,
"parentIndex": 0,
"type": "StaticText",
"role": "RCTParagraphComponentView",
"label": "Home",
"rect": {
"x": 177.3333282470703,
"y": 71,
"width": 47.333343505859375,
"height": 20.333335876464844
}
},
{
"index": 2,
"parentIndex": 0,
"type": "StaticText",
"role": "RCTParagraphComponentView",
"label": "Home",
"identifier": "home-tab-content",
"rect": {
"x": 173.3333282470703,
"y": 422.00000762939453,
"width": 55,
"height": 24
}
},
{
"index": 3,
"parentIndex": 0,
"type": "StaticText",
"role": "RCTParagraphComponentView",
"label": "Go to the Actions tab and press the button there.",
"rect": {
"x": 52.66666793823242,
"y": 454.00000762939453,
"width": 296.66668701171875,
"height": 15.666656494140625
}
},
{
"index": 4,
"parentIndex": 0,
"type": "Toolbar",
"role": "_UIFloatingBarContainerView",
"label": "Toolbar",
"identifier": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 791
}
},
{
"index": 5,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Home, tab, 1 of 3",
"identifier": "tab-home",
"rect": {
"x": 0,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 6,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Feed, tab, 2 of 3",
"identifier": "tab-feed",
"rect": {
"x": 134,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 7,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Actions, tab, 3 of 3",
"identifier": "tab-actions",
"rect": {
"x": 268,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 8,
"parentIndex": 0,
"type": "Toolbar",
"role": "_UIFloatingBarContainerView",
"label": "Toolbar",
"identifier": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 874
}
}
]Head Actions (0 covered) [
{
"index": 0,
"type": "Application",
"role": "UIApplication",
"label": "e2e Benchmark",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 874
}
},
{
"index": 1,
"parentIndex": 0,
"type": "StaticText",
"role": "RCTParagraphComponentView",
"label": "Actions",
"rect": {
"x": 171,
"y": 71,
"width": 60,
"height": 20.333335876464844
}
},
{
"index": 2,
"parentIndex": 0,
"type": "Other",
"role": "RCTViewComponentView",
"label": "Complete action",
"identifier": "complete-action-button",
"rect": {
"x": 115,
"y": 424.3333206176758,
"width": 172.33334350585938,
"height": 43.33331298828125
}
},
{
"index": 3,
"parentIndex": 0,
"type": "Toolbar",
"role": "_UIFloatingBarContainerView",
"label": "Toolbar",
"identifier": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 791
}
},
{
"index": 4,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Home, tab, 1 of 3",
"identifier": "tab-home",
"rect": {
"x": 0,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 5,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Feed, tab, 2 of 3",
"identifier": "tab-feed",
"rect": {
"x": 134,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 6,
"parentIndex": 0,
"type": "Button",
"role": "RCTViewComponentView",
"label": "Actions, tab, 3 of 3",
"identifier": "tab-actions",
"rect": {
"x": 268,
"y": 791.3333333432674,
"width": 134,
"height": 48.66668701171875
}
},
{
"index": 7,
"parentIndex": 0,
"type": "Toolbar",
"role": "_UIFloatingBarContainerView",
"label": "Toolbar",
"identifier": "Toolbar",
"rect": {
"x": 0,
"y": 0,
"width": 402,
"height": 874
}
}
]Head press {
"success": true,
"data": {
"x": 201,
"y": 446,
"runnerMainThreadBusy": false,
"message": "Tapped id=\"complete-action-button\" (201, 446)",
"referenceWidth": 402,
"referenceHeight": 874,
"targetKind": "selector",
"selector": "id=\"complete-action-button\"",
"selectorChain": [
"id=\"complete-action-button\"",
"role=\"other\" label=\"Complete action\"",
"label=\"Complete action\""
],
"refLabel": "Complete action",
"resolution": {
"source": "runtime",
"phase": "pre-action",
"kind": "unique"
}
}
}The screenshot after the press showed “Action completed”. The head Home projection, without volatile process and ref fields, is committed as the regression fixture. |
|
The code at db45015 looks right to me, and it fixes the two problems from my earlier review at 96a6775: live evidence is now posted, and the fixture is the captured tree. I found no new problems. CI is green at db45015: 17 checks, none failing. There are no conflicts. The five earlier inline threads are fixed at this head, so you can resolve them: #4405 (comment) (complete bottom row), #4405 (comment) (Button and TabItem rows), #4405 (comment) (non-numeric parent index), #4405 (comment) (container role gate), #4405 (comment) (classifier comment). I did not run the tests. I traced the head and base code paths by hand, and I relied on the live base output for the shape the fixture uses. The live run used iOS 27.0, not the 27.2 named in the issue. Base reproduces on 27.0, so the fixture shape is real, but I did not check a 27.2 capture for different edge offsets. The 0.333pt gap between the container and the row sits inside the 0.5pt tolerance. I did not check other device scales or bar heights where the projected edges could differ by more. Nothing else is needed from you before a maintainer merges. |
Summary
Recognize a floating UIKit container above a complete tiled bottom tab row, so its projected content stays actionable. The exemption requires the
_UIFloatingBarContainerViewrole and viewport and bottom-row geometry. Ordinary toolbars, a single CTA, hosted controls, and sheets remain covering. Three files changed, including the captured projection fixture; no scope expansion.Fixes #4365
Validation
45e1372fa6d8fabe26ff35ab2ec207ccc58e53bdmarked three Home nodes covered by the 402×791 toolbar. Head runtime from96a677586108cce34e9644ae15dbfab20db2b7eeplus the source edits committed indb450150326d79b5b7c97eeeb9d4297f2329ef83showed zero covered on Home and Actions, and the action press succeeded. Captures and build details.pnpm check:affected --run --head db45015032: passed, receiptrun-ytMA4s,exactCommit: true. The new JSON fixture caused fail-open selection of the full runnable set.🤖 Generated with Claude Code