Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
|
The review comments are addressed, and the latest automated review found no issues. Could a maintainer review this PR? The local affected-check gate was blocked by my environment; please let me know if you need any additional validation. |
|
Thanks, this looks good at abdf3fa. Remote clients now get guidance they can follow: start a fresh session with The comments on the remote text and the daemon test are fixed and can be resolved. Not blocking: the reason string |
|
Good point. The reason string is duplicated across the daemon and client, so a rename could disable the recovery hint without a test catching it. Since this PR is already merged, I will keep that separate from its completed fix and address it in a follow-up if the maintainers want it. |
Summary
When
fill --record-aslacks an armed recording, the daemon tags the error with a typed reason. Remote clients now explain that recording must start in a fresh session on a local daemon, instead of suggesting a command the remote transport rejects. Local recovery guidance and the intentional remote refusal remain unchanged. Adds focused daemon and client coverage. Four files changed; scope stays within fill validation and client error adaptation. Closes #4345.Validation
abdf3fa705b14f20fe6a1fd9014837f9cfffa0c9.EROFSat~/.cache/agent-device/validation.reclaim.lock). On the previous commit it reached 76 Vitest files: 73 passed, 3 failed (333 passed, 6 failed), mostly because the environment could not create~/.agent-device/apple-runner/leases; one proxy parity assertion also failed. Earlier gate receipt:.tmp/validation/run-7f69Hp/receipt.json.