Repository navigation
Conversation
There was a problem hiding this comment.
4 issues found across 34 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/daemon/src/core/interaction/internal/interaction-touch-direct-ios-eligibility.ts">
<violation number="1" location="packages/daemon/src/core/interaction/internal/interaction-touch-direct-ios-eligibility.ts:38">
P3: This new early return has no direct test. Add a case in the daemon eligibility tests asserting `readDirectIosSelectorTapTarget` returns `null` when `flags.expectScreenshotDiff` is `true` on an otherwise eligible `click` selector target, so the fused route cannot regress silently.</violation>
</file>
<file name="packages/contracts/src/cli-flags.ts">
<violation number="1" location="packages/contracts/src/cli-flags.ts:126">
P3: This doc comment repeats the option's prose, which the header of this file says must live only on the `FlagDefinition` (flag-definitions-action.ts already has it). Remove the block and keep the bare field; the '#1047 sibling' ticket pointer goes with it.</violation>
</file>
<file name="test/integration/interaction-contract/runtime-selector.contract.test.ts">
<violation number="1" location="test/integration/interaction-contract/runtime-selector.contract.test.ts:378">
P3: This scenario never checks that the tap was dispatched: `tap` discards its arguments and no `taps` array is asserted. Record the dispatched point and assert one tap, so the test proves the pixel pair bracketed a real dispatch.</violation>
</file>
<file name="packages/command-surface/src/interaction/metadata.ts">
<violation number="1" location="packages/command-surface/src/interaction/metadata.ts:90">
P3: The description promises that `screenshotDiff` is reported, but the runtime silently omits it when a capture fails or the backend has no screenshot support. Add that caveat so callers, including models reading this schema, do not treat a missing `screenshotDiff` as a comparison result.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| maxPasses?: number; | ||
| doubleTap?: boolean; | ||
| verify?: boolean; | ||
| /** |
There was a problem hiding this comment.
P3: This doc comment repeats the option's prose, which the header of this file says must live only on the FlagDefinition (flag-definitions-action.ts already has it). Remove the block and keep the bare field; the '#1047 sibling' ticket pointer goes with it.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/contracts/src/cli-flags.ts, line 126:
<comment>This doc comment repeats the option's prose, which the header of this file says must live only on the `FlagDefinition` (flag-definitions-action.ts already has it). Remove the block and keep the bare field; the '#1047 sibling' ticket pointer goes with it.</comment>
<file context>
@@ -123,6 +123,13 @@ export type CliFlags = CloudProviderProfileFields &
maxPasses?: number;
doubleTap?: boolean;
verify?: boolean;
+ /**
+ * Press/click opt-in (#1047 sibling): bracket the dispatch with two
+ * lightweight screenshots and compare them, so a tap on a surface the
</file context>
| test(scenario('screenshotDiffEvidence'), async () => { | ||
| const device = createContractDevice(continueButtonSnapshot(), { | ||
| ...screenshotFramePlanBackend([{ color: [0, 0, 0] }, { color: [255, 255, 255] }]), | ||
| tap: async () => ({ ok: true }), |
There was a problem hiding this comment.
P3: This scenario never checks that the tap was dispatched: tap discards its arguments and no taps array is asserted. Record the dispatched point and assert one tap, so the test proves the pixel pair bracketed a real dispatch.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At test/integration/interaction-contract/runtime-selector.contract.test.ts, line 378:
<comment>This scenario never checks that the tap was dispatched: `tap` discards its arguments and no `taps` array is asserted. Record the dispatched point and assert one tap, so the test proves the pixel pair bracketed a real dispatch.</comment>
<file context>
@@ -367,6 +372,24 @@ test(scenario('settleObservation'), async () => {
+test(scenario('screenshotDiffEvidence'), async () => {
+ const device = createContractDevice(continueButtonSnapshot(), {
+ ...screenshotFramePlanBackend([{ color: [0, 0, 0] }, { color: [255, 255, 255] }]),
+ tap: async () => ({ ok: true }),
+ });
+
</file context>
|
|
||
| const expectScreenshotDiffField = () => | ||
| booleanField( | ||
| 'Compare lightweight screenshots taken right before the dispatch and after it settles briefly, and report the comparison as screenshotDiff in the response. Use it when the target lives outside the accessibility tree, such as a PIN keypad, where verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect.', |
There was a problem hiding this comment.
P3: The description promises that screenshotDiff is reported, but the runtime silently omits it when a capture fails or the backend has no screenshot support. Add that caveat so callers, including models reading this schema, do not treat a missing screenshotDiff as a comparison result.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/command-surface/src/interaction/metadata.ts, line 90:
<comment>The description promises that `screenshotDiff` is reported, but the runtime silently omits it when a capture fails or the backend has no screenshot support. Add that caveat so callers, including models reading this schema, do not treat a missing `screenshotDiff` as a comparison result.</comment>
<file context>
@@ -85,16 +85,23 @@ const interactionCommandDescriptions = {
+const expectScreenshotDiffField = () =>
+ booleanField(
+ 'Compare lightweight screenshots taken right before the dispatch and after it settles briefly, and report the comparison as screenshotDiff in the response. Use it when the target lives outside the accessibility tree, such as a PIN keypad, where verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect.',
+ );
+
</file context>
| 'Compare lightweight screenshots taken right before the dispatch and after it settles briefly, and report the comparison as screenshotDiff in the response. Use it when the target lives outside the accessibility tree, such as a PIN keypad, where verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect.', | |
| 'Compare lightweight screenshots taken right before the dispatch and after it settles briefly, and report the comparison as screenshotDiff in the response; the field is omitted when a capture fails or the backend has no screenshots. Use it when the target lives outside the accessibility tree, such as a PIN keypad, where verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect.', |
|
Coverage failed on an eager-closure ratchet: the new evidence module joined the command-runtime entry closure as a static edge. It now loads behind a function-scoped dynamic import (type import kept separate, so types cost nothing), with a follow-up fixing an intermediate scope mistake — verified green locally (typecheck/lint, 135 tests). 🤖 Generated with Claude Code |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
At 6606bb9, Right now
This change alters live dispatch: it bypasses the native ref fast path and the direct-iOS fused route, and brackets the tap with two captures and a 150 ms sleep. The PR body lists typecheck, lint, unit tests and progress checks at an older head (69032ca), with no device run. After the two fixes above, please run through the CLI on one iOS simulator and one Android emulator, against a screen with a static region or keypad. The run needs to show: Not blocking, take or leave: the flag could be a Could the readback be smaller? After splitting out b37da26, put The open review threads still apply, apart from one. P2: absent |
|
This now conflicts with main at 6606bb9. Please rebase onto main. The two defects and the live run from the earlier review still apply. |
|
Tracked in #4318, group C (new public surface). We're reviewing the six feature PRs together for coherence and for performance impact on paths that don't use them, and we'll post a direction there. Please hold changes here until then. |
|
Thanks @strzhao. We reviewed this with the rest of group C in #4318. It mixes two changes that should land separately.
What the visual feature needs:
Could you open the split PR for part 1 and an issue for part 2? |
…eadback A coordinate press on a surface the accessibility tree cannot describe — a PIN keypad whose keys never reach the tree — dispatches fine, leaves --verify's node digest flat whether or not the digit was entered, and reports success. Repeated attempts walk toward a device lockout with no signal in any response. The flag brackets the dispatch with two lightweight screenshots and compares them on pixels instead of nodes: screenshotDiff carries changedFromBefore and the changed-pixel ratio. A matching pair adds a response warning, because the dispatch may have had no visible effect; the action itself still succeeds. Best-effort like --verify evidence: a failed capture or a screenshot-less backend drops the field and claims nothing about the screen. The flag routes press/click through the runtime path (the native ref fast path and the fused direct-iOS route never reach the bracket), and the decode stack loads behind function-scoped dynamic imports so the flag-less fast path pays nothing. Co-Authored-By: Claude Code <noreply@anthropic.com>
…nshot-diff The compact workflow card has a byte ratchet (cli-help.test.ts) with no headroom for a new sentence, and the flag's owning help already carries the full guidance: the flag definition's usage text renders in "Command flags:" for press/click, and the metadata field description documents the PIN-keypad case for the Node SDK and MCP schemas. Co-Authored-By: Claude Code <noreply@anthropic.com>
…apCommand The before-frame capture, its dispatch-failure cleanup, and the pair outcome composition each added a branch to a function the complexity gate already watches. dispatchWithScreenshotPair owns the bracket lifecycle and attachScreenshotPairOutcome owns the result composition, so tapCommand reads as dispatch-plus-observation again; the reader gate's positional table flattens the same way. Co-Authored-By: Claude Code <noreply@anthropic.com>
The bracket lifecycle moved behind dispatchWithScreenshotPair, so the two frame helpers no longer need exports; the dead-export gate reads them as unused module surface. Co-Authored-By: Claude Code <noreply@anthropic.com>
…matrix, settle the after-frame, and document the out-of-tree readback Review fixes for the press/click --expect-screenshot-diff PR: - The guarantee matrix (ADR 0011) gains the screenshotDiffEvidence row: runtime cells on runtime-selector/runtime-ref/coordinate scoped to press/click, a delegated cell on native-ref, and inapplicable cells on the paths the flag cannot reach. The three waivers that named only --verify/--settle as the opt-in post-action evidence routes now name this flag too. Each enforced cell carries a contract scenario, and the shared harness replays a solid-color frame plan. - The after-frame waits 150ms past the dispatch reply before it is captured: the reaction the flag asks about can render frames after the transport round trip returns, and an immediate frame would read an effective tap as unchanged. The flag help text, field descriptions, and schema prose state the timing instead of leaving it blank. - commands.md names the flag where it teaches that a successful press is not proof of effect: a PIN keypad target is the case --verify cannot answer, since it compares empty trees. - Gate drift the PR introduced: the new capture-kit export joins the layering manifest baseline, and the flag descriptor gate moves to test/repo-guards/ (a repo-level guard on command descriptors, not a module's unit test — R84 test-colocation). Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
6606bb9 to
7a61db9
Compare
|
Rebased onto main (through 0.21.37). The only conflict was the interaction metadata field list — the plan now spreads main's |
|
Two defects from the earlier review (6606bb9, #4297 (comment)) are still open at 7a61db9, and the PR has no device run yet. CI is green: 19 of 19 checks pass. It cannot catch the two defects below, because every readback test injects
Live dispatch also changed. Under the flag, the native ref fast path and the direct-iOS fused route are bypassed, and two captures plus a 150 ms wait bracket the tap (interactions.ts#L184). Nothing proves the readback works on a real backend, and the first defect shows that it currently does not. After both fixes, please run through the CLI on one iOS simulator and one Android emulator. Show Not blocking, take or leave: the before-frame capture now sits between the at-rest confirmation in The review threads on the missing inconclusive-when-absent note in the docs (r4497036453), the missing catch after dispatch (r4497036487), the tap stub that records nothing (r4497036494), the repo guard's Before merge, please open the design issue for the screenshot readback, since the baseline half shipped in #4338, then fix the two defects and post the live iOS and Android run. |
…ed tap Nothing after a resolved dispatch throws out of the evidence lane anymore: a decode, read, import or cleanup failure yields no evidence, because a throwing readback reported a delivered tap as failed and a PIN caller would re-enter the digit. The after-frame settle honors the request signal. Both frames decode in the codec worker, the guard audits a missing descriptor instead of skipping it, the docs say the readback is best-effort, and the delivered-tap tests record the tap. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Progress at ffff797, with the decision carried to #4509. Defect 2 fixed. Nothing after a resolved dispatch throws out of the evidence lane: the comparison runs inside a catch that yields no evidence, cleanups are caught, the after-frame settle honors the request signal, and both frames decode in the codec worker ( Defect 1 is the design decision. #4509 carries it: admit a capture operation on touch routes, or refuse pre-dispatch where no binding exists. Per the 11-08 direction the design issue comes first; the binding follows its outcome, and the live iOS/Android runs follow the binding (before it lands, the flag cannot report on a shipped surface — which is defect 1 itself). Taken as well: the docs' inconclusive-when-absent sentence, and r4497036570 resolved as not applying. The remaining threads (r4497036453, r4497036487, r4497036494, r4497036501, r4497036514) are fixed at this head; r4497036508 routes to #4509. Title and body retitle to the readback once defect 1 lands and the flag reports for real. |
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/command-runtime/src/commands/interaction/runtime/screenshot-diff-evidence.ts">
<violation number="1" location="packages/command-runtime/src/commands/interaction/runtime/screenshot-diff-evidence.ts:168">
P2: ` sleep` resolves normally on abort, so this continues into the after-frame capture instead of stopping readback. Check `options.signal ?? runtime.signal` after sleeping and return no evidence when it is aborted.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| ): Promise<ScreenshotPairOutcome> { | ||
| try { | ||
| // A request canceled after the dispatch stops waiting for the after-frame. | ||
| await sleep(runtime, AFTER_FRAME_SETTLE_MS, options.signal); |
There was a problem hiding this comment.
P2: sleep resolves normally on abort, so this continues into the after-frame capture instead of stopping readback. Check options.signal ?? runtime.signal after sleeping and return no evidence when it is aborted.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/command-runtime/src/commands/interaction/runtime/screenshot-diff-evidence.ts, line 168:
<comment>` sleep` resolves normally on abort, so this continues into the after-frame capture instead of stopping readback. Check `options.signal ?? runtime.signal` after sleeping and return no evidence when it is aborted.</comment>
<file context>
@@ -145,23 +147,43 @@ async function compareScreenshotPair(
+): Promise<ScreenshotPairOutcome> {
+ try {
+ // A request canceled after the dispatch stops waiting for the after-frame.
+ await sleep(runtime, AFTER_FRAME_SETTLE_MS, options.signal);
const after = await capturePairScreenshotFrame(runtime, options, 'after');
if (!after) return {};
</file context>
| await sleep(runtime, AFTER_FRAME_SETTLE_MS, options.signal); | |
| const signal = options.signal ?? runtime.signal; | |
| await sleep(runtime, AFTER_FRAME_SETTLE_MS, signal); | |
| if (signal?.aborted) return {}; |
|
I reviewed ffff797 against my earlier review at #4297 (comment). The capture-failure, corrupted-frame and docs concerns are fixed. The silent no-op on daemon routes is not, and there is still no live device run. The daemon touch backend is built without Under the flag, the native ref fast path and the direct-iOS fused route are bypassed (interactions.ts:154). Two captures and a 150 ms wait now bracket the tap. This changes live dispatch, and no device run exists at this head. After the fix above, please run through the CLI on one iOS simulator and one Android emulator: Of the other open threads, the abort-handling thread still applies, and so do three lower-priority ones. The dynamic-import thread does not apply, because the import is evaluated once and then served from the module cache: #4297 (comment). The threads on the docs sentence, the capture-failure catch, the capture-failure test, the metadata CI is green with 19 of 19 checks passing, but no CI route exercises the daemon touch route with the flag, so green does not cover the first issue. Before merge, the daemon binding or refusal needs to land with its route test, and then the live iOS and Android runs need to be posted. |
…l a capture binds The touch routes admit the flag but bind no screenshot capture, so the flag was a silent no-op on every shipped surface. The refusal lives at the one place the daemon admits the flag: typed reason screenshot-readback-unavailable, dispatched no, and the callstack#4509 decision owns when the capture binds instead. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Defect 1 is enforced at the one place the daemon admits the flag: The CLI live runs you specified are meaningful once the flag reports on a shipped surface — under the refusal that is the typed refusal JSON on the daemon route, which I can attach next, and the runtime-lane runs (effective key, dead region, runtime-ref click) follow the #4509 binding decision. Title/body retitle to the readback with the next push. |
|
Thanks for the update. At 434e4ad the earlier findings on the delivered-tap tests, the after-frame error handling, the missing-descriptor guard and the PNG decode are fixed. One problem remains, and it is a new one. All 19 checks pass, but no job drives the daemon press/click route with the flag and asserts Every daemon press and click with Not blocking, and you can take or leave these: the guarantee matrix still marks Could the PR avoid shipping an advertised flag whose only production behavior is a refusal? Landing the capture binding first would remove the refusal, the dead eligibility guard and the pass-through, and the existing bracket would work on the real route. Otherwise, removing the flag from every surface and the matrix and parking the runtime lane until #4509 decides would avoid carrying about 209 production lines that no production route reaches. Could the baseline also fold into the post-action observation plan as a third evidence kind, so it has one owner? Of the open inline threads, the abort/deadline thread still applies (it must be fixed when a capture binds), as do the unreachable direct-iOS guard, the Before merge, the advertised flag and the daemon route must agree, either by binding the capture or by removing the flag from every surface and the matrix. |
--expect-screenshot-diff now works on the daemon press and click routes: the route admits the flag, binds the device's screenshot capture through the screenshot lane's own plan admission, and hands it to the interaction backend, so the readback bracket runs instead of returning no evidence. A device whose owner declares no capture still refuses before dispatch, with the screenshot lane's refusal stamped dispatched no. The refusal guard is gone; callstack#4509 keeps the any-pixel threshold question. Co-Authored-By: Claude Code <noreply@anthropic.com>
There was a problem hiding this comment.
3 issues found across 4 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/daemon/src/execution/interaction/internal/interaction-touch-press-admission.test.ts">
<violation number="1" location="packages/daemon/src/execution/interaction/internal/interaction-touch-press-admission.test.ts:368">
P3: The rewritten refusal test no longer pins `details.reason`, so the specific refusal cause is unchecked. Keep a reason assertion, for example `expect(response.error.details?.reason).toBeDefined();`, so a change in the refusal cause fails the test.</violation>
</file>
<file name="packages/daemon/src/execution/interaction/internal/interaction-runtime.ts">
<violation number="1" location="packages/daemon/src/execution/interaction/internal/interaction-runtime.ts:202">
P1: `readbackCapture` never reaches the backend. `createInteractionRuntimeForRoute` accepts it but drops it in the `createInteractionAgentDevice` call, so `captureScreenshot` is never installed and `--expect-screenshot-diff` still silently does nothing on daemon press/click. Forward `readbackCapture: params.readbackCapture` in that call and add the field to `InteractionRuntimeInput`. That also removes the cast here.</violation>
<violation number="2" location="packages/daemon/src/execution/interaction/internal/interaction-runtime.ts:220">
P2: The readback drops the session's capture context, so it can omit configured runner metadata and use the wrong macOS capture surface. Pass the session app bundle, surface, and execution context through this handoff.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
|
||
| function createInteractionBackend(params: InteractionRuntimeInput): AgentDeviceBackend { | ||
| const { flags, session } = params; | ||
| const readbackCapture = ( |
There was a problem hiding this comment.
P1: readbackCapture never reaches the backend. createInteractionRuntimeForRoute accepts it but drops it in the createInteractionAgentDevice call, so captureScreenshot is never installed and --expect-screenshot-diff still silently does nothing on daemon press/click. Forward readbackCapture: params.readbackCapture in that call and add the field to InteractionRuntimeInput. That also removes the cast here.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/interaction/internal/interaction-runtime.ts, line 202:
<comment>`readbackCapture` never reaches the backend. `createInteractionRuntimeForRoute` accepts it but drops it in the `createInteractionAgentDevice` call, so `captureScreenshot` is never installed and `--expect-screenshot-diff` still silently does nothing on daemon press/click. Forward `readbackCapture: params.readbackCapture` in that call and add the field to `InteractionRuntimeInput`. That also removes the cast here.</comment>
<file context>
@@ -193,10 +199,29 @@ function createInteractionAgentDevice(params: InteractionRuntimeInput) {
function createInteractionBackend(params: InteractionRuntimeInput): AgentDeviceBackend {
const { flags, session } = params;
+ const readbackCapture = (
+ params as InteractionRuntimeInput & {
+ readbackCapture?: (input: { outPath: string; options?: unknown }) => Promise<unknown>;
</file context>
| outPath: string, | ||
| options?: BackendScreenshotOptions, | ||
| ) => { | ||
| await readbackCapture({ outPath, ...(options ? { options } : {}) }); |
There was a problem hiding this comment.
P2: The readback drops the session's capture context, so it can omit configured runner metadata and use the wrong macOS capture surface. Pass the session app bundle, surface, and execution context through this handoff.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/interaction/internal/interaction-runtime.ts, line 220:
<comment>The readback drops the session's capture context, so it can omit configured runner metadata and use the wrong macOS capture surface. Pass the session app bundle, surface, and execution context through this handoff.</comment>
<file context>
@@ -193,10 +199,29 @@ function createInteractionAgentDevice(params: InteractionRuntimeInput) {
+ outPath: string,
+ options?: BackendScreenshotOptions,
+ ) => {
+ await readbackCapture({ outPath, ...(options ? { options } : {}) });
+ return { path: outPath };
+ },
</file context>
| expect(response?.ok, positionals.join(' ')).toBe(false); | ||
| if (response && !response.ok) { | ||
| // The screenshot lane's own refusal: the owner declares no capture operation. | ||
| expect(response.error.code).toBe('UNSUPPORTED_OPERATION'); |
There was a problem hiding this comment.
P3: The rewritten refusal test no longer pins details.reason, so the specific refusal cause is unchecked. Keep a reason assertion, for example expect(response.error.details?.reason).toBeDefined();, so a change in the refusal cause fails the test.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/interaction/internal/interaction-touch-press-admission.test.ts, line 368:
<comment>The rewritten refusal test no longer pins `details.reason`, so the specific refusal cause is unchecked. Keep a reason assertion, for example `expect(response.error.details?.reason).toBeDefined();`, so a change in the refusal cause fails the test.</comment>
<file context>
@@ -364,9 +364,10 @@ test('press --expect-screenshot-diff refuses at the route while no capture binds
- expect(response.error.code).toBe('INVALID_ARGS');
- expect(response.error.details?.reason).toBe('screenshot-readback-unavailable');
+ // The screenshot lane's own refusal: the owner declares no capture operation.
+ expect(response.error.code).toBe('UNSUPPORTED_OPERATION');
expect(response.error.details?.dispatched).toBe('no');
+ expect(String(response.error.message)).toMatch(/screenshot/i);
</file context>
| expect(response.error.code).toBe('UNSUPPORTED_OPERATION'); | |
| expect(response.error.code).toBe('UNSUPPORTED_OPERATION'); | |
| expect(response.error.details?.reason).toBeDefined(); |
The interaction route's artifacts policy refuses temp files by design, so the readback's before and after frames never got created and the flag answered with silence even after the capture bound. The lane owns its frame directory (mkdtemp plus cleanup with the frame) instead of asking the route's adapter. A device whose owner declares no capture still refuses before dispatch with the screenshot lane's refusal, stamped dispatched no. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
|
The capture now binds into the touch backend — route A, as you laid out. At e62ff68 (the binding at The binding. Route test. The plan and single-ref forms both drive the route; a capture-less device refuses with the stamped verdict, and the capture-backed lane is exercised by the evidence test suite (backend member present → bracket runs → Live runs (iOS simulator, PIN-pad rig; JSON excerpts in
The guarantees matrix keeps the runtime rows enforced (the route now reaches them); the abort/deadline fix landed with the binding (the settle sleep takes the request signal), and the unreachable-guard/pass-through notes dissolved with the refusal's deletion. 793 interaction/daemon tests, typecheck, lint, and fallow pass at the pushed head. |
There was a problem hiding this comment.
4 issues found across 3 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/daemon/src/execution/interaction/internal/interaction-runtime.ts">
<violation number="1" location="packages/daemon/src/execution/interaction/internal/interaction-runtime.ts:65">
P2: Remove this temporary `console.error`; it writes a `[readback-diag]` message to stderr on every interaction route invocation and pollutes daemon logs.</violation>
</file>
<file name="docs/evidence/ios-screenshot-readback-2026-11-15.md">
<violation number="1" location="docs/evidence/ios-screenshot-readback-2026-11-15.md:49">
P3: The ratio comparison contradicts itself. 0.0006 is about six times below the effective key's 0.0037, not an order of magnitude. Replace 'an order of magnitude below' with 'about six times below' so the sentence matches the next sentence.</violation>
<violation number="2" location="docs/evidence/ios-screenshot-readback-2026-11-15.md:49">
P3: This cause is asserted without evidence. Either record a rerun with the status bar excluded or masked, or phrase it as a hypothesis. Also list the dead-tap command and coordinates so the sample can be reproduced.</violation>
<violation number="3" location="docs/evidence/ios-screenshot-readback-2026-11-15.md:50">
P2: The dead-tap pair still contains a ticking status-bar clock even though the readback requests `normalizeStatusBar: true` and simulator captures pin the time to 9:41. Fix the daemon-bound capture normalization before treating this as only a threshold-policy question; otherwise status-bar changes mask no-op taps.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| const ref = bindInteractionSession(params).sessionRef; | ||
| if (!ref) throw new KernelAppError('SESSION_NOT_FOUND', NO_ACTIVE_SESSION_MESSAGE); | ||
| const session = params.sessionStore.requireCurrent(ref); | ||
| console.error( |
There was a problem hiding this comment.
P2: Remove this temporary console.error; it writes a [readback-diag] message to stderr on every interaction route invocation and pollutes daemon logs.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/interaction/internal/interaction-runtime.ts, line 65:
<comment>Remove this temporary `console.error`; it writes a `[readback-diag]` message to stderr on every interaction route invocation and pollutes daemon logs.</comment>
<file context>
@@ -62,10 +62,15 @@ export async function createInteractionRuntimeForRoute(
const ref = bindInteractionSession(params).sessionRef;
if (!ref) throw new KernelAppError('SESSION_NOT_FOUND', NO_ACTIVE_SESSION_MESSAGE);
const session = params.sessionStore.requireCurrent(ref);
+ console.error(
+ '[readback-diag] forRoute params.readbackCapture =',
+ typeof (params as { readbackCapture?: unknown }).readbackCapture,
</file context>
| ``` | ||
|
|
||
| The ratio is an order of magnitude below the effective key's, but still above | ||
| zero: the status-bar clock ticks between the bracket's frames even on a page |
There was a problem hiding this comment.
P2: The dead-tap pair still contains a ticking status-bar clock even though the readback requests normalizeStatusBar: true and simulator captures pin the time to 9:41. Fix the daemon-bound capture normalization before treating this as only a threshold-policy question; otherwise status-bar changes mask no-op taps.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At docs/evidence/ios-screenshot-readback-2026-11-15.md, line 50:
<comment>The dead-tap pair still contains a ticking status-bar clock even though the readback requests `normalizeStatusBar: true` and simulator captures pin the time to 9:41. Fix the daemon-bound capture normalization before treating this as only a threshold-policy question; otherwise status-bar changes mask no-op taps.</comment>
<file context>
@@ -0,0 +1,55 @@
+```
+
+The ratio is an order of magnitude below the effective key's, but still above
+zero: the status-bar clock ticks between the bracket's frames even on a page
+whose content is otherwise static. This is the any-pixel rule's live shape and
+the concrete case for the #4509 threshold question — the readback correctly
</file context>
| } | ||
| ``` | ||
|
|
||
| The ratio is an order of magnitude below the effective key's, but still above |
There was a problem hiding this comment.
P3: The ratio comparison contradicts itself. 0.0006 is about six times below the effective key's 0.0037, not an order of magnitude. Replace 'an order of magnitude below' with 'about six times below' so the sentence matches the next sentence.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At docs/evidence/ios-screenshot-readback-2026-11-15.md, line 49:
<comment>The ratio comparison contradicts itself. 0.0006 is about six times below the effective key's 0.0037, not an order of magnitude. Replace 'an order of magnitude below' with 'about six times below' so the sentence matches the next sentence.</comment>
<file context>
@@ -0,0 +1,55 @@
+}
+```
+
+The ratio is an order of magnitude below the effective key's, but still above
+zero: the status-bar clock ticks between the bracket's frames even on a page
+whose content is otherwise static. This is the any-pixel rule's live shape and
</file context>
| } | ||
| ``` | ||
|
|
||
| The ratio is an order of magnitude below the effective key's, but still above |
There was a problem hiding this comment.
P3: This cause is asserted without evidence. Either record a rerun with the status bar excluded or masked, or phrase it as a hypothesis. Also list the dead-tap command and coordinates so the sample can be reproduced.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At docs/evidence/ios-screenshot-readback-2026-11-15.md, line 49:
<comment>This cause is asserted without evidence. Either record a rerun with the status bar excluded or masked, or phrase it as a hypothesis. Also list the dead-tap command and coordinates so the sample can be reproduced.</comment>
<file context>
@@ -0,0 +1,55 @@
+}
+```
+
+The ratio is an order of magnitude below the effective key's, but still above
+zero: the status-bar clock ticks between the bracket's frames even on a page
+whose content is otherwise static. This is the any-pixel rule's live shape and
</file context>
Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Thanks for the update. At f49ebe6 the readback now reaches the daemon route and the iOS simulator run shows The evidence still has gaps (doc line 36). It covers only the iOS simulator, and its dead-region run reads The dead-tap false positive is probably caused by the readback itself (screenshot-diff-evidence.ts:135). Each frame is a separate The new refusal contradicts the docs (interaction-touch-press.ts:57). When the device owner declares no The frame file is a copy of a daemon helper (screenshot-diff-evidence.ts:121). The inline mkdtemp, path.join and The readback capture input is too thin (interaction-runtime.ts:225). It sends only No daemon test covers the bound route (interaction-touch-press-admission.test.ts:355). The contract scenarios and There is leftover debug output (interaction-runtime.ts:65). An unconditional Not blocking: Could this be simpler? The daemon could hand the touch backend one typed On the open inline threads: these still stand and need no restatement: the capture input, the console.error, the abort signal (it still passes Before merge: make the readback's status-bar handling identical in both frames, then post the iOS dead-region run that reads |
…xt, and restore the temp-file port The readback frame now carries the input the screenshot command would build for this request: the session's app identity, the simulator boot-check knowledge, and the runner execution from the dispatch context. The shared temp-file implementation moves into runtime-artifacts, the interaction route's policy opts in, and the lane goes back to the runtime's createCommandTempFile. The advisory case on a capture-less device pins dispatch-with-no-evidence. Co-Authored-By: Claude Code <noreply@anthropic.com>
There was a problem hiding this comment.
3 existing issues remain and 6 new issues found across 11 files (changes from recent commits).
You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/daemon/src/execution/runtime-policy.ts">
<violation number="1" location="packages/daemon/src/execution/runtime-policy.ts:10">
P3: The new `allowTempFiles` branch has no test. Add a case that calls `createDaemonRuntimePolicy('interaction commands', { allowTempFiles: true })` and asserts `createTempFile` creates a file, while the default still rejects with `UNSUPPORTED_OPERATION`.</violation>
</file>
<file name="packages/capture-kit/src/png-changed-pixel-ratio.ts">
<violation number="1" location="packages/capture-kit/src/png-changed-pixel-ratio.ts:21">
P3: The docstring says `ignoreTopHeightShare` removes the top band from the denominator too, but the code keeps the full-frame `totalPixels` denominator. Reword the doc to match the code, which the test and the last docstring sentence already assume. The inline comment above the `ignoredRows` block ("contribute nothing to either side of the ratio") has the same error and needs the same fix.</violation>
</file>
<file name="packages/daemon/src/execution/interaction/internal/interaction-runtime.ts">
<violation number="1" location="packages/daemon/src/execution/interaction/internal/interaction-runtime.ts:202">
P3: `allowTempFiles: true` grants temp-file creation to every interaction route, not just the admitted readback. Tie it to the readback admission so only that request gets the capability.</violation>
</file>
<file name="packages/daemon/src/execution/runtime-artifacts.ts">
<violation number="1" location="packages/daemon/src/execution/runtime-artifacts.ts:11">
P3: The doc comment links to `createTempFileArtifactAdapter`, which does not exist, so the reference is broken. The opt-in actually happens through `createDaemonRuntimePolicy(..., { allowTempFiles: true })`. Also, 'every daemon route shares' contradicts the rest of the comment, since refusing routes don't use it. Point the comment at `createDaemonRuntimePolicy` and say only opted-in routes use this implementation.</violation>
<violation number="2" location="packages/daemon/src/execution/runtime-artifacts.ts:22">
P2: The readback awaits this cleanup without catching errors; if `rm` rejects after a failed before-capture, the advisory readback escapes before dispatch and prevents the press/click. Keep this cleanup best-effort.</violation>
</file>
<file name="packages/daemon/src/execution/interaction/internal/interaction-touch-press.ts">
<violation number="1" location="packages/daemon/src/execution/interaction/internal/interaction-touch-press.ts:47">
P2: This unconditional debug print writes every targeted touch's full flags to stderr, polluting daemon logs and potentially exposing user-supplied values; remove it.</violation>
</file>
Requires human review: Auto-approval blocked because this review re-detected 3 unresolved issues already reported by Cubic.
View guided diff | Re-trigger cubic
| path: path.join(root, `file${options.ext}`), | ||
| visibility: 'internal', | ||
| cleanup: async () => { | ||
| await fs.rm(root, { recursive: true, force: true }); |
There was a problem hiding this comment.
P2: The readback awaits this cleanup without catching errors; if rm rejects after a failed before-capture, the advisory readback escapes before dispatch and prevents the press/click. Keep this cleanup best-effort.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/runtime-artifacts.ts, line 22:
<comment>The readback awaits this cleanup without catching errors; if `rm` rejects after a failed before-capture, the advisory readback escapes before dispatch and prevents the press/click. Keep this cleanup best-effort.</comment>
<file context>
@@ -1,6 +1,29 @@
+ path: path.join(root, `file${options.ext}`),
+ visibility: 'internal',
+ cleanup: async () => {
+ await fs.rm(root, { recursive: true, force: true });
+ },
+ };
</file context>
| command: TargetedTouchCommand, | ||
| ): Promise<DaemonResponse> { | ||
| params = bindInteractionSession(params); | ||
| console.error('[readback-diag] route flags =', JSON.stringify(params.req.flags)); |
There was a problem hiding this comment.
P2: This unconditional debug print writes every targeted touch's full flags to stderr, polluting daemon logs and potentially exposing user-supplied values; remove it.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/interaction/internal/interaction-touch-press.ts, line 47:
<comment>This unconditional debug print writes every targeted touch's full flags to stderr, polluting daemon logs and potentially exposing user-supplied values; remove it.</comment>
<file context>
@@ -41,35 +44,28 @@ export async function dispatchTargetedTouchViaRuntime(
command: TargetedTouchCommand,
): Promise<DaemonResponse> {
params = bindInteractionSession(params);
+ console.error('[readback-diag] route flags =', JSON.stringify(params.req.flags));
const admission = await admitTargetedTouch(params, command);
if ('response' in admission) return admission.response;
</file context>
| ): Pick<AgentDeviceRuntimeConfig, 'artifacts' | 'policy'> { | ||
| return { | ||
| artifacts: createUnsupportedArtifactAdapter(unsupportedArtifactLabel, options), | ||
| artifacts: options.allowTempFiles |
There was a problem hiding this comment.
P3: The new allowTempFiles branch has no test. Add a case that calls createDaemonRuntimePolicy('interaction commands', { allowTempFiles: true }) and asserts createTempFile creates a file, while the default still rejects with UNSUPPORTED_OPERATION.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/runtime-policy.ts, line 10:
<comment>The new `allowTempFiles` branch has no test. Add a case that calls `createDaemonRuntimePolicy('interaction commands', { allowTempFiles: true })` and asserts `createTempFile` creates a file, while the default still rejects with `UNSUPPORTED_OPERATION`.</comment>
<file context>
@@ -1,13 +1,18 @@
): Pick<AgentDeviceRuntimeConfig, 'artifacts' | 'policy'> {
return {
- artifacts: createUnsupportedArtifactAdapter(unsupportedArtifactLabel, options),
+ artifacts: options.allowTempFiles
+ ? {
+ ...createUnsupportedArtifactAdapter(unsupportedArtifactLabel, options),
</file context>
| * `ignoreTopHeightShare` cuts the top share of the frame out of both the changed count and the | ||
| * denominator, for bands whose pixels move without the dispatch causing it — a status-bar clock | ||
| * ticks between the bracket's frames on every platform, and the readback must answer for what the | ||
| * dispatch changed, not for the wall clock. The excluded rows are zeroed in the comparison, so the | ||
| * share is a plain fraction of the full frame either way. |
There was a problem hiding this comment.
P3: The docstring says ignoreTopHeightShare removes the top band from the denominator too, but the code keeps the full-frame totalPixels denominator. Reword the doc to match the code, which the test and the last docstring sentence already assume. The inline comment above the ignoredRows block ("contribute nothing to either side of the ratio") has the same error and needs the same fix.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/capture-kit/src/png-changed-pixel-ratio.ts, line 21:
<comment>The docstring says `ignoreTopHeightShare` removes the top band from the denominator too, but the code keeps the full-frame `totalPixels` denominator. Reword the doc to match the code, which the test and the last docstring sentence already assume. The inline comment above the `ignoredRows` block ("contribute nothing to either side of the ratio") has the same error and needs the same fix.</comment>
<file context>
@@ -17,10 +17,17 @@ export type PngChangedPixelRatioResult =
* Dimensions must match. Callers comparing frames of different sizes are asking a different
* question, and returning a made-up ratio would hide it.
+ *
+ * `ignoreTopHeightShare` cuts the top share of the frame out of both the changed count and the
+ * denominator, for bands whose pixels move without the dispatch causing it — a status-bar clock
+ * ticks between the bracket's frames on every platform, and the readback must answer for what the
</file context>
| * `ignoreTopHeightShare` cuts the top share of the frame out of both the changed count and the | |
| * denominator, for bands whose pixels move without the dispatch causing it — a status-bar clock | |
| * ticks between the bracket's frames on every platform, and the readback must answer for what the | |
| * dispatch changed, not for the wall clock. The excluded rows are zeroed in the comparison, so the | |
| * share is a plain fraction of the full frame either way. | |
| * `ignoreTopHeightShare` leaves the top share of the frame out of the changed count. Those rows | |
| * are skipped rather than removed from the denominator, so the ratio stays a fraction of the full | |
| * frame. The option is for bands whose pixels move without the dispatch causing it: a status-bar | |
| * clock ticks between the bracket's frames on every platform, and the readback must answer for what | |
| * the dispatch changed, not for the wall clock. |
| ...createDaemonRuntimePolicy('interaction commands', { | ||
| plural: true, | ||
| // The screenshot readback's before/after frames are this route's own temp files. | ||
| allowTempFiles: true, |
There was a problem hiding this comment.
P3: allowTempFiles: true grants temp-file creation to every interaction route, not just the admitted readback. Tie it to the readback admission so only that request gets the capability.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/interaction/internal/interaction-runtime.ts, line 202:
<comment>`allowTempFiles: true` grants temp-file creation to every interaction route, not just the admitted readback. Tie it to the readback admission so only that request gets the capability.</comment>
<file context>
@@ -196,19 +196,19 @@ function resolveBoundCapture(
+ ...createDaemonRuntimePolicy('interaction commands', {
+ plural: true,
+ // The screenshot readback's before/after frames are this route's own temp files.
+ allowTempFiles: true,
+ }),
sessions: params.runtimeSessions,
</file context>
| allowTempFiles: true, | |
| allowTempFiles: params.readbackCapture !== undefined, |
| * The one temp-file implementation every daemon route shares: an `agent-device-*` root under the | ||
| * process tmpdir, one file inside, removed with the cleanup. Routes whose policy refuses temp | ||
| * files keep the refusing adapter; routes that opt in (an artifacts adapter from | ||
| * {@link createTempFileArtifactAdapter}) get this implementation. |
There was a problem hiding this comment.
P3: The doc comment links to createTempFileArtifactAdapter, which does not exist, so the reference is broken. The opt-in actually happens through createDaemonRuntimePolicy(..., { allowTempFiles: true }). Also, 'every daemon route shares' contradicts the rest of the comment, since refusing routes don't use it. Point the comment at createDaemonRuntimePolicy and say only opted-in routes use this implementation.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/daemon/src/execution/runtime-artifacts.ts, line 11:
<comment>The doc comment links to `createTempFileArtifactAdapter`, which does not exist, so the reference is broken. The opt-in actually happens through `createDaemonRuntimePolicy(..., { allowTempFiles: true })`. Also, 'every daemon route shares' contradicts the rest of the comment, since refusing routes don't use it. Point the comment at `createDaemonRuntimePolicy` and say only opted-in routes use this implementation.</comment>
<file context>
@@ -1,6 +1,29 @@
+ * The one temp-file implementation every daemon route shares: an `agent-device-*` root under the
+ * process tmpdir, one file inside, removed with the cleanup. Routes whose policy refuses temp
+ * files keep the refusing adapter; routes that opt in (an artifacts adapter from
+ * {@link createTempFileArtifactAdapter}) get this implementation.
+ */
+export async function createDaemonTempFile(options: {
</file context>
|
Thanks for the update. I reviewed f66aa4b against the earlier review, including the delta and the CI logs. The readback route and capture-input wiring from the earlier review are now in place, but the status-bar problem is still open, so the dead-tap case can still report a change. There are no conflicts. The new No daemon test covers the bound readback route. The only daemon test that sets The readback still builds its own This is a device-facing change, and the evidence doc (ios-screenshot-readback-2026-11-15.md:36) is unchanged by the delta. No device has yet shown Checks show Repo Guards failing on one Fallow complexity breach in Not blocking: if the status-bar fix does not use Simplicity question: the delta adds a second These open inline threads still apply. The higher-priority ones are signal handling on abort, missing surface and preferred backend, per-frame status-bar normalization, temp-file cleanup without catch and stderr route-flags print. Eight lower-priority threads also still apply. These threads no longer apply and can be resolved: r4577119988 because Before merge, please make the readback's own pixels identical in both frames with one status-bar decision wired at |
|
This branch now conflicts with main at f66aa4b. Please rebase onto main and push along with the fixes from the earlier review, and I will re-check the new head. |
2026-11-15: the capture now binds on the daemon touch routes — this PR delivers the readback (
--expect-screenshot-diff) on press/click; the baseline half shipped in #4338. Live runs below and indocs/evidence/ios-screenshot-readback-2026-11-15.mdat heade62ff686e.Summary
A coordinate press on a PIN pad reported success while the digit never entered and the remaining-attempts counter ticked down — the no-op guard's baseline had fallen back to an older tree, exactly the blind spot its own comment admits. Two changes: the coordinate lane now takes a guaranteed fresh pre-tree when the session baseline is stale, and
press --expect-screenshot-diffadds an out-of-tree readback that compares a lightweight before/after screenshot digest, so "tapped, nothing happened" is a reported effect instead of a discovery.22 files changed (baseline freshness, expect readback, output fields, tests).
Validation
pnpm run typecheck,pnpm run lint, post-action-observation and interaction tests, integration-progress--check, fallow, freerange: pass locally.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.