Repository navigation
feat(lease): name a backend baseline in a proxy lease device spec - #4236
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
1 issue found across 21 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/commands/schema/cli-help.ts">
<violation number="1" location="src/commands/schema/cli-help.ts:573">
P3: This help text names the screenshot comparison option as `diff --baseline`, but the CLI syntax is `diff screenshot --baseline <path>`; use the full form.</violation>
</file>
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
|
At b7331fa, the baseline routing and the contract look right: One thing before merge: The help wording thread also still applies: please write Not blocking, take or leave: reflow the doc comments on |
|
This now conflicts with main after the latest merges (b7331fa no longer merges cleanly). Please rebase onto main. The findings from the earlier review still apply to this head. |
b7331fa to
862133e
Compare
|
Rebased onto main at c96a2d5 to resolve the conflict. New head 862133e. Conflicts in |
|
The rebase onto main is clean: the conflict from the earlier review (b7331fa) is gone, and I found no new problems in 862133e. The code still has one open issue, the trimmed echo of the baseline name from the open P2 thread. No conflicts. CI on this head is not conclusive. Eight jobs show cancelled, which follows the rebase push replacing earlier runs. Smoke Tests and Integration Tests are still running, and none has failed. The same jobs were green at b7331fa. I did not re-run validation or tests. I checked the moved doc's relative link and the ADR link by reading them, because the docs-link and prose gates were cancelled. The backend side (simlock#1308) is outside this repository, so the The open inline thread on the trimmed baseline name still applies (#4236 (comment)), and so does the one on the Not blocking, and you can take or leave these: the doc comment on Before merge, please resolve the P2 thread by keeping the echoed baseline name untrimmed, as the requested name is, and get a full green CI run on 862133e. |
862133e to
05ceb7b
Compare
|
Took over and pushed
Monitoring PR events and checking every two hours until ready for human review. No merge requested. Named-commit validation receipt (portable fields){
"version": 1,
"status": "passed",
"exitCode": 0,
"startedAt": "2026-11-11T22:28:00.778Z",
"finishedAt": "2026-11-11T22:37:31.122Z",
"refs": {
"base": "origin/main",
"head": "05ceb7b64cdafd3308f84078a7a0001cf79a06f6",
"resolvedBase": "2deb909ec88bbbde615ec7c8f3895ef222d8ab3d",
"resolvedHead": "05ceb7b64cdafd3308f84078a7a0001cf79a06f6",
"mergeBase": "2deb909ec88bbbde615ec7c8f3895ef222d8ab3d"
},
"checkoutChanged": false,
"exactCommit": true,
"results": [
{
"id": "format",
"status": "passed",
"exitCode": 0
},
{
"id": "lint",
"status": "passed",
"exitCode": 0
},
{
"id": "typecheck",
"status": "passed",
"exitCode": 0
},
{
"id": "test-app-typecheck",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Test App Build Cache / Resolve native fingerprint)"
},
{
"id": "test-app-security",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Test App Build Cache / Resolve native fingerprint)"
},
{
"id": "layering",
"status": "passed",
"exitCode": 0
},
{
"id": "di-seams",
"status": "passed",
"exitCode": 0
},
{
"id": "fallow",
"status": "passed",
"exitCode": 0
},
{
"id": "native-dupes",
"status": "passed",
"exitCode": 0
},
{
"id": "native-dupes-model",
"status": "passed",
"exitCode": 0
},
{
"id": "mcp-metadata",
"status": "passed",
"exitCode": 0
},
{
"id": "build",
"status": "passed",
"exitCode": 0
},
{
"id": "package",
"status": "passed",
"exitCode": 0
},
{
"id": "integration-node",
"status": "passed",
"exitCode": 0
},
{
"id": "macos-coverage",
"status": "passed",
"exitCode": 0
},
{
"id": "ios-snapshot-differential",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Apple / Smoke Tests (${{ matrix.platform }}))"
},
{
"id": "vitest-related",
"status": "passed",
"exitCode": 0
},
{
"id": "unit",
"status": "passed",
"exitCode": 0
},
{
"id": "unit-ci",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Coverage)"
},
{
"id": "coverage",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Coverage)"
},
{
"id": "coverage-crap",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Coverage)"
},
{
"id": "provider-integration",
"status": "passed",
"exitCode": 0
},
{
"id": "integration-progress",
"status": "passed",
"exitCode": 0
},
{
"id": "swift-runner-ios",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Apple / Smoke Tests (${{ matrix.platform }}), Conformance Differential / iOS Conformance Differential, Perf Nightly / iOS Command Perf, XCTest Nightly / iOS Runner Full XCTest Suite (${{ matrix.leg.name }}))"
},
{
"id": "swift-runner-macos",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Apple / Smoke Tests (${{ matrix.platform }}))"
},
{
"id": "android-helpers",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Android / Smoke Tests, Perf Nightly / Android Command Perf)"
},
{
"id": "macos-helper",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Apple / Smoke Tests (${{ matrix.platform }}))"
},
{
"id": "web-smoke",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Apple / Smoke Tests (${{ matrix.platform }}), Integration Tests, Lint, Typecheck & Package, Perf Nightly / Android Command Perf, Perf Nightly / iOS Command Perf)"
},
{
"id": "replay-compat",
"status": "passed",
"exitCode": 0
},
{
"id": "daemon-wire-compat",
"status": "passed",
"exitCode": 0
},
{
"id": "affected-selector",
"status": "passed",
"exitCode": 0
},
{
"id": "gate-manifest",
"status": "passed",
"exitCode": 0
},
{
"id": "gate-manifest-model",
"status": "passed",
"exitCode": 0
},
{
"id": "depgraph",
"status": "passed",
"exitCode": 0
},
{
"id": "tmpdir-leaks",
"status": "passed",
"exitCode": 0
},
{
"id": "tmpdir-leaks-model",
"status": "passed",
"exitCode": 0
},
{
"id": "coverage-model",
"status": "passed",
"exitCode": 0
},
{
"id": "coverage-crap-model",
"status": "passed",
"exitCode": 0
},
{
"id": "wire-compat-model",
"status": "passed",
"exitCode": 0
},
{
"id": "production-exports",
"status": "passed",
"exitCode": 0
},
{
"id": "bundle-owner-files",
"status": "passed",
"exitCode": 0
},
{
"id": "freerange",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Numeric Ranges)"
},
{
"id": "fixture-cache",
"status": "passed",
"exitCode": 0
},
{
"id": "fixture-fallback",
"status": "passed",
"exitCode": 0
},
{
"id": "command-docs",
"status": "passed",
"exitCode": 0
},
{
"id": "adr-citations",
"status": "passed",
"exitCode": 0
},
{
"id": "capabilities-matrix",
"status": "passed",
"exitCode": 0
},
{
"id": "docs-links",
"status": "passed",
"exitCode": 0
},
{
"id": "docs-prose",
"status": "passed",
"exitCode": 0
},
{
"id": "agent-guidance",
"status": "passed",
"exitCode": 0
},
{
"id": "xctest-selection",
"status": "passed",
"exitCode": 0
},
{
"id": "packaged-runner-swift",
"status": "passed",
"exitCode": 0
},
{
"id": "maestro-conformance",
"status": "passed",
"exitCode": 0
},
{
"id": "maestro-differential",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Conformance Differential / iOS Conformance Differential)"
},
{
"id": "maestro-regenerate",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Conformance Regenerate Verify / Regenerate & Verify Fixtures)"
},
{
"id": "fuzz-parsers",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Replay Nightly / Parser Fuzz Lane)"
},
{
"id": "mutation",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Mutation Harness Canary / Mutants (${{ matrix.name }}), Mutation Weekly / Mutants (${{ matrix.name }}))"
},
{
"id": "mutation-affected",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Mutation Harness Canary / Select harness validation kernels)"
},
{
"id": "mutation-check",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Mutation Weekly / Mutation score report)"
},
{
"id": "mutation-model",
"status": "passed",
"exitCode": 0
},
{
"id": "concurrency-torture",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Concurrency Torture Nightly / Session/lease/lock torture sweep, Integration Tests)"
},
{
"id": "replay-ios",
"status": "skipped",
"reason": "parked, workflow_dispatch only (Replay Manual / iOS Replay Suite)"
},
{
"id": "replay-ios-device",
"status": "skipped",
"reason": "parked, workflow_dispatch only (Replay Manual / iOS Replay Suite)"
},
{
"id": "replay-macos",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Apple / Smoke Tests (${{ matrix.platform }}))"
},
{
"id": "replay-linux",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Linux / Smoke Tests)"
},
{
"id": "linux-command-evidence",
"status": "skipped",
"reason": "GitHub-authoritative (jobs: Linux / Smoke Tests)"
},
{
"id": "replay-android",
"status": "skipped",
"reason": "parked, workflow_dispatch only (Replay Manual / Android Full Emulator Suite)"
}
]
} |
|
Ready for human review at CI is green, including coverage, integration, docs, size, compatibility, and Android/iOS/macOS/Linux smoke tests. GitHub reports The requested two-hour babysitting is complete; monitoring is being stopped for handoff. This PR remains open for human review and merge. External backend restoration remains outside this repository’s live evidence, as documented in the PR. |
|
At 05ceb7b, the earlier parser finding is fixed: baseline names retain their original spacing, and the updated assertions detect the previous trimming behavior. I found no further code issues. No conflicts are known. The name preservation thread is fixed by the parser and comparison changes. The help text thread is fixed by the corrected baseline option. The integer validation thread can be resolved because the existing positive-integer check matches the contract and no version branching requires a safe-integer restriction. Smoke Tests are still running, with no failure log available to attribute. Before merge, wait for the current run to finish and, if it fails, inspect and attribute the exact failing step. I did not rerun tests or inspect an external backend; live restoration evidence remains absent. |
Summary
Proxy leases can request a saved device state with
--device-baseline <name>(deviceBaselinein the SDK/MCP). The backend reports the restored baseline aslease.device.baseline: {name, version}. New grants missing the requested name are released and refused; reused leases must match their original request.Names retain their exact spelling, including surrounding whitespace. Blank names select nothing; invalid types fail. Plain daemons refuse named device specifications. CLI/config defaults, help, and contract docs cover the field. Changes span 21 files with no scope expansion.
Closes #4235. Backend counterpart: callstackincubator/simlock#1308.
Validation
At
05ceb7b64cdafd3308f84078a7a0001cf79a06f6,pnpm check:affected --run --head 05ceb7b64cdafd3308f84078a7a0001cf79a06f6 --jsonpassed all 42 runnable checks; receipt reportsexactCommit: true.Receipt, regression results, and review evidence: unit 19,182 passed / 3 skipped; provider integration 260 passed. Identical regression command:
588983c837has 2 failures / 18 passes; head passes all 20. Independent review found no regressions.Rebased onto
2deb909ec8; range-diff preserves the original feature. CI is green at this head, including coverage, integration, docs, size, compatibility, and Android/iOS/macOS/Linux smoke tests. GitHub reports a clean merge state. All review threads are resolved. No native behavior changed. External backend restoration has not been live-tested.