Skip to content

feat(daemon): scope iOS simulator requests to AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET - #3485

Merged
thymikee merged 5 commits into
mainfrom
feat/daemon-ios-simulator-device-set
Oct 14, 2026
Merged

thymikee merged 5 commits into
mainfrom
feat/daemon-ios-simulator-device-set

Conversation

@V3RON

@V3RON V3RON commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A supervisor starting the daemon (e.g. Simlock, which keeps its own simulator set) could not tell it "use this simulator set for every request": the set came only per request, from --ios-simulator-device-set or the config key. The AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET env var used to cover this and was removed in #560.

The daemon now reads AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET from its own environment:

  • a request that names no set (device listing, target resolution, open, test shards) uses that set;
  • a request naming another set fails with INVALID_ARGS, details.reason: "ios_simulator_device_set_outside_daemon_set"; naming the same set works;
  • without the variable, behavior is unchanged. The macOS host target stays visible.
AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=/path/to/set agent-device devices --platform ios

8 files: one resolver, its three request-side callers, tests, docs.

Validation

Live run at head bff2f9f (main 562e798 merged in). I used the built CLI and a daemon with its own state dir, started with AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET pointing at a private set that held one booted iOS 26.2 simulator. Commands after the first one ran without the variable in the CLI's environment.

  • devices --platform ios listed only the private set's simulator.
  • devices --platform macos --ios-simulator-device-set /other and plain devices both listed the host Mac (host-macos-local), with no INVALID_ARGS.
  • open com.apple.Preferences --platform ios with no set flag returned ios_simulator_device_set: "<private set>".
  • devices --platform ios --ios-simulator-device-set /other returned INVALID_ARGS, details.reason: "ios_simulator_device_set_outside_daemon_set".

Commands and output are in #3485 (comment).

Gates at bff2f9f: the targeted device.test.ts and dispatch-resolve.test.ts passed, and so did the daemon session-lifecycle and daemon-port tests (134 tests). pnpm typecheck, pnpm format and pnpm lint passed. The unit tests cover the default, the same-set case, the refusal, and the unset case. The two dispatch-resolve tests fail without the source change. An earlier run at a9d1699 also checked the old path: without the variable, the default set listed and --ios-simulator-device-set still scoped the listing.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.22 MB 5.22 MB +405 B
Package (unpacked) 5.22 MB 5.22 MB +405 B
Package (download) 1.57 MB 1.57 MB +154 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.2 ms 26.5 ms +0.3 ms
CLI --help 77.6 ms 78.9 ms +1.3 ms

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-14 15:43 UTC

@thymikee

Copy link
Copy Markdown
Member

PR #3485 at a9d1699 has one defect that must be fixed before merge, and the Coverage check failure comes from this diff.

resolveRequestIosSimulatorDeviceSetPath in device-isolation.ts compares the requested set with the operator set and throws before resolveAppleSimulatorSetPathForSelector (device.ts) decides whether a simulator set applies at all. The three call sites (dispatch-resolve.ts:213, inventory.ts:216, session-test-shard-devices.ts:103) wrap that throw inside the selector call. So --platform macos, --target desktop or --platform android with a different iosSimulatorDeviceSet now gets INVALID_ARGS ios_simulator_device_set_outside_daemon_set. The set can come from a flag or from a remote profile (proxy-profile.ts:39, connection-runtime.ts:978). At base, these platforms ignored that set. On an env-scoped daemon, macOS and Android requests now fail over a set they never use. This breaks the rule that simulator-set scoping must never hide the host macOS target, and the PR body's claim that the host Mac stays visible. The rule to satisfy is that the operator set constrains a request only where a simulator set applies to it, and one owner builds every request-side inventory. Please add that owner in packages/kernel/src/device.ts, next to resolveAppleSimulatorSetPathForSelector. It takes the requested set, platform, target and env. It runs the macOS/desktop drop first, then applies the operator default or the refusal. Then replace the three composed calls with it, and add a test where an env-scoped daemon serves --platform macos --ios-simulator-device-set /other, lists the host Mac and throws no refusal.

Could resolveRequestIosSimulatorDeviceSetPath be deleted, with that one function in device.ts doing the drop, the default and the refusal in order? device.ts already imports errors.ts, so nothing has to change first. Each call site would then make one call, and device-isolation.ts would stay a leaf again.

The Coverage failure is likely caused by this PR. scripts/__tests__/eager-closure-budgets.test.ts reports that device-isolation.ts now evaluates 3 modules instead of 1, through errors.ts and redaction.ts. That comes from the new AppError import at device-isolation.ts:2, and moving the rule into device.ts clears it. I did not run that test locally. The attribution comes from the CI log naming the new import route.

Not blocking, and you can take or leave these: the new tests stub process.env globally, while the sibling resolveAndroidSerialAllowlist takes an injectable env, and no test covers macOS or Android with the variable set. Also, when iosSimulatorSetPath is set, inventory.ts:39-45 skips physical Apple devices, so with the env var every request carries a set and physical iPhones disappear on that daemon. The CLI's auto-spawned daemon inherits the CLI's environment, so a later CLI with a different value is silently served the first one. session-selector.ts:80 compares trimmed strings while the new resolver compares path.resolve() results, so /set/ passes the resolver and then mismatches an existing session. Please document both in commands.md and configuration.md, and normalize the returned path the way the session selector compares it.

I did not rerun the live validation, so the PR body is the only evidence that the built daemon scopes listing and open. I also did not check whether a config-file layer outside the remote profile injects iosSimulatorDeviceSet for non-iOS commands. After the fix, please run a daemon started with AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=<private set> and show three results. First, devices --platform ios lists only that set's simulators. Second, devices --platform macos --ios-simulator-device-set /other and plain devices both list the host Mac with no INVALID_ARGS. Third, open <app> --platform ios with no set flag uses a simulator from the private set, shown by the ios_simulator_device_set field in the open response. Before merge, the operator-set rule needs to move into device.ts after the macOS/desktop check, which fixes both the defect and the Coverage failure, and that live run needs to pass.

* origin/main: (79 commits)
  feat(ios): interpret React Native accessibility value semantics (#3589)
  fix(android): reinstall and reselect the test IME helper after it disappears (#3606)
  feat(snapshot): carry provider keyboard observations through acquisition (#3593)
  chore(web): bump managed agent-browser backend to 0.39.0 (#3591)
  fix(fold): report a dispatched pose as unverified when devicectl has no hinge-angle stream (#3587)
  feat(android): expose system-bar membership on snapshot nodes (#3585)
  fix(android): align ADB and Appium field values (#3584)
  test(closure): read committed JSON modules on the merge-base side (#3602)
  fix(ci): preserve manual Android suite timing (#3554)
  refactor(daemon): make the layer folders the declaration (PR 10) (#3520)
  refactor(move): extract the daemon server into @agent-device/daemon (11b) (#3546)
  refactor(daemon): package-local runtime fakes for the remaining daemon ports [11a-4] (#3544)
  refactor(daemon): cut daemon test edges into root data fixtures and fakes [11a-3] (#3517)
  refactor(11a-2): package-local fakes at the daemon ports; root-own command-surface composition tests (#3519)
  test(replay): verify Settings queries and bound scrolling (#3560)
  feat(snapshot): measure Android Appium viewport (#3586)
  fix(ios): verify a fill whose unidentified field moved while it kept focus (#3596)
  refactor(coverage): one fallow config with per-function CRAP ceilings (#3588)
  test: bound CLI promotion cases and align provider budget (#3590)
  fix(metro): report what the dev-server stop proved instead of assuming success (#3575)
  ...
…set applies

Move the AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET rule into one kernel owner,
resolveRequestAppleSimulatorSetPath in device.ts, which drops macOS and
desktop selectors first, leaves non-simulator platforms alone, then applies
the operator default or the refusal. Each inventory call site makes one call,
device-isolation.ts is a leaf again, and the env is injectable for tests.
The refusal compares trimmed path strings the way the session selector does.
Document that physical iOS devices are hidden and that a CLI-spawned daemon
keeps the first value.
@thymikee

Copy link
Copy Markdown
Member

New head: ddf9352. Main is merged in (clean merge).

  • Fixed: the operator-set rule now lives in one function, resolveRequestAppleSimulatorSetPath in packages/kernel/src/device.ts. It drops macOS and desktop selectors first, leaves Android and other non-simulator platforms alone, and only then applies the operator default or the refusal. resolveRequestIosSimulatorDeviceSetPath is deleted and the three call sites make one call each.
  • Fixed: device-isolation.ts is a leaf again (no AppError or path import), so the eager-closure budget holds.
  • Fixed: new test where a daemon scoped by the env var serves --platform macos and --platform android with --ios-simulator-device-set /tmp/other-set, returns the host Mac and the emulator, and throws no refusal.
  • Fixed: the new function takes an injectable env, like resolveAndroidSerialAllowlist. The kernel tests use it instead of stubbing process.env, and they cover macOS, desktop and Android with the variable set.
  • Fixed: the refusal now compares trimmed path strings, the same way the session selector does, so /set/ is refused with a hint to pass the exact path instead of passing here and then failing to match an existing session.
  • Fixed: commands.md and configuration.md now say that iOS physical devices are not listed on a scoped daemon, that macOS and non-iOS requests ignore the set, and that a daemon the CLI starts keeps the first CLI's value until it restarts.
  • Still open: the live run of a daemon started with AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET (scoped devices --platform ios, host Mac on devices --platform macos --ios-simulator-device-set /other and on plain devices, and open using the private set). I did not run it here.

Checks: pnpm typecheck, pnpm lint, pnpm format (only PR files changed), pnpm check:layering, and vitest for src/core/__tests__/device.test.ts, packages/device-selection/src/__tests__/dispatch-resolve.test.ts, scripts/__tests__/eager-closure-budgets.test.ts and the session-inventory scoped-paths and appleos tests. All pass.

@thymikee

Copy link
Copy Markdown
Member

Thanks for the update. The resolver move since a9d1699 looks good, but I still can't call this ready at ddf9352 because no device run covers the changed path.

The live run in the PR body was done at a9d1699, before the resolver moved, and the refusal now lives in packages/kernel/src/device.ts. Today only unit tests with inventory fakes show that the built daemon scopes listing and open and keeps the host Mac visible. Please start the built daemon with AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET= and show four results. First, devices --platform ios lists only that set's simulators. Second, devices --platform macos --ios-simulator-device-set /other and plain devices both list the host Mac with no INVALID_ARGS. Third, open <app> --platform ios with no set flag reports the private set in the ios_simulator_device_set field. Fourth, devices --platform ios --ios-simulator-device-set /other returns details.reason ios_simulator_device_set_outside_daemon_set.

The earlier Coverage failure (eager-closure budget from the new AppError import in device-isolation.ts) should be gone, because that file is no longer in the diff and device.ts already imported errors.ts. I inferred this from the diff and have not seen it in a CI log. I ran no tests myself.

All 19 CI lanes are queued after the main merge and none has failed yet. Coverage still overlaps this diff through the kernel and device-selection tests, so please read its result once it runs. Before merge, the live run at ddf9352 is needed and CI should be green.

* origin/main:
  feat(leasing): proxy CLI names each new lease, daemon keeps a caller-chosen lease id (#3479)
  feat(remote): name the held lease on upload, artifact download and diagnostics requests (#3594)
  fix(android): record the launched intent owner from the device (#3600)
  fix(selectors): type rect-requiring targets as addressable (#3608)
  feat(snapshot): interpret iOS node facts once at producer seams (#3592)
  refactor(gates): own the client-only replay rule as daemon-process reachability (R82) (#3604)
@thymikee

Copy link
Copy Markdown
Member

New head is bff2f9f. Main is merged in (origin/main 562e798).

I ran the live check at bff2f9f, using the CLI built from that commit (bin/agent-device.mjs). The daemon had its own state dir and AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=/private/tmp/claude-501/pr-3485-sims. That private set held one booted iPhone 16 simulator on iOS 26.2 (22E43289-…). The first command started the daemon with the variable set. Commands 2 to 4 ran from a CLI without the variable, so the daemon's own environment supplied the set.

1. devices --platform ios lists only the private set

AGENT_DEVICE_STATE_DIR=$STATE AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=/private/tmp/claude-501/pr-3485-sims \
  agent-device devices --platform ios --json
{"success": true, "data": {"devices": [
  {"platform": "ios", "id": "22E43289-32F6-47BD-A3F3-097BDD804DD3", "name": "PR3485 iPhone",
   "kind": "simulator", "osVersion": "26.2", "booted": true}]}}

2. The host Mac stays visible

agent-device devices --platform macos --ios-simulator-device-set /private/tmp/claude-501/pr-3485-other --json
{"success": true, "data": {"devices": [
  {"platform": "macos", "id": "host-macos-local", "kind": "device", "target": "desktop", "booted": true}]}}

agent-device devices --json returned success: true. It listed macos device desktop host-macos-local and, for iOS, only PR3485 iPhone. It also listed the host's Android emulators; none was used. No INVALID_ARGS.

3. open with no set flag reports the private set

agent-device open com.apple.Preferences --platform ios --session pr3485 --json
"selection": {"reason": "single-booted-local", "candidateCount": 1, "bootOccurred": false},
"device_udid": "22E43289-32F6-47BD-A3F3-097BDD804DD3",
"ios_simulator_device_set": "/private/tmp/claude-501/pr-3485-sims",
"message": "Opened: com.apple.Preferences"

4. Another set is refused

agent-device devices --platform ios --ios-simulator-device-set /private/tmp/claude-501/pr-3485-other --json
{"success": false, "error": {"code": "INVALID_ARGS",
  "message": "This daemon only reaches iOS simulators in the set \"/private/tmp/claude-501/pr-3485-sims\" (AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET), but the request named --ios-simulator-device-set \"/private/tmp/claude-501/pr-3485-other\".",
  "details": {"reason": "ios_simulator_device_set_outside_daemon_set"}}}

(exit 1)

After the run I closed the session, stopped the daemon with daemon stop --clean, and shut down and deleted the private simulator.

Checks at bff2f9f:

  • src/core/__tests__/device.test.ts and packages/device-selection/src/__tests__/dispatch-resolve.test.ts: 58 tests passed.
  • The same two files plus the daemon session-lifecycle and daemon-port tests: 134 tests passed.
  • pnpm typecheck, pnpm format (no changes) and pnpm lint passed.

@thymikee

Copy link
Copy Markdown
Member

Thanks for the update. The code looks right at bff2f9f, and the earlier evidence gap is closed by the live device outputs you posted at bff2f9f. I did not rerun the live device check, and I ran no tests locally, so that evidence is yours. CI is still running, with no failed lane: Smoke Tests are queued, and Analyze and Compatibility & Provenance are in progress. Smoke Tests cover iOS device selection, so they matter here. The smoke runners do not set the env var, so they should only confirm that the no-operator-set path keeps base behavior. This needs green CI at bff2f9f, and then the PR needs to come out of draft before merge. One question, and it is not blocking: the repo already has an owner for env-driven device scoping in packages/kernel/src/device-isolation.ts, where resolveAndroidSerialAllowlist reads AGENT_DEVICE_ANDROID_DEVICE_ALLOWLIST. After this change, resolveIosSimulatorDeviceSetPath is a trim-only helper that only simctl.ts uses, and the new env read and refusal sit in kernel/device.ts. Should the operator-set read and the refusal move into device-isolation.ts, for example as resolveIosSimulatorDeviceSetPath(flagValue, env)? device.ts would then keep only the macOS/desktop and simulator-capable platform gate, and both device-scoping env vars would live in one module.

* origin/main:
  fix(daemon): end the session and clear its claim when its lease ends (#3480)
@thymikee

Copy link
Copy Markdown
Member

New head is fc10741. Main is merged in.

I did not move the env read into device-isolation.ts. I tried it, and the eager-closure budget test (scripts/__tests__/eager-closure-budgets.test.ts) fails. device.ts is evaluated by about 126 entries. Importing device-isolation.ts from it makes that module newly evaluated by all of them (+1 each). This happens even with an env-read-only helper that has no AppError import, so the cost comes from the new edge, not from the errors dependency. The only ways around it are an allowlist or baseline bump, or moving resolveRequestAppleSimulatorSetPath out of kernel/device. I did neither.

So the env read and the ios_simulator_device_set_outside_daemon_set refusal stay in kernel/device.ts. If you want both device-scoping env vars in one module, the cleaner route is a follow-up that moves the whole function and its import sites, with a deliberate closure-budget decision.

Gates run on this head:

  • eager-closure-budgets, src/core/__tests__/device.test.ts and dispatch-resolve.test.ts pass.
  • pnpm typecheck, pnpm lint, pnpm format and pnpm check:layering pass.
  • I did not run the full suite, and I did not rerun devices. This push only merges main, and the live run at bff2f9f covers the behavior.

@thymikee
thymikee marked this pull request as ready for review October 14, 2026 15:24

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="website/docs/docs/commands.md">

<violation number="1" location="website/docs/docs/commands.md:200">
P3: The “other non-iOS requests ignore the set” clause is incorrect for `--platform apple --target tv`: Apple simulator requests use the daemon set, while only macOS desktop requests bypass it. Update this wording in both documentation pages.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

- If the selected Xcode can't resolve a scoped simulator for the Apple runner, the runner start fails with `details.reason: "simulator_set_destination_not_found"`, naming the set and, when known, the Xcode version.
- `--android-device-allowlist <serials>` limits Android discovery and selection to comma- or space-separated serials.
- Set the same scopes with the `iosSimulatorDeviceSet` and `androidDeviceAllowlist` config keys, or `AGENT_DEVICE_ANDROID_DEVICE_ALLOWLIST`. CLI flags override environment values, except under a `strip` session lock, which ignores conflicting per-call selectors.
- Start the daemon with `AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=<path>` to scope every iOS simulator request to one simulator set. A request without `--ios-simulator-device-set` uses that set, so iOS physical devices are not listed on that daemon. A request naming a different path string, including the same path with a trailing slash, fails with `INVALID_ARGS` and `details.reason: "ios_simulator_device_set_outside_daemon_set"`. macOS and other non-iOS requests ignore the set, and the host Mac stays listed. A daemon that the CLI starts inherits the CLI's environment, so later CLI calls with a different value still use the first value until the daemon restarts.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The “other non-iOS requests ignore the set” clause is incorrect for --platform apple --target tv: Apple simulator requests use the daemon set, while only macOS desktop requests bypass it. Update this wording in both documentation pages.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At website/docs/docs/commands.md, line 200:

<comment>The “other non-iOS requests ignore the set” clause is incorrect for `--platform apple --target tv`: Apple simulator requests use the daemon set, while only macOS desktop requests bypass it. Update this wording in both documentation pages.</comment>

<file context>
@@ -197,6 +197,7 @@ agent-device devices --platform android --android-device-allowlist emulator-5554
 - If the selected Xcode can't resolve a scoped simulator for the Apple runner, the runner start fails with `details.reason: "simulator_set_destination_not_found"`, naming the set and, when known, the Xcode version.
 - `--android-device-allowlist <serials>` limits Android discovery and selection to comma- or space-separated serials.
 - Set the same scopes with the `iosSimulatorDeviceSet` and `androidDeviceAllowlist` config keys, or `AGENT_DEVICE_ANDROID_DEVICE_ALLOWLIST`. CLI flags override environment values, except under a `strip` session lock, which ignores conflicting per-call selectors.
+- Start the daemon with `AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=<path>` to scope every iOS simulator request to one simulator set. A request without `--ios-simulator-device-set` uses that set, so iOS physical devices are not listed on that daemon. A request naming a different path string, including the same path with a trailing slash, fails with `INVALID_ARGS` and `details.reason: "ios_simulator_device_set_outside_daemon_set"`. macOS and other non-iOS requests ignore the set, and the host Mac stays listed. A daemon that the CLI starts inherits the CLI's environment, so later CLI calls with a different value still use the first value until the daemon restarts.
 - Scope applies before `--device`, `--udid`, and `--serial`, so an out-of-scope selector fails with `DEVICE_NOT_FOUND`.
 - On macOS, daemon startup removes any symlink at `~/Library/Developer/XCTestDevices`, including one you made yourself (for example to move it to another volume), and restores `XCTestDevices.agent-device-backup` when it exists. A symlinked `XCTestDevices` is not supported. Only the link is removed, never the directory it points to; `daemon.log` records each step and any failed restore, which doesn't stop the daemon.
</file context>
Suggested change
- Start the daemon with `AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=<path>` to scope every iOS simulator request to one simulator set. A request without `--ios-simulator-device-set` uses that set, so iOS physical devices are not listed on that daemon. A request naming a different path string, including the same path with a trailing slash, fails with `INVALID_ARGS` and `details.reason: "ios_simulator_device_set_outside_daemon_set"`. macOS and other non-iOS requests ignore the set, and the host Mac stays listed. A daemon that the CLI starts inherits the CLI's environment, so later CLI calls with a different value still use the first value until the daemon restarts.
- Start the daemon with `AGENT_DEVICE_IOS_SIMULATOR_DEVICE_SET=<path>` to scope every Apple simulator request to one simulator set. A request without `--ios-simulator-device-set` uses that set, so iOS physical devices are not listed on that daemon. A request naming a different path string, including the same path with a trailing slash, fails with `INVALID_ARGS` and `details.reason: "ios_simulator_device_set_outside_daemon_set"`. macOS requests and other non-Apple requests ignore the set, and the host Mac stays listed. A daemon that the CLI starts inherits the CLI's environment, so later CLI calls with a different value still use the first value until the daemon restarts.

@thymikee

Copy link
Copy Markdown
Member

This PR is ready. I reviewed fc10741 and found no code problems. The earlier review (#3485 (comment)) was waiting on evidence, and that evidence is now in. The live device check outputs from bff2f9f still apply, because the logical patch is unchanged. I did not rerun that check, and I did not run any tests myself.

Not blocking: the docs say macOS and other non-iOS requests ignore the set, but at website/docs/docs/commands.md:200 the code applies the set to every Apple simulator request, so --platform apple --target tv and a bare devices are scoped too. The same wording is in configuration.md. You could reword both to say the set applies to every Apple simulator request (--platform ios|apple, or no platform, with target mobile or tv), and that --platform macos, --target desktop and non-Apple platforms ignore it. Take it or leave it.

Open threads: the Cubic P3 thread on this docs wording still applies and is covered by the note above: #3485 (comment)

CI is still pending. 17 lanes are queued or running and none have failed. Coverage, Integration, Typecheck and Repo Guards overlap this diff. Smoke Tests run iOS selection without the env var, so they check that the path without the set is unchanged. Next, CI needs to be green on fc10741, with Coverage and Smoke Tests read once they run.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 14, 2026
@thymikee
thymikee merged commit ff3947c into main Oct 14, 2026
22 checks passed
@thymikee
thymikee deleted the feat/daemon-ios-simulator-device-set branch October 14, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants