Skip to content

alert wait: honour windows longer than the 90 s request envelope #4566

Open

Description

@thymikee

Purpose

alert wait <timeoutMs> accepts windows up to MAX_ALERT_WINDOW_MS, but the alert command uses the default timeout policy: a fixed 90 s daemon request envelope (DAEMON_REQUEST_TIMEOUT_MS in packages/command-registry/src/timeout-policy.ts). A wait longer than 90 s is cut off by that envelope as a generic request timeout, instead of polling for the full window and ending with alert-wait-timeout. Found while working on #4540 (see its reply on the timeout-policy test thread).

Required behavior

  • alert wait with a window above 90 s polls for the whole window. The daemon request envelope stays above the window plus a margin, as other commands with a caller budget do.
  • alert get keeps its current fixed envelope, which already sits above the runner's 25 s cap (fix(ios): use the caller's budget for alert get and type the watchdog outcome #4540).
  • A window that can't be honoured is refused up front with a typed reason, never cut off mid-wait.

Completion

  • A timeout-policy test showing the alert wait envelope scales with the requested window, and a test that alert get keeps its fixed envelope.
  • alert help states the longest supported wait.

Related: #4540, #4523.

Activity

  1. apex-sentinel-staging commented on Nov 15, 2026

    @apex-sentinel-staging

    Apex Sentinel · Issue review

    Suggested label: bug

    The issue reports that alert wait accepts windows longer than 90 seconds but the fixed daemon request envelope cuts the wait off as a generic timeout. It specifies the expected envelope scaling behavior and required tests, so a maintainer can act on it directly.

    Required sections

    • Steps to reproduce (missing)
    • Expected and actual behavior (missing)
    • Version or environment (missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions