Draft
Conversation
Member
Author
|
@abachant nice work figuring out the sizing and positioning issue! |
Collaborator
|
@petebachant I ended up going down such a rabbit hole trying to use a ref hook to access PdfLoader to adjust the position and then a mutationObserver to try to get the lifecycle right only to find out it specifically won't load if the position isn't absolute then to just need to surround it in a div to fix the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
Fix sizing and positioning
Adding a highlight should post a comment to the API, which should post a GitHub issue with a
publicationslabel, quoting the text (PRs can come later)We should be able to make generic comments not from highlights, which do similar to above
Resolves I can comment on a publication, suggesting changes that can easily be incorporated #70
Resolves I want to be able to easily annotate LaTeX PDFs as GitHub issues and produce suggested edits as PRs #389
Towards I want to be able to easily collaborate on a LaTeX document without working separately from my other project files #388
In the future, this could potentially be used for peer review. Journals could host their own instances. They could then become archivists for code and data.