Repository navigation
CI rehearsal only (do not merge) - #26
Open
michael-moffett wants to merge 9 commits into
Open
michael-moffett wants to merge 9 commits into
michael-moffett wants to merge 9 commits into
Conversation
`ExactVerifier.verify` refuses a transaction whose required signers include anyone other than the fee payer and the transfer authority. scheme_exact_svm.md §2.1.4: "The transaction MUST NOT require any signatures beyond the client and the sponsor (feePayer)." Rust refuses this transaction and Python accepts it (FINDINGS.md#x402-extra-required-signer-accepted).
 [Medium impact] No code issues block merging, but the author explicitly requested that this rehearsal PR not be merged. SummaryThe Python x402 exact verifier now rejects required signers other than the fee payer and transfer authority.
No actionable issues were found. Tests were not run. michael-moffett marked this PR “Fork CI only. Do not merge.” That stated intent is separate from the code assessment. Reviews (1) · Last reviewed commit: "greptile.json: review on request only" · Reviewed by Greptile |
`ExactVerifier.verify` refuses a transaction whose required signers include anyone other than the fee payer and the transfer authority. scheme_exact_svm.md §2.1.4: "The transaction MUST NOT require any signatures beyond the client and the sponsor (feePayer)." Rust refuses this transaction and Python accepts it (FINDINGS.md#x402-extra-required-signer-accepted).
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CI only. Do not merge.