Skip to content

CI rehearsal only (do not merge) - #20

Closed
michael-moffett wants to merge 8 commits into
mainfrom
pay-kit-166-php-gate-accepts-a1-next
Closed

michael-moffett wants to merge 8 commits into
mainfrom
pay-kit-166-php-gate-accepts-a1-next

Conversation

@michael-moffett

Copy link
Copy Markdown
Member

Fork CI only. Do not merge.

michael-moffett and others added 2 commits October 5, 2026 14:43
Add `Gate::accepts(Protocol $p): bool` to the PHP SDK. This is the PHP `Gate::accepts` item from issue .

The spec (`docs/paykit-interface.md:154-158`) names `accepts(protocol)` as a Gate method in every SDK, and PHP does not have it.
@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Adds protocol acceptance logic to the payment gate.

No blocking code issue was identified, but this CI rehearsal is explicitly marked do not merge.

Summary

The PR adds PHP gate protocol admission checks that can use the client configuration, routes middleware selection through those checks, adds coverage for inherited protocol limits, and updates the interface and review configuration.

  • Fee-bearing gates now exclude X402 during credential selection as well as challenge construction.
  • The PR is labeled a CI rehearsal and explicitly marked do not merge.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Request and gate] --> B[Gate accept list or client config]
  B --> C{Gate accepts protocol?}
  C -- No --> D[Skip adapter]
  C -- Yes --> E{Matching credential?}
  E -- Yes --> F[Verify and settle]
  E -- No --> G[Build 402 challenge]
Loading

Reviews (4) · Last reviewed commit: "greptile.json: review on request only" · Reviewed by Greptile

Comment thread php/src/Gate.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant