fix(controllers): watch pods in RC and fall back to selector labels in RS#44
Open
indyjonesnl wants to merge 1 commit into
Open
fix(controllers): watch pods in RC and fall back to selector labels in RS#44indyjonesnl wants to merge 1 commit into
indyjonesnl wants to merge 1 commit into
Conversation
…n RS ReplicationController only watched its own resource, so pod status flips (Pending->Running, Ready condition) had to wait up to 30s for the periodic resync before status.readyReplicas updated — long enough to trip conformance "should serve a basic image" timeouts. Add a pod watch that enqueues the owning RC on any pod event, and shorten the safety resync to 5s to match the ReplicaSet controller. Also make the ReplicaSet controller fall back to spec.selector.matchLabels when the pod template has no labels. Without the fallback, created pods had no labels, matches_selector returned false for them, and the controller created replicas every cycle. RC already had this defensive fallback; bring RS in line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two controller reaction-latency bugs surfaced by conformance:
Fix
Verification
`cargo build --workspace --locked` clean. Depends on #32 for green CI.