feat(Explainer): graceful enter/exit transitions for scene text#95
Open
xiangboit wants to merge 1 commit into
Open
feat(Explainer): graceful enter/exit transitions for scene text#95xiangboit wants to merge 1 commit into
xiangboit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
SceneTextTransitionwrapper so every scene's text/component gets a graceful enter and exit animation (fade + slide + subtle scale), instead of popping in and vanishing abruptly at cut boundaries.Why
Currently scene components have entrance springs but no exit — text snaps in, then disappears instantly when the next cut starts. On real explainer videos this reads as jarring, especially between back-to-back text scenes.
How
SceneTextTransitioncomponent drivesopacity(0→1→1→0),translateY(slide up on enter / drift up on exit) andscale(0.88→1→1.08) from the cut's own duration, with clamped interpolation.SceneRenderer.maybeWrapWithBgnow wraps inner content inSceneTextTransitionbefore the background layer — only the text/component layer animates;backgroundVideo/backgroundImagestay steady.fadeIn ≈ duration*0.26, exit starts ~22 frames before end), so short and long cuts both transition cleanly.Scope / Safety
cutsprops untouched.maybeWrapWithBg.Happy to gate this behind a prop (e.g.
cut.transition: "none") if you'd prefer opt-in rather than default-on.