feat(analysis): add visual timing QA#73
Open
RayJiang4S wants to merge 9 commits into
Open
Conversation
Add conservative rule-based checks to visual_timing_qa review output so obvious timing and subtitle risks are surfaced before human review.
Add a reviewer-friendly HTML review surface with per-cue image navigation, filters, inline decisions, copied review payloads, and machine-readable action items for downstream video adjustment workflows.
Author
|
Follow-up update for the Visual Timing QA review workflow. This update turns the generated HTML from a passive contact-sheet artifact into an actionable reviewer surface:
The intended production loop is:
Validated locally with: python -m pytest tests/tools/test_visual_timing_qa.py -qResult: |
Add machine-readable completion state for visual timing annotations so review rounds can continue until every cue passes. Honor unreviewed_policy=PASS submissions from the interactive review page and document the rerender/review loop.
Author
Add process and node-flow review prompts plus initial-review heuristics so visual timing QA can flag states that may complete before narration reaches the cue.
Author
|
Updated this branch with the early-complete timing QA follow-up from the latest promo review. What changed:
Validation:
|
Add agent-facing review routing, stale visual-state checks, and contact sheet lightbox navigation for visual timing QA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
visual_timing_qa, a post-render helper for cue-based visual timing reviewsuggest_cues,dry_run,review, andannotateoperationsNotes
This is intentionally human-in-the-loop. It does not call an external vision model or make automatic creative approvals; it organizes cue windows so reviewers can verify whether key visual states match narration.
Test Plan
.venv/bin/python -m pytest tests/tools/test_visual_timing_qa.py -q.venv/bin/python -m py_compile tools/analysis/visual_timing_qa.py tests/tools/test_visual_timing_qa.py