fix(tools): lazy-import numpy in green_screen_composite#101
Open
johan-studioe wants to merge 1 commit into
Open
fix(tools): lazy-import numpy in green_screen_composite#101johan-studioe wants to merge 1 commit into
johan-studioe wants to merge 1 commit into
Conversation
The module-level `import numpy as np` made registry.discover() crash on any machine without numpy installed — even though the tool already declares numpy as an optional dependency (and every other numpy-using tool in the repo lazy-imports it inside methods). Move the import into _parse_hex_color and _composite_frame to match the rest of the codebase. Type annotations stay valid via the existing `from __future__ import annotations`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module-level
import numpy as npmade registry.discover() crash onany machine without numpy installed — even though the tool already
declares numpy as an optional dependency (and every other numpy-using
tool in the repo lazy-imports it inside methods).
Move the import into _parse_hex_color and _composite_frame to match the
rest of the codebase. Type annotations stay valid via the existing
from __future__ import annotations.Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com