Option to omit transfer on the same storage volume#12
Open
hUwUtao wants to merge 1 commit intocalagopus:mainfrom
Open
Option to omit transfer on the same storage volume#12hUwUtao wants to merge 1 commit intocalagopus:mainfrom
hUwUtao wants to merge 1 commit intocalagopus:mainfrom
Conversation
Member
|
Hello! Thank you for making a PR, however I would approach this with the panel-first approach of Calagopus, aka a simple bool in the request body that tells wings whether to do any archiving logic or not, but then, the endpoint isnt really needed at all so in the best case we add a new endpoint that allows wings to forget a server without deleting files/backups, then the panel simply calls that and creates the server on the destination with installer etc turned off, that avoids the trouble and is more versatile because you can also use it if you manually want to transfer server files without using the default system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm building a system which use synchronized storage. TLDR: This option omit moving files when ensures both wings are operate on the same volume.
Pelican Wings PR: pelican-dev/wings#147