feat: two-screen layout redesign with log viewer, resources panel, and bug fixes by alefisico · Pull Request #47 · cademirch/snkmt

alefisico · 2026-05-13T21:03:15Z

Layout:

Replaced the single-screen layout (large workflow list + three cramped right panels) with a two-screen approach: a full-width workflow list as the default view, pushing a detail screen on selection. Esc returns to the list.

The detail screen has a left panel (rules drill-down → jobs) and a right tabbed panel (Overview / Logs / Resources / Errors).

New features:

Log viewer in the Logs tab shows file content directly when a job is selected; a file selector appears only when a job has multiple log files
Resources panel shows threads, duration, resource usage, shell command, and wildcards for the selected job
Progress display shows percentage only (colour-coded by completion level)

Bug fixes:

list_rule_jobs and get_job now eagerly load job.files via selectinload to prevent MissingGreenlet errors when accessing file relationships outside the async session context

Strip overview.py to a list-only WorkflowListView that posts a WorkflowSelected message on row activation; update DashboardScreen in app.py to use the new widget and handle navigation to detail screen. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…sh method Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Replace StyledProgress percentage strings with render_progress_bar(), which renders coloured block-character bars (e.g. █████░░░░░ 50%) in all tables and the workflow detail overview. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Remove unused AppBody class from app.py, fix missing return/parameter type annotations in widgets.py and app.py, and fix wrong type annotation and missing status arg in views/detail.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Logs tab now shows file content immediately on job select; file selector appears only when job has multiple log files - Progress display shows percentage only, no visual bar - Add ShellCmdHandler to logger plugin (patched in dev env) to capture shell commands from Snakemake's SHELLCMD event Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cademirch

Thanks for the PR. Gave a quick look through and left some comments. I'll try to get around to testing this out locally soon.

cademirch · 2026-05-13T21:25:59Z

These don't seem to be testing anything meaningful. Can we drop these?

cademirch · 2026-05-13T21:28:20Z

+            )
+
+
+class ResourcesPanel(Container):


This is just the resources requested by the job - which is all we have until we either parse benchmark files or wait for Snakemake to send benchmark info thru the logger interface. I think this should be more clear that this was resources requested by the job and not resources used.

ok, I will make it clear that these are resources requested

cademirch · 2026-05-13T21:32:27Z

+        except NoMatches:
+            pass
+
+        log_widget = Log(id="log-content", highlight=False)


I need to test this out, but I think I prefer the log file modal here, since it has more screen real estate there is less line wrapping. Is there a reason the log file modal was replaced with textual Log?

I think it is a matter of taste, I personally prefer this way. But maybe I can keep both views if you want

cademirch · 2026-05-13T21:37:03Z

 [tool.pixi.feature.dev.pypi-dependencies]
 snkmt = { path = ".", editable = true }
-snakemake-logger-plugin-snkmt = { git = "https://github.com/cademirch/snakemake-logger-plugin-snkmt.git", editable = true, branch="dev" }
+snakemake-logger-plugin-snkmt = { git = "https://github.com/alefisico/snakemake-logger-plugin-snkmt.git", editable = true }


Will need to change this. Note to self - this is why I want to move the logger into this repo, get rid of this dev dependency dance.

Releases might be more annoying though.

good catch. Yeah I will revert

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…et removal

cademirch · 2026-05-19T20:19:41Z

Okay, I've had a chance to play around with this. I like the look of the layout, but the UX is a little confusing to me. It is a little clunky to have to select a job to view its logs on the TabViewer. My impression was that the Overview/Logs/Resources/Errors tab panes were for the selected Rule. I think that would be more intuitive. Such that when you select a rule, the tab pane gives you quick access to the overview of that rule and all of the jobs logs, etc. I've had ideas to do this using the Tree widget from textual.

Overall I think this is the right direction and want to use this PR to develop this further. I'll try to make some mock ups of what im thinking when I have a chance.

alefisico · 2026-05-19T21:12:41Z

Sounds good. Yeah, feel free to improve it as you think is best.

…symmetric split

…resources

…_dto

cademirch · 2026-06-11T16:18:40Z

Hi @alefisico - I saw that you pushed some updates to this, sorry I have not had time to take a look yet. I will try to take a look this weekend!

cademirch · 2026-07-01T12:49:22Z

Hi @alefisico sorry for my delay on this. I am on vacation until mid July so I will review this when I get back

alefisico and others added 14 commits May 12, 2026 13:52

fix: clean up unused imports, improve error handling, add force_refre…

f7614bd

…sh method Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: move render_progress_bar import to top of test file

7417b0d

feat: add WorkflowDetailScreen with rules, jobs, resources, logs tabs

1c5f53c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: hoist in-function imports and type _update_logs_tab parameter

6a35d2e

feat: show command_line in workflow overview

bbff47e

style: rewrite CSS for two-screen layout C

7138324

feat: add force-refresh keybind to detail screen

95a4591

fix: eager-load job files in list_rule_jobs to prevent MissingGreenlet

3ab0978

fix: eager-load job files in get_job to prevent MissingGreenlet

008893d

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore: point logger plugin dependency to alefisico fork

37716c8

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cademirch self-requested a review May 13, 2026 21:19

cademirch reviewed May 13, 2026

View reviewed changes

alefisico and others added 5 commits May 14, 2026 12:35

fix: pass TabPane type to query_one to satisfy mypy

415a2b2

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: drop trivial import/signature tests, keep progress bar tests

af95905

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: label resource rows as requested (not actual) usage

ca1db12

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add m keybinding to open current log file in full-screen modal

e546995

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore: revert logger plugin dep to upstream cademirch repo

f7fbaff

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cademirch force-pushed the feature/layout-redesign branch from 4abee05 to 7568c59 Compare May 19, 2026 19:59

fix: eager-load job.files in create_job/update_job and await log widg…

7a23fed

…et removal

cademirch force-pushed the feature/layout-redesign branch from 7568c59 to 7a23fed Compare May 19, 2026 20:01

alefisico added 3 commits May 28, 2026 16:14

feat: redesign workflow detail view to natural top-down layout with a…

65a8821

…symmetric split

fix: clean leading newlines/whitespace in shellcmd and add reason to …

5191dc6

…resources

fix: map command_line field in sql repository create and _workflow_to…

be846fb

…_dto

Navigation Menu

feat: two-screen layout redesign with log viewer, resources panel, and bug fixes - #47

feat: two-screen layout redesign with log viewer, resources panel, and bug fixes#47
alefisico wants to merge 23 commits into
cademirch:mainfrom
alefisico:feature/layout-redesign

alefisico commented May 13, 2026

Uh oh!

cademirch left a comment

Uh oh!

cademirch May 13, 2026

Uh oh!

cademirch May 13, 2026

Uh oh!

alefisico May 14, 2026

Uh oh!

cademirch May 13, 2026

Uh oh!

alefisico May 14, 2026

Uh oh!

cademirch May 13, 2026

Uh oh!

alefisico May 14, 2026

Uh oh!

cademirch commented May 19, 2026

Uh oh!

alefisico commented May 19, 2026

Uh oh!

cademirch commented Jun 11, 2026

Uh oh!

cademirch commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

alefisico commented May 13, 2026

Uh oh!

cademirch left a comment

Choose a reason for hiding this comment

Uh oh!

cademirch May 13, 2026

Choose a reason for hiding this comment

Uh oh!

cademirch May 13, 2026

Choose a reason for hiding this comment

Uh oh!

alefisico May 14, 2026

Choose a reason for hiding this comment

Uh oh!

cademirch May 13, 2026

Choose a reason for hiding this comment

Uh oh!

alefisico May 14, 2026

Choose a reason for hiding this comment

Uh oh!

cademirch May 13, 2026

Choose a reason for hiding this comment

Uh oh!

alefisico May 14, 2026

Choose a reason for hiding this comment

Uh oh!

cademirch commented May 19, 2026

Uh oh!

alefisico commented May 19, 2026

Uh oh!

cademirch commented Jun 11, 2026

Uh oh!

cademirch commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants