Repository navigation
Conversation
Gemma-style BPE vocabularies with byte_fallback emit <0xHH> pieces for codepoints missing from the vocab. The replace_metaspace decode path appended them verbatim, so Korean and Polish output contained literal <0xEA><0xB9><0xB0> instead of the decoded character. Map <0xHH> pieces back to raw bytes when byte_fallback is enabled, as SPTokenizer::decode already does. Fixes cactus-compute#684 Signed-off-by: ayushmk7 <contactayushmadhav@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #684
Gemma-style BPE vocabularies with
byte_fallbackemit<0xHH>pieces for codepoints missing from the vocab. Thereplace_metaspacepath inBPETokenizer::decodeappended them verbatim, so output looked like잠 <0xEA><0xB9><0xB0> 수 있는instead of잠 깰 수 있는.<0xHH>pieces are now mapped back to raw bytes whenbyte_fallbackis enabled, matching whatSPTokenizer::decodealready does.Testing
cactus-engineon macOS arm64.▁잠 <0xEA> <0xB9> <0xB0>: returns" 잠깰"with this change (literal<0xEA>…onmain); withbyte_fallback=falsethe piece is left as is.