Repository navigation
Conversation
vocab.txt is written as ID<TAB>token or ID<TAB>token<TAB>score. The loader split on the first tab inside the token, so Gemma tokens such as "\t\t\t" were parsed as a score and init failed with a std::stof exception. Detect the scored format from the first line and split the score on the last tab only when scores are present. Fixes cactus-compute#577 Signed-off-by: ayushmk7 <contactayushmadhav@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #577
vocab.txtis written asID\ttokenorID\ttoken\tscore. The loader split on the first tab inside the token, so Gemma tokens like"\t\t\t"were read as a score: eitherstd::stofthrows during init, or the token is silently truncated.The scored format is now detected from the first line, and the score is split off the last tab only when scores are present. Unscored files never parse a score, so tokens such as
"\t1"stay intact.Testing
cactus-engineon macOS arm64.main, passes with this change.