Skip to content

feat: Option type default to string #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suguanYang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Option type default to string #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/__test__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ test('negated option', () => {

cli.option('--foo [foo]', 'Set foo').option('--no-foo', 'Disable foo')

cli.option('--bar [bar]', 'Set bar').option('--no-bar', 'Disable bar')
cli.option('--bar', 'Set bar').option('--no-bar', 'Disable bar')

const { options } = cli.parse(['node', 'bin', '--foo', 'foo', '--bar'])
expect(options).toEqual({
Expand Down Expand Up @@ -115,7 +115,7 @@ test('array types without transformFunction', () => {
type: [],
}
)
.option('--scale [level]', 'Scaling level')
.option('--scale', 'Scaling level')

const { options: options1 } = cli.parse(
`node bin --externals.env.prod production --scale`.split(' ')
Expand All @@ -142,7 +142,7 @@ test('array types with transformFunction', () => {
.option('--config <configFlie>', 'Use config file for building', {
type: [String],
})
.option('--scale [level]', 'Scaling level')
.option('--scale', 'Scaling level')

const { options } = cli.parse(
`node bin build app.js --config config.js --scale`.split(' ')
Expand Down
9 changes: 6 additions & 3 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const findAllBrackets = (v: string) => {
return {
required: match[0].startsWith('<'),
value,
variadic
variadic,
}
}

Expand All @@ -40,10 +40,11 @@ interface MriOptions {
[k: string]: string[]
}
boolean: string[]
string: string[]
}

export const getMriOptions = (options: Option[]) => {
const result: MriOptions = { alias: {}, boolean: [] }
const result: MriOptions = { alias: {}, boolean: [], string: [] }

for (const [index, option] of options.entries()) {
// We do not set default values in mri options
Expand All @@ -62,7 +63,7 @@ export const getMriOptions = (options: Option[]) => {
const hasStringTypeOption = options.some((o, i) => {
return (
i !== index &&
o.names.some(name => option.names.includes(name)) &&
o.names.some((name) => option.names.includes(name)) &&
typeof o.required === 'boolean'
)
})
Expand All @@ -72,6 +73,8 @@ export const getMriOptions = (options: Option[]) => {
} else {
result.boolean.push(option.names[0])
}
} else {
result.string.push(option.names[0])
}
}

Expand Down