🛡️ Sentinel: [CRITICAL/HIGH] Fix TOCTOU vulnerability in file creation#381
🛡️ Sentinel: [CRITICAL/HIGH] Fix TOCTOU vulnerability in file creation#381acebytes wants to merge 1 commit into
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd7b11f024
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let logDir = FileManager.default.homeDirectoryForCurrentUser | ||
| .appendingPathComponent(".cacheout") | ||
| try? FileManager.default.createDirectory(at: logDir, withIntermediateDirectories: true) | ||
| try? FileManager.default.createDirectory(at: logDir, withIntermediateDirectories: true, attributes: [.posixPermissions: 0o700]) |
There was a problem hiding this comment.
On upgrades where ~/.cacheout already exists from the previous implementation, this call does not change its mode; createDirectory only applies attributes to newly-created directories (the same repo handles this explicitly in DaemonMode.setup). As a result, users with a pre-existing 0755 state directory continue exposing cleanup.log metadata to other local users even after this security fix, so this path should chmod the directory after creation and similarly handle any existing log file mode.
Useful? React with 👍 / 👎.
| try? entry.write(to: logFile, atomically: true, encoding: .utf8) | ||
| _ = logFile.withUnsafeFileSystemRepresentation { pathPtr -> Int32 in | ||
| guard let pathPtr = pathPtr else { return -1 } | ||
| let fd = open(pathPtr, O_CREAT | O_WRONLY | O_APPEND | O_NOFOLLOW | O_CLOEXEC, 0o600) |
There was a problem hiding this comment.
If ~/.cacheout is already a symlink, createDirectory accepts it and this open() still follows that intermediate component; O_NOFOLLOW only rejects cleanup.log itself. In that pre-created-symlink scenario the security fix continues writing the log outside the intended state directory, so the directory component needs to be opened/validated without following symlinks before appending the file.
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Fixed insecure file creation permissions
🎯 Impact: Fixed an issue where insecure permissions could lead to an attack
🔧 Fix: Fixed insecure file creation permissions
✅ Verification: Review the code to confirm the changes
PR created automatically by Jules for task 143650929542343798 started by @acebytes