⚡ Bolt: [performance improvement] Eliminate eager array allocations in computed properties#368
Conversation
…n computed properties Replaced eager `.filter` calls with `.lazy.filter` and `.contains(where:)` in `CacheoutViewModel` and `MenuBarView`. Calling `.filter` followed by `.isEmpty` or `.count` allocates a complete array just to check boolean state or get a count, causing memory churn in frequently evaluated SwiftUI computed properties. Additionally, checking `selectedNodeModulesSize > 0` forced a full iteration over node modules instead of short-circuiting. Reduces intermediate array allocations during rendering and O(N) operations to O(1) short-circuiting when checking selections, improving frame rates. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced eager
.filtercalls with.lazy.filterand.contains(where:)inCacheoutViewModelandMenuBarView.🎯 Why: Calling
.filterfollowed by.isEmptyor.countallocates a complete array just to check boolean state or get a count, causing memory churn in frequently evaluated SwiftUI computed properties. Additionally, checkingselectedNodeModulesSize > 0forced a full iteration over node modules instead of short-circuiting.📊 Impact: Reduces intermediate array allocations during rendering and O(N) operations to O(1) short-circuiting when checking selections, improving frame rates.
🔬 Measurement: Verify memory allocations remain stable when toggling selections in the UI or leaving the menu bar open.
PR created automatically by Jules for task 14204071518616257543 started by @acebytes