Repository navigation
Desktop 4.1.2: MP4 streaming and consistent media controls - #229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MP4 Media uploads with valid trailing metadata were incorrectly marked non-streamable by 4.1.1. Follow Telegram Desktop 7.3.1's atom-search decision order so local and URL uploads carry the expected streaming flag, while retaining full bounded container validation and the original bytes.
The media viewer also had text actions constrained to 32 px icon widths, causing overlapping labels. Give labeled actions their own sizing, group and wrap playback controls, keep video/audio viewers and expanded details within the viewport, and anchor badges to the video. Match the closed-control appearance of native dropdowns across playback, slideshow, settings, sync and workspace forms, preserving keyboard selection and touch targets.
Update Rustls to 0.23.46 to resolve the four upstream advisories reported by the dependency gate. No waiver or baseline change.
Keep packaged smoke cleanup strict while allowing briefly locked private WebView profiles to settle after the owned Windows Job is confirmed empty. Retry only the existing exact profile/root removals with bounded filesystem backoff; persistent locks still fail. Windows application-boundary journeys hold real external file locks through shutdown and cover transient recovery plus persistent failure.
Validation:
Automated Telegram boundaries are controlled fixtures. The owner's upload and streaming/seeking of the actual video over 200 MB on a clean Windows Telegram Desktop receiver is pending post-release acceptance. No new 200 MB test was added. Native select popup rendering remains OS-controlled.
Android projects, source, signing material and temporary UI preview files are excluded from the outgoing commits. Existing Android release assets are unchanged.