[stable] Destabilize the Error::type_id function#60785

[xmoezzz]

Description of Change

This pull-request is a small first step in trying to bring support for Wayland to Electron. I'm planning to follow up on this with more pull-requests in an effort to upstream these Wayland patches.

However, those patches will need some adjustments in order to make them compatible with the upcoming Chromium changes (chromium#1085700) which will soon be merged into Electron (#25488). In particular, it should be taken into consideration that the USE_X11 and USE_OZONE build flags are no longer mutually exclusive.

Also, USE_X11 is going away so it might be desirable as a long term goal to remove it from Electron too and replace it with the Ozone equivalents.

With that in mind, this pull-request replaces a few instances of #if defined(USE_X11) with #if defined(OS_LINUX) where it was identified that the guarded code could be shared with Ozone.

The more meaningful changes will come in the upcoming pull-requests but I'll be waiting for these chromium changes to be pulled into Electron first (#24984, #25488).

Checklist

• PR description included and stakeholders cc'd (@zcbenz @hedgepigdaniel)
• npm test passes
• PR title follows semantic commit guidelines

Release Notes

Notes: none

[MonnetalX]

🔍 PR Link Analysis

🔗 Ranked Links

#1 electron/electron#25522

🔍 This pull request replaces USE_X11 with OS_LINUX guards to share code with Ozone, as a first step toward bringing Wayland support to Electron.

[MonnetalX]

🔍 PR Link Analysis

🔗 Ranked Links

#1 these Wayland patches

🔍 This pull request is a small first step toward bringing Wayland support to Electron by upstreaming patches that conditionally use Ozone-specific implementations for global shortcut listeners and remove X11-only sources from Ozone builds.

#2 going away

🔍 This pull request is a small first step toward bringing Wayland support to Electron by upstreaming patches from an existing fork.

#3 commit guidelines

🔍 This pull request is a small first step toward bringing Wayland support to Electron, referencing upstream patches and build instructions for contributing.

#4 https://github.com/electron/electron/blob/master/CONTRIBUTING.md

🔍 The pull request aims to bring Wayland support to Electron, and the linked contributing guide outlines the project's guidelines for proposing changes, including that contributors should use best judgment and can propose changes to the document via pull requests.

#5 chromium#1085700

🔍 The patch introduces a new display property to the BrowserWindow constructor, enabling developers to specify which display a window should open on, which is a foundational step for multi-monitor and Wayland support.

#6 these chromium changes

🔍 The Error::type_id function is being destabilized to allow for future improvements in error handling and type identification.