Fix Issue 1693 (keymap files, e.g. db48x.48k, load incomplete )#1694
Open
evgaster wants to merge 2 commits into
Open
Fix Issue 1693 (keymap files, e.g. db48x.48k, load incomplete )#1694evgaster wants to merge 2 commits into
evgaster wants to merge 2 commits into
Conversation
Tau mass constant had incorrect relative uncertainty. It was based on Munon values. Corrected the expression to use Tau values. Signed-off-by: Ed@vanGasteren.net
The keymap files (.../config/*.48k) did not load completely. For some planes the loading stopped early. This was due to incorrect handling of the comment character "@". Even a "@", a quoted At character, was treated as start of comment. So everything behind it on the same line got skipped. This also causes an inbalance of the number of double quote characters. There was a weird attempt to work around this with a "!' string in the keymap files. It has a leading double and a trailing single quote! Fixed the comment handling. Fixed the weird trailing single quote. Added internal documentation to db48x.48k. Corrected the plane numbering and description. Corrected a few incorrect mappings (according to the keyboard overlay). Fixes: c3d#1693 Signed-off-by: Ed@vanGasteren.net
Author
|
The Tau commit doesn't belong here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make keymap files load completely.
Further details in the commit.