Skip to content

Adding Python3 compatibility#13

Open
tobypatterson wants to merge 2 commits into
c0z3n:masterfrom
tobypatterson:master
Open

Adding Python3 compatibility#13
tobypatterson wants to merge 2 commits into
c0z3n:masterfrom
tobypatterson:master

Conversation

@tobypatterson

Copy link
Copy Markdown

I've been testing using a UltraDMX Micro and a 1ByOne disco ball ($35 Amazon). Seems to run fine using both Python 2.7.11 and 3.5.1 .

  • Use bytearray() to concatenate bytes
  • Removed sys.exit()
  • Use logging instead of print
  • Added a auto_commit argument to the constructor
  • Updated setup to indicate 3.5 compatibility

@quesojim

Copy link
Copy Markdown

Dude that's awesome. Still getting issues with my device saying it couldn't open on COM4. Not sure what I'm doing wrong

@tobypatterson

tobypatterson commented Jun 25, 2016

Copy link
Copy Markdown
Author

Try the python2 version, of the original code. I tested on MacOS X and a Rasp Pi2 running Debian - in both cases, there is a special device file in /dev that is created.

@sabjorn

sabjorn commented Mar 13, 2019

Copy link
Copy Markdown

@c0z3n any chance of this getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants