Assert that Mach-O section_flags_mut is 0#13153
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 21, 2026
Merged
Assert that Mach-O section_flags_mut is 0#13153alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
Author
|
Dunno if I can do: |
Contributor
|
This can probably be a full assert. It isn't on a perf criticial path. (I don't have write permissions for Cranelift) |
github-actions
Bot
added
cranelift
To ensure we don't unintentionally overwrite default flags.
madsmtm
force-pushed
the
debug-assert-flags-0
branch
from
514e638 to
5547f9a
Compare
madsmtm
changed the title
Contributor
Author
|
I've made it a full assertion |
bjorn3
approved these changes
Apr 21, 2026
alexcrichton
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure we don't unintentionally overwrite default flags. Discussed in #13137 (comment).