Skip to content

fix(dataflow): collect local callback prop sites on demand - #456

Merged
byronwall merged 1 commit into
mainfrom
codex/srcly-demand-callback-props
Nov 22, 2026
Merged

byronwall merged 1 commit into
mainfrom
codex/srcly-demand-callback-props

Conversation

@byronwall

Copy link
Copy Markdown
Owner

Fixes #441.

The forward demand collector could start inside a child component without loading the JSX occurrence that supplies its named callback prop. The existing binding pass already knew how to pair onQuery={setQuery} with that occurrence once it collected the parent. The lazy path only requested callers for children.

Discover named prop sites through the checker-backed component reference index and queue only matching JSX tag partitions carrying that prop. Reuse the existing occurrence-bound proof; the demand collector does not fall back to eager collection or make new claims about unresolved handlers. An unresolved supplied callback still reports a partial trace without a render destination.

Verified the actual React pattern catalog's lifted-state case (with a minimal React type shim): from the child event value, cold and shuffled demand results equal eager including the binding witness, query state, and query render terminal. The cold main case visits one source file and fewer than six statement partitions. The negative has an unresolved supplied callback and a separate same-name component, with no invented binding or render endpoint. 23 demand/parity/transport/lifecycle tests passed; engine typecheck and lint passed. Full local browser verification blocked by Chromium CDN HTTP 403; required browser CI runs on the PR.

Survey moves: none across 634 traces (102 client, 330 fixtures, 202 server).

@byronwall
byronwall marked this pull request as ready for review November 22, 2026 21:11
@byronwall
byronwall enabled auto-merge (squash) November 22, 2026 21:11
@byronwall
byronwall merged commit b882bc7 into main Nov 22, 2026
7 checks passed
@byronwall
byronwall deleted the codex/srcly-demand-callback-props branch November 22, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve local React callback props in the interactive demand path

1 participant