Skip to content

fix(findings): explain when ESLint ignores the selected scope - #448

Merged
byronwall merged 1 commit into
mainfrom
dot/srcly-ux017-eslint-reason
Nov 22, 2026
Merged

byronwall merged 1 commit into
mainfrom
dot/srcly-ux017-eslint-reason

Conversation

@byronwall

Copy link
Copy Markdown
Owner

UX-017: Explain an unassessed ESLint result

ESLint can legitimately ignore every file in the selected scope. Its failure output may start with a generic banner before explaining the ignore or configuration condition. Findings used that banner as the entire reason.

  • Detect the specific all-files-ignored diagnostic on either output stream and point to the configured ignore and file patterns.
  • Keep the checker unassessed (N/A), not a clean result. Unrecognized failures show the exit code and point to running ESLint directly, without copying raw process output. The project's lint configuration and successful findings path are unchanged.

Verification

  • Three new focused regression tests fail on the study baseline and pass with this change.
  • Real ESLint against the intentionally ignored fixture now gives the actionable N/A result.
  • Ruff and git diff --check pass. The broader findings test file has 21 passes and one project-ID fixture failure reproduced unchanged on the baseline in this sandbox.

@byronwall
byronwall marked this pull request as ready for review November 22, 2026 20:18
@byronwall
byronwall enabled auto-merge (squash) November 22, 2026 20:18
@byronwall
byronwall merged commit 818ec72 into main Nov 22, 2026
7 checks passed
@byronwall
byronwall deleted the dot/srcly-ux017-eslint-reason branch November 22, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant