Repository navigation
fix(site): build before Playwright starts the preview server - #413
Merged
Merged
Conversation
The site tests failed on a clean checkout because `vite preview` needs `site/dist`. Playwright's web server now runs `pnpm build` first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm testinsite/now passes on a clean checkout. Playwright's web server runspnpm buildbeforevite preview, so you no longer have to build by hand first.User impact: None. The public site does not change.
Why
The nightly main check on
c3f3ab7afailed insite:test. That check runstypecheckandtestbut notbuild.vite previewthen stopped withThe directory "dist" does not exist. Did you build your project?.Proof
I deleted
site/distandsite/.ssr, ranpnpm install, then ranpnpm testinsite/on this branch:pnpm typecheckinsite/also passes. This is a config change, so command output is the strongest proof.Limits
.github/workflows/site.ymlstill runspnpm buildbeforepnpm test, so CI now builds the site twice. The build takes a few seconds. Remove that step if you don't want the second build.🤖 Generated with Claude Code