Skip to content

feat(client): Change Lens review panel components - #409

Merged
byronwall merged 3 commits into
change-lens/serverfrom
change-lens/panel
Nov 22, 2026
Merged

byronwall merged 3 commits into
change-lens/serverfrom
change-lens/panel

Conversation

@byronwall

@byronwall byronwall commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Four review components for the Changes view: the review lists, the chunk inspector, the hunk diff, and the commit rail. They take data through props only. The app does not mount them until #411. Part of #397.

What you'll see

  • Nothing changes in the app in this layer.
  • A dev-only page, client/panel-harness.html, shows all four components on sample data.

Proof

All four components on the sample data
The commit rail, the review lists, the inspector with base → head metrics and touch marks, and the hunk diff with word highlights.

The components at 280px
A 280px panel: long names cut short and nothing overflows.

A reverted chunk
A reverted chunk says that it was changed and put back.

  • The panel worker ran pnpm typecheck and pnpm test (476 passed, 9 new for the diff parser, the rail scale, list order and touch placement). On the top of the stack, scripts/check.sh client passes with 492 tests.
  • These screenshots are from the harness on sample data, taken before the rebase onto the fixed server layer. The components did not change in the rebase.

Limits

  • The app has no dark theme, so none was checked.
  • The harness shows the same sample diff for every chunk.

Stack: Change Lens, layer 2 of 4

This slice: The review panel components, their pure helpers and tests, and a dev harness.
Why it is its own layer: They are props-only and touch no shared file, so the diff reads alone. The map layer above mounts them.
Full story: #408

Survey moves: +3 partial traces in client and their stops (frontier: disconnected +11, boundary: unproven-handoff +5, frontier: untraced +3). All come from the new client/src/changelens/panel/ files entering the surveyed corpus. No analysis code changed and no trace errored.

🤖 Generated with Claude Code

@byronwall
byronwall added this pull request to stack #412 November 21, 2026 23:58
@byronwall byronwall changed the title change lens/panel feat(client): Change Lens review panel components Nov 21, 2026
byronwall and others added 3 commits November 21, 2026 22:00
ReviewBuckets, ChunkInspector, HunkDiff and CommitRail take data through
props only. A small unified diff parser, a compressed rail time scale and
touch-strip placement are pure and tested. client/panel-harness.html mounts
all four on a hand-made sample payload in dev.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Paired lines mark changed words with a token LCS instead of a prefix and
suffix trim. Lines that share less than half their text get no marks,
since they were rewritten.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@byronwall
byronwall marked this pull request as ready for review November 22, 2026 03:03
@byronwall
byronwall merged commit a88eb89 into main Nov 22, 2026
12 of 13 checks passed
@byronwall
byronwall deleted the change-lens/panel branch November 22, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant